Received-SPF: pass (google.com: domain of linux-kernel+bounces-188392-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <607db056-1208-4353-a666-fe0d52a6b286@ti.com>
Date: Fri, 24 May 2024 12:48:56 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] arm64: dts: ti: k3-j722s-evm: Mark eMMC as non removable
Content-Language: en-US
To: Vignesh Raghavendra <vigneshr@ti.com>, <linux-kernel@vger.kernel.org>,
        <devicetree@vger.kernel.org>
CC: <linux-arm-kernel@lists.infradead.org>, <conor+dt@kernel.org>,
        <krzk+dt@kernel.org>, <robh@kernel.org>, <kristo@kernel.org>,
        <jm@ti.com>, <nm@ti.com>
References: <20240522083631.1015198-1-b-kapoor@ti.com>
 <24d0579a-1c8d-42ea-afa5-dcd0ab3fa193@ti.com>
From: Bhavya Kapoor <b-kapoor@ti.com>
In-Reply-To: <24d0579a-1c8d-42ea-afa5-dcd0ab3fa193@ti.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 23/05/24 3:24 pm, Vignesh Raghavendra wrote:
>
> On 22/05/24 14:06, Bhavya Kapoor wrote:
>> Mark the eMMC module on J722S as non removable since it
>> is always present on the evm.
> Nit s/evm/EVM
This definately demands a v2
>
>> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
>> ---
> This needs a Fixes tag?

Hi Vignesh, we are just adding up a property so i assume we should not 
need a fixes tag.

We can take reference from how its done in this patch: 
https://patchwork.kernel.org/project/linux-samsung-soc/patch/1444927873-15140-7-git-send-email-javier@osg.samsung.com/

>
>>   arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
>> index bf3c246d13d1..fe810e32cb7a 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
>> @@ -369,6 +369,7 @@ partition@3fc0000 {
>>   &sdhci0 {
>>   	disable-wp;
>>   	bootph-all;
>> +	non-removable;
>>   	ti,driver-strength-ohm = <50>;
>>   	status = "okay";
>>   };
>