Received: by 2002:a89:d88:0:b0:1fa:5c73:8e2d with SMTP id eb8csp379464lqb; Fri, 24 May 2024 00:40:59 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXWw5HAmCpN1LHEajeGcXeuBRgpvk1paNn+RSGeyFDCqotgjYGogE6EU1/EqL2Q4rsoRnB1Gn/j0Mgcj7yKH42KIvURB3837pCdVLgs8w== X-Google-Smtp-Source: AGHT+IHGJmOAqOh35UNCSb5Lm99IsiPmOq2dgABc5/eB5lIw0Ed9ZwD5m1DAi6K13AWwwdm4Edch X-Received: by 2002:a50:8742:0:b0:570:1ea8:c50a with SMTP id 4fb4d7f45d1cf-57851901fe3mr924701a12.6.1716536459474; Fri, 24 May 2024 00:40:59 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716536459; cv=pass; d=google.com; s=arc-20160816; b=0xlv3T1CfDL03x2/0xOtqLz30sib9GG3MropKVOSFrzgKYANamLRazTGfoEfkf3Urq fGmWSmYhi9JQaXVYOfMcouU8cOzDfuv/uIIm2Dyrshk+YmFnI+OIMMifNRIN0Wl/0egH uTMyx47EeEPKgwLOd8znUB/aoK81e1IZecdB3spdPgQYZoj/77x93Z2dl5qNLOLMktrO EAXfi4JqxyHhTCT85itLk4O8WL6ednk85YTwMBoEKSJ1BZ/vDBt8MeS8c6Kl2X6WK7RK O77NmW4qIjxe7rhL6R270DSFa8QIkzJJZ599gthB3vSUdppqCWsGvNu0n3BMrv9fpO0S tYtA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date; bh=M7NmYC/Iylm9myghHwqILim55SAUt9QrM+UZYk0eJlw=; fh=XhzkK++SNPdzRRkGnTt1a99nTMgB34qU1+2VMij/aqE=; b=zDbqQfwszE+xtnREi+I6AqIb6HXqNAWhpWlTHnTzTTG0j9oy/YO1PDu932thh5cyhJ hNsu5WzrYql1BUdNtDlAFBCFoaTKRnek6pAbtyz4YW7MJQjuWkW5pEzSzMPXf/WNBvGy J8YNBTmev5jrc1GkKd7L50rL8UbbhMuJmVv8lnmxhoZh+F704WnM8NBoKsyeclK4cwDj P07psy3Eb7LgAQ1TU9mCYfKi9SLbys3YwhuXFcPYLevZT50oFQZ57pnce9CwTMS/rKh3 Ux6d1RUF88IcM6ub5H/Fz4a/Fs3nUA/f1O5RN20qmc/B/ISDtLoOkDl48XqwfpeRGnvC N76A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=lst.de); spf=pass (google.com: domain of linux-kernel+bounces-188409-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-188409-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-578524968aesi572745a12.455.2024.05.24.00.40.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 May 2024 00:40:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-188409-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=lst.de); spf=pass (google.com: domain of linux-kernel+bounces-188409-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-188409-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 3B53F1F22297 for ; Fri, 24 May 2024 07:40:59 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4844812882C; Fri, 24 May 2024 07:40:55 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EE4D127E28 for ; Fri, 24 May 2024 07:40:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716536454; cv=none; b=rbZ1EjM35lBEsszPKtTC30xdE3uMR01StNTEPruU12yCPFO9GB0sQxjX53e5v+SwjF5QKe5qoK0d8pfJIRWMkQiKe8mrD7pZjcoOtNV+Fh8OoBUjyaEXJtdyYeqqQs3UOgX4Z+LKZ2isFQP+hnNS4cHaHnlwFPYzWRwi3FO8orY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716536454; c=relaxed/simple; bh=M7NmYC/Iylm9myghHwqILim55SAUt9QrM+UZYk0eJlw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DUjfVsIz13FwFKmMrzj082oxNSZikOeUeYNfV3qDMk9SFhcPVj45SGWbT54RW7bdUfKrq3n1pN54QzgSuJZyHnMgxMbRkCbNUPyRrFech/7yLTHMZUTQ5UU8hY0d2KAG/cJo8PjgqbmariuAbv6W2tcsJltQgtkMWXompc/XzBQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 4FA0468BEB; Fri, 24 May 2024 09:40:49 +0200 (CEST) Date: Fri, 24 May 2024 09:40:48 +0200 From: Christoph Hellwig To: Kundan Kumar Cc: axboe@kernel.dk, hch@lst.de, kbusch@kernel.org, sagi@grimberg.me, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, joshi.k@samsung.com, anuj20.g@samsung.com, nj.shetty@samsung.com, c.gameti@samsung.com, gost.dev@samsung.com Subject: Re: [PATCH] nvme: adjust multiples of NVME_CTRL_PAGE_SIZE in offset Message-ID: <20240524074048.GA17251@lst.de> References: <20240523113149.29174-1-kundan.kumar@samsung.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240523113149.29174-1-kundan.kumar@samsung.com> User-Agent: Mutt/1.5.17 (2007-11-01) Looks good: Reviewed-by: Christoph Hellwig