Received-SPF: pass (google.com: domain of linux-kernel+bounces-188433-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Content-Type: multipart/signed;
 boundary=fb8b70f1c41e009f374399bb3450b2fa3c696c750a469b66dabbee56955e;
 micalg=pgp-sha256; protocol="application/pgp-signature"
Precedence: bulk
Mime-Version: 1.0
Date: Fri, 24 May 2024 10:01:42 +0200
Message-Id: <D1HPTY9MKVCF.WZDYWSJUWFYM@gmail.com>
From: "Thierry Reding" <thierry.reding@gmail.com>
To: "Krzysztof Kozlowski" <krzk@kernel.org>, "Krishna Yarlagadda"
 <kyarlagadda@nvidia.com>, <linux-tegra@vger.kernel.org>,
 <devicetree@vger.kernel.org>, <linux-doc@vger.kernel.org>,
 <linux-i2c@vger.kernel.org>, <linux-mmc@vger.kernel.org>,
 <linux-kernel@vger.kernel.org>
Cc: <jonathanh@nvidia.com>, <robh@kernel.org>, <krzk+dt@kernel.org>,
 <conor+dt@kernel.org>, <corbet@lwn.net>, <andi.shyti@kernel.org>,
 <wsa+renesas@sang-engineering.com>, <ulf.hansson@linaro.org>,
 <adrian.hunter@intel.com>, <digetx@gmail.com>, <ldewangan@nvidia.com>,
 <mkumard@nvidia.com>
Subject: Re: [RFC PATCH 03/11] soc: tegra: config settings binding document
References: <20240506225139.57647-1-kyarlagadda@nvidia.com>
 <20240506225139.57647-4-kyarlagadda@nvidia.com>
 <29e26d22-04b3-47ee-ba70-9f4eb77326f7@kernel.org>
In-Reply-To: <29e26d22-04b3-47ee-ba70-9f4eb77326f7@kernel.org>

--fb8b70f1c41e009f374399bb3450b2fa3c696c750a469b66dabbee56955e
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8

On Tue May 7, 2024 at 8:32 AM CEST, Krzysztof Kozlowski wrote:
> On 07/05/2024 00:51, Krishna Yarlagadda wrote:
> > Config framework parses device tree and provides a list of register
> > settings with mask per mode to be applied by the controller.
> >=20
> > Add binding document for config settings framework. Config settings
> > are defined as a property per field and have different modes per device=
.
>
> Please use subject prefixes matching the subsystem. You can get them for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> your patch is touching. For bindings, the preferred subjects are
> explained here:
> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-pat=
ches.html#i-for-patch-submitters
>
> >=20
> > Signed-off-by: Krishna Yarlagadda <kyarlagadda@nvidia.com>
> > ---
> >  .../misc/nvidia,tegra-config-settings.yaml    | 50 +++++++++++++++++++
> >  MAINTAINERS                                   |  1 +
> >  2 files changed, 51 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/misc/nvidia,tegra=
-config-settings.yaml
> >=20
> > diff --git a/Documentation/devicetree/bindings/misc/nvidia,tegra-config=
-settings.yaml b/Documentation/devicetree/bindings/misc/nvidia,tegra-config=
-settings.yaml
> > new file mode 100644
> > index 000000000000..e379cbd5b597
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/misc/nvidia,tegra-config-settin=
gs.yaml
> > @@ -0,0 +1,50 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/misc/nvidia,tegra-config-settings.y=
aml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Config properties for a device.
>
> No full stop, that's a title.
>
> > +
> > +description:
> > +  Config setting is the configuration based on chip/board/system
> > +  characterization on interface/controller settings. This is needed fo=
r
> > +  - making the controller internal configuration to better perform
> > +  - making the interface to work proper by setting drive strength, sle=
w
> > +    rates etc
> > +  - making the low power leakage.
> > +  There are two types of recommended configuration settings
> > +  - Controller register specific for internal operation of controller.
> > +  - Pad control/Pinmux/pincontrol registers for interfacing.
> > +  These configurations can further be categorized as static and dynami=
c.
> > +  - Static config does not change until a controller is reset.
> > +  - Dynamic config changes based on mode or condition, controller is
> > +    operating in.
> > +
> > +maintainers:
> > +  - Thierry Reding <thierry.reding@gmail.com>
> > +
> > +patternProperties:
> > +  "^[a-z0-9_]*$":
> > +    description:
> > +      Config name to be applied on controller.
> > +    type: object
>
> Nope, this means nothing. Sorry, describe hardware, do not create some
> fake nodes.

We're trying to solve a real problem here, though. In order for the
hardware to operate properly we need certain parameters to be programmed
into the hardware.

If this is not acceptable, do you have a suggestion on where else to put
this information?

Thierry

--fb8b70f1c41e009f374399bb3450b2fa3c696c750a469b66dabbee56955e
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmZQSWcACgkQ3SOs138+
s6FkbQ//TcU3nWtL50zZ6CO7YiGnMZvV0R3SIBQaxEZaD/C4mMNwfyJoHH5vQ87E
CnYewOH/nzdwzIUQsG3iY0mCQamHuJgC/N5JDvlDg/Y9TmFYq59F8DC584Ueh4DN
l2k/0HcAB89IU2+C1rZ/RwcTMgLNpMcGXYf2ZbgI0UtkHAPsW5X5HlKWivupg21B
9tU73AKBHd9kbS5u3WxtzwbPDgFlSY26et+HgNuDpTQpbLsEKMMFcAz2S4+/36L8
IB4eJk8DLtTFnQ5dzYiNbOWk/T8L7GNkPAyiuD2yYVJC7ISbzVsFlXrwR1OGbGTz
rVwQOB4W727+pfj+oneHHF2y5H+wcSZs15yqPARC6TAb3PuwwUGzEcNqim7Upzpf
DwC7OWP78ieFgfRX/6CfOVtNtXUEPFwVVBvnaWGwveecpXrW+4V28WQItY7iPgZ2
kff+q54lIbEoNIJagO7qaomRbjL2jQ2WH8wkTzs/8ItFYxIh8LADLrzgnrByV9ik
b23yGaLv+qWDIwzIr2rFggiBqeMl/PITM9aN2FQvrcsNoNtsRMttljYEFKu9FP4D
YMa5rJh3sHCYCwsroLMZTo3jLLVmZKgp5+vPZgfdiUYglWphC7LrQKN4WjUeOwsH
6RQDaOFra+X0ri/GnNRb+xfrHJC5QCpYlmoLySobHrv6MuiP7Vc=
=2nUy
-----END PGP SIGNATURE-----

--fb8b70f1c41e009f374399bb3450b2fa3c696c750a469b66dabbee56955e--