Received-SPF: pass (google.com: domain of linux-kernel+bounces-188441-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Content-Type: text/plain;
	charset=us-ascii
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.500.171.1.1\))
Subject: Re: [PATCH] livepatch: introduce klp_func called interface
From: zhang warden <zhangwarden@gmail.com>
In-Reply-To: <18994387-2d2f-41e5-9ef6-6541dd0015d2@moroto.mountain>
Date: Fri, 24 May 2024 16:12:57 +0800
Cc: Josh Poimboeuf <jpoimboe@kernel.org>,
 Miroslav Benes <mbenes@suse.cz>,
 Jiri Kosina <jikos@kernel.org>,
 Petr Mladek <pmladek@suse.com>,
 Joe Lawrence <joe.lawrence@redhat.com>,
 live-patching@vger.kernel.org,
 linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <9C317446-0259-445B-8AE7-D91E1E5ABF93@gmail.com>
References: <20240519074343.5833-1-zhangwarden@gmail.com>
 <18994387-2d2f-41e5-9ef6-6541dd0015d2@moroto.mountain>
To: Dan Carpenter <dan.carpenter@linaro.org>


> On May 23, 2024, at 22:22, Dan Carpenter <dan.carpenter@linaro.org> =
wrote:
>=20
> Always run your patches through checkpatch.
>=20
> So this patch is so that testers can see if a function has been =
called?
> Can you not get the same information from gcov or ftrace?
>=20
> There are style issues with the patch, but it's not so important until
> the design is agreed on.
>=20
> regards,
> dan carpenter

Hi, Dan.

This patch have format issues as Markus said. A newer version of this =
patch is sent which is checked by ./scripts/checkpatch.pl

Thanks for your suggestions.

Regards,
Wardenjohn