Received-SPF: pass (google.com: domain of linux-kernel+bounces-188470-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Naohiro Aota <Naohiro.Aota@wdc.com>
To: Johannes Thumshirn <jth@kernel.org>
CC: Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>, David Sterba
	<dsterba@suse.com>, Hans Holmberg <Hans.Holmberg@wdc.com>,
	"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Filipe Manana
	<fdmanana@suse.com>, Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
Subject: Re: [PATCH v4 2/2] btrfs: reserve new relocation block-group after
 successful relocation
Thread-Topic: [PATCH v4 2/2] btrfs: reserve new relocation block-group after
 successful relocation
Thread-Index: AQHarST8zRWREytAS0un9b8E/7cIVbGmD8QA
Date: Fri, 24 May 2024 08:33:19 +0000
Message-ID: <hw4t6fcvydkd5j7iyyt7hx3itrfy4rtigm4lw7u3fgsql4vksr@vuj7lftxpvss>
References: <20240523-zoned-gc-v4-0-23ed9f61afa0@kernel.org>
 <20240523-zoned-gc-v4-2-23ed9f61afa0@kernel.org>
In-Reply-To: <20240523-zoned-gc-v4-2-23ed9f61afa0@kernel.org>
Accept-Language: ja-JP, en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?Sw7HhDWMtvyNtl+bHWFmb07OkT7s4oWyRRjTtC3aDE0FqL5TUkZQnstkQXGV?=
 =?us-ascii?Q?wYhUh7nQQGX1rbnzIpRr5LeQ4Fg7NWp7abSzKN1kbeSDumwDP2/ZYYj0YeMD?=
 =?us-ascii?Q?/i6mBpgnuSMhah4rOxc6cwvh1qvhtNFTDNO7GHKhVUthEyRpNMa8w1ONdbKS?=
 =?us-ascii?Q?YYzGmW2zsBi5Os45GLjJiNejS8+S8OsGcHGgN4qkve/rp0wdPpb9WLIboi8x?=
 =?us-ascii?Q?cLc/zEvyTkUdJtoL5qNpYA8aQYhhemlhkhKMyLX0UsBqOPrU2FJxaXB658mN?=
 =?us-ascii?Q?U0frAbrCJNPKuw9uSxMZcQR3WL8fVulOr4DZhtphP0qQE3nw7YSV84AudYxf?=
 =?us-ascii?Q?ugoPWKmx8xF6BWMOG+nHAPU/ntkR9g4BhJ033HtB2qMiFKAZhoRaelqPQ1OB?=
 =?us-ascii?Q?na4g4UoXJ0kupRYW9jQj02/94xf1+q5eNd6iPGA7+JlExo8W33frj4gFdHaN?=
 =?us-ascii?Q?o1coOioiiGdihh+NjII2Im9m64KtJQtq7+GTbrdUvnFTu5zl+3Rsk/s4hgdi?=
 =?us-ascii?Q?dlGVoDk/4q6jxvjueL2t/cSS8h0FDH1mhRSgViw2790x+/EeYmGS2W3H8UeK?=
 =?us-ascii?Q?DSugDfHD9sBnl/a9QDiin5kPqg9ZhGKKG99H2F4i8uY3Gb2DPnJO+r5kFwJI?=
 =?us-ascii?Q?4F1Ihqde6CoMPwlgVUehL/DKpLIbDZeIt9Z3gtSVc+i6e04qTmEyDKHm1363?=
 =?us-ascii?Q?u8adE6nVEKXmy5h5KaCSEjqbrrKZuoDwqxSYmQ5BLCZnNEEA4BVRI/B9Mo6F?=
 =?us-ascii?Q?oraOTia4o6Suy0cvgAZV3E6nGzM+QJem3kvyCxIEavH4+hmIgtrpI+exb36Z?=
 =?us-ascii?Q?xNFRFlB7LqL3aD8RocQ+VRXPP1pRdqbYmtYv9t/E9TjAQGhYVzcAv7QTn15v?=
 =?us-ascii?Q?e/2zjXcybH6h++MrHmHw5GK05P+WTGq/qZ2RXG/bKclX2OcGq+pjFjasQAWd?=
 =?us-ascii?Q?etUQfpA/MjYMkD5y7nEVs6FafuCKBb4Jb544Q4YgREsdgiuzdEbX7LHXDmAa?=
 =?us-ascii?Q?YHirdB9Ie/p6fD1/TB7LDqAfun+U+pHqTu3aFqzAKRlPRFJqtt2qkAQyT25p?=
 =?us-ascii?Q?mA5Wpvr4UN+D1ANTl7Ah4VfBb8Hn54YeMj8aKbt5JjPqn6HqyBsCbiM/Tklb?=
 =?us-ascii?Q?RUFqTAfV+A/BemgHS8KmYkfXmbhogSuu8bzslNNd5zch0wFQxijQSCPLFDUB?=
 =?us-ascii?Q?ssp/J+OK/ogD9sOx/IxM4Ku+lc/e2JB8OW6wDBEAObaMq6e8yIjvgG10dQmX?=
 =?us-ascii?Q?b23zr0HT6lh3oLS0MEobl6CwGpjLRAmFDi5v2Kte5e1Zvud1693HbDZ03DWh?=
 =?us-ascii?Q?cKsYhShHdljnEtyWXrXOi5cqNFb3aiOWQJjU9i4ygWQ7G892+RztSonSm9r6?=
 =?us-ascii?Q?ebzDNP96Yf+EjHzE7Po0+AnDD7SY212vlCv9GEIIGAZcjO340Lg8GMoRyjVZ?=
 =?us-ascii?Q?JtGdQuVSq4On3jf6x0CRkzqi0V3tKmSLWppQfYUAVjB/OrVdC63XoMxq/whS?=
 =?us-ascii?Q?Z1zaXZ8wsAer59cj4eecHQVNmHOUwF/UkgO4f+8IATpmgsV+fIGngvQPahXS?=
 =?us-ascii?Q?BCgZzbISJyWJyKdodptIMrRFKrHKi/QyDElMALScCR1RY1Pl8e94yKU/nwA3?=
 =?us-ascii?Q?KA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <C32EEADE86C3BB4E857B2C812E0042F2@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0:
	SRvnQ1EN4VXHY1i9Gj/Lwh14rv5+RLxY+Pbo19X1j6UlZ9J/meGrZENcTAVdGfwd13UgEEYjA4zZ2nF4V9+iY20tbFqrrccXa6TTf2yoTHcbxTtUvdbzSPjvUp3gj28wlKbq0UNKQyNy86OSKGoRoSF9dWdBNhkKlzVmPL0hNHe7LU4uXoEurr94xDvPqn2AxZlfPfKhri7TDyNVo9FzvSQux2/AZo2zXlyC8dnVrGavuaBt7JnlYI52g/BgyjCIu0c0K67lrMPQdTr8zJByTa9qsEWSkaxsa6M3Nh5UALwCV82Fpopm0jhHTAhVfSbWHhQYUOpR+vNwanKvRNizAEmQmQn6pUasq74nPlq3rWoWKHvaO1jQmU6kPw4wgReSMYQlm4mtYi0rDX2PqvC288cfITjrCWRb7iT6i3ILUxFmN+35dWV9WxhsJjUzWb7ygx3Z1SyxQJTFG7YR8PZv70llBWJhhsw2OAQ9rZ5ZpSUnIrfbUh5a0L9ynB5hNIqzKFgAU4ImxnLbmhXTkA1mI08u6GP7LL6SzvQ/e12Uc76TuqQIZFAjOVKojPrXnvrK6P/bZUMqm33K7IL6iaE9HSwUvMuPMprEr8y1ehaK54SoSX1b6+OPSj0koUoLrL0L
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR04MB7776.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 79a54c99-54f0-42a3-1b73-08dc7bcc2a42
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2024 08:33:19.1676
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: JsSCiBXIotrn3YQnvHt20IyyoDBVWe3iCsVK72sJViF7tMMD0dzmQ4kOioln29Rneinse8ECagIGB6Oyz7JJdg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB6655

On Thu, May 23, 2024 at 05:21:59PM GMT, Johannes Thumshirn wrote:
> From: Johannes Thumshirn <johannes.thumshirn@wdc.com>
>=20
> After we've committed a relocation transaction, we know we have just free=
d
> up space. Set it as hint for the next relocation.
>=20
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>

Reviewed-by: Naohiro Aota <naohiro.aota@wdc.com>

Regards,

> ---
>  fs/btrfs/relocation.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>=20
> diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c
> index 5f1a909a1d91..02a9ebf96a95 100644
> --- a/fs/btrfs/relocation.c
> +++ b/fs/btrfs/relocation.c
> @@ -3811,6 +3811,13 @@ static noinline_for_stack int relocate_block_group=
(struct reloc_control *rc)
>  	ret =3D btrfs_commit_transaction(trans);
>  	if (ret && !err)
>  		err =3D ret;
> +
> +	/*
> +	 * We know we have just freed space, set it as hint for the
> +	 * next relocation.
> +	 */
> +	if (!err)
> +		btrfs_reserve_relocation_bg(fs_info);
>  out_free:
>  	ret =3D clean_dirty_subvols(rc);
>  	if (ret < 0 && !err)
>=20
> --=20
> 2.43.0
> =