Received-SPF: pass (google.com: domain of linux-kernel+bounces-188476-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <768a8ca8-2ca5-1c41-16c2-b0b0421ce645@linux.intel.com>
Date: Fri, 24 May 2024 11:45:02 +0300
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.13.0
Content-Language: en-US
To: Hector Martin <marcan@marcan.st>, Mathias Nyman
 <mathias.nyman@intel.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240524-xhci-deadcode-v1-1-a4453a756e0f@marcan.st>
From: Mathias Nyman <mathias.nyman@linux.intel.com>
Subject: Re: [PATCH] xhci: Remove dead code in xhci_move_dequeue_past_td()
In-Reply-To: <20240524-xhci-deadcode-v1-1-a4453a756e0f@marcan.st>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 24.5.2024 10.07, Hector Martin wrote:
> This codepath is trivially dead, since the function is never called with
> a non-NULL td (the only callsite is immediately preceded by a NULL guard).
> 

Yes, thanks, adding to queue.
Comment below tells this was destined to be removed earlier.

> -	 * We shouldn't hit this anymore as cached cancelled TRBs are given back
> -	 * after clearing the cache, but be on the safe side and keep it anyway
> -	 */
> -	if (!td) {
..

Thanks
Mathias