Received-SPF: pass (google.com: domain of linux-kernel+bounces-188552-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Suman Ghosh <sumang@marvell.com>
To: Horatiu Vultur <horatiu.vultur@microchip.com>,
        "andrew@lunn.ch"
	<andrew@lunn.ch>,
        "hkallweit1@gmail.com" <hkallweit1@gmail.com>,
        "linux@armlinux.org.uk" <linux@armlinux.org.uk>,
        "davem@davemloft.net"
	<davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>
CC: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXTERNAL] [PATCH net v2] net: micrel: Fix lan8841_config_intr
 after getting out of sleep mode
Thread-Topic: [EXTERNAL] [PATCH net v2] net: micrel: Fix lan8841_config_intr
 after getting out of sleep mode
Thread-Index: AQHarbhQeUVWEJNGskeeatAPV6IdgrGmHecw
Date: Fri, 24 May 2024 09:28:44 +0000
Message-ID: 
 <SJ0PR18MB5216EFA6E40EF5FAC4C096A0DBF52@SJ0PR18MB5216.namprd18.prod.outlook.com>
References: <20240524085350.359812-1-horatiu.vultur@microchip.com>
In-Reply-To: <20240524085350.359812-1-horatiu.vultur@microchip.com>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?YrttkIiDSTMVDH/4zWdRugVYzcHMImZk3OKSWtjzC4XAHPHqoINQS5DMLQU7?=
 =?us-ascii?Q?bVaR5/0IrdR+HpvdCRJ/aA53uZYYUp4CqvZ4RYff6ZM7sT3g+Jr24OsPk597?=
 =?us-ascii?Q?uSH2OyEYNbcyMtEFdRvbXJLHmRsU0nQXTDUBj+SQ+rvO7EZys62RJtI1XARK?=
 =?us-ascii?Q?1PQWnkRYZ/IwObb5JE6B7Gvacj8le3fZ5NarKtIrJv09PbCZWvYGKenVYqHi?=
 =?us-ascii?Q?PZ3OqnBoM7sZlsOGsoP5WV9xaxitKJnEpLvdI3ViZQ1oUZ/lOpiG9UFEwmx/?=
 =?us-ascii?Q?vcmUTTHR/oTX4+t++e3i/FhnRn38GjMImjZe6NX9wy+2P5ijNRJYjslK8Dvd?=
 =?us-ascii?Q?6SL+ZMMvsFDire7fAa0yajotXb83NA1JX9BCV4N0UuSdDokKrS3SorLrOPeX?=
 =?us-ascii?Q?qwNdDljPyI4dFK9sSiu5N8MTXOAgnjRvLyGJkLbC1O0o8C0c8ZZvbPqTsB++?=
 =?us-ascii?Q?KdKNVx3bHBT9X30lELW3t0AVoAKysLxlOTG5W0JfI/mpui/RUwSwDVqjy1AL?=
 =?us-ascii?Q?tvL5KuwepgqzYE03tFjarzohxXWyZAHDDLVeEKyqLfrfmxLWXzKG0TnPLmGv?=
 =?us-ascii?Q?f+syfEHd9Khvebzt9ZyT3cx0wS9RTd645wSFjjpFtlgrc+nQqS0hFMNC+Aza?=
 =?us-ascii?Q?aMVqJ4ygDKcCDAJ1aqX65Oui8N+uGXaRmaIC8hZDuuqoIgfbbu175JJBWpKm?=
 =?us-ascii?Q?20N1rXwIqVGezNc+BOg5vndzqFopCEspLy9raIea4w8J1US8MC2yt55c731J?=
 =?us-ascii?Q?5KA2meBP+/nzcPGaAtzepxkp5uwuSi2L8F1bbHV/b2A9iYnr/3IHeEUm6c0g?=
 =?us-ascii?Q?yQPWsAbNoZp8Cf06fedeHDCjb22doahnN+3ceTEBMACDJCkXfOjuCY3m7uw4?=
 =?us-ascii?Q?afASDZMpa8N4s2IC6HRYMnBnnxd5USy0yoaDKd0KfkuDJLeg1ny6jKd/xthv?=
 =?us-ascii?Q?NGC1I2xI+Sqm0ES3vULVpOf3euRTsIA8zcMfLEdRIQBQPs9WL1sZh0yrR/T4?=
 =?us-ascii?Q?eJKVHpxs2TSKuD2GBd0+vgptnmxBOcdIYkagGxNuHm2OmKzlxjYkKSJ5w06h?=
 =?us-ascii?Q?hNfwHV/o07aaXL60ak2affe6wSXYDUYYSseSol+q6yD2unMYw1dbCjytTWcX?=
 =?us-ascii?Q?2YcJhNTCapQPSLB2BWqIRsiM42VEHuHL0fnjBy+bz8iOydyFlQCN5K7+4h3m?=
 =?us-ascii?Q?6avDaxcUp3Ha6VPMMAo5E3ppANOiYHWD7ISm00N2XljaswcGBWq3ExtUBah8?=
 =?us-ascii?Q?cf30UATo8USmSy/WRXAiFMMlSmQk584l0LoNucOdeJAfDDusMV8cGXphP4BC?=
 =?us-ascii?Q?qZR685Qrg+G80VpIa2IawBzfsxEi6g7xFp91eEJ9ntdZTbiIrJX5PTfagEfU?=
 =?us-ascii?Q?WHwc270TLz438EQHHANqxg7d5rO9JU+1qPcfjr30yY+J7a3qCggbA4xLYuKj?=
 =?us-ascii?Q?b9XcVl7djUACJ7N80m4zxgyoo922An0b53Az6BqdOBCnsyN2rJDVFOI4il12?=
 =?us-ascii?Q?aRP8PqYC3TTWH3szmJ9gKRDzQrt9kYi2oYqZ4CHZ+qOLZTDY4+evZZ+qZJhR?=
 =?us-ascii?Q?qXQUxnQDumATv85nAJ0=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR18MB5216.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e4c53dd0-8d05-4c11-b88b-08dc7bd3e893
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2024 09:28:44.9864
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: RlmpOqtEw4TZ5SLpqmpUGZ5PPlsFsP6cHHJbVFEzzw7haTbYdOP83CJ4iSjyUMlRIUly0+ZPD+P/WYnJWNwt9Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH4PR18MB6360
X-Proofpoint-ORIG-GUID: bpr7T7MyoRC69_4E-8Xl20XKVrABZU3U
X-Proofpoint-GUID: bpr7T7MyoRC69_4E-8Xl20XKVrABZU3U
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16
 definitions=2024-05-24_02,2024-05-23_01,2024-05-17_01

>diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index
>13e30ea7eec5d..c0773d74d5104 100644
>--- a/drivers/net/phy/micrel.c
>+++ b/drivers/net/phy/micrel.c
>@@ -4029,7 +4029,7 @@ static int lan8841_config_intr(struct phy_device
>*phydev)
>
> 	if (phydev->interrupts =3D=3D PHY_INTERRUPT_ENABLED) {
> 		err =3D phy_read(phydev, LAN8814_INTS);
>-		if (err)
>+		if (err < 0)
> 			return err;
>
> 		/* Enable / disable interrupts. It is OK to enable PTP
>interrupt @@ -4045,6 +4045,14 @@ static int lan8841_config_intr(struct
>phy_device *phydev)
> 			return err;
>
> 		err =3D phy_read(phydev, LAN8814_INTS);
>+		if (err < 0)
>+			return err;
>+
>+		/* Getting a positive value doesn't mean that is an error, it
>+		 * just indicates what was the status. Therefore make sure to
>+		 * clear the value and say that there is no error.
>+		 */
>+		err =3D 0;
[Suman] Looks good to me.
Reviewed-by: Suman Ghosh <sumang@marvell.com>

> 	}
>
> 	return err;
>--
>2.34.1