Received-SPF: pass (google.com: domain of linux-kernel+bounces-188553-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240524082236.24112-1-quic_kbajaj@quicinc.com>
In-Reply-To: <20240524082236.24112-1-quic_kbajaj@quicinc.com>
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Date: Fri, 24 May 2024 12:29:16 +0300
Message-ID: <CAA8EJpp9U-ucMAiNmVvWDuupd=OR_fLK9fQ+n21SVmktWMxhmA@mail.gmail.com>
Subject: Re: [PATCH v2] arm64: dts: qcom: qdu/qru1000-idp: Fix the voltage setting
To: Komal Bajaj <quic_kbajaj@quicinc.com>
Cc: Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, 
	Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org>, 
	Melody Olvera <quic_molvera@quicinc.com>, linux-arm-msm@vger.kernel.org, 
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"

On Fri, 24 May 2024 at 11:23, Komal Bajaj <quic_kbajaj@quicinc.com> wrote:
>
> While adding the USB support, it was found that the configuration
> for regulator smps5 was incorrectly set. Upon cross verifying for
> all the regulators, found that smps4, smps6 and smps8 are also
> incorrectly configured. This patch fixes the same.

Nit: see Documentation/process/submitting-patches.rst, "This patch..."

> In particular -
> - smps4 is 1.574V min and 2.04V max
> - smps5 is 1.2V min and 1.4V max
> - smps6 is 0.382V min and 1.12V max

Just for my understanding, will anything further constraint these values?

> - smps8 is fixed at 0.752V
>
> Fixes: d1f2cfe2f669 ("arm64: dts: qcom: Add base QDU1000/QRU1000 IDP DTs")
> Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com>
> ---
> Changes in v2-
> * Updated the commit message as suggested by Krzysztof
> * Link to v1: https://lore.kernel.org/linux-arm-msm/20240514131038.28036-1-quic_kbajaj@quicinc.com/
> ---
>
>  arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 16 ++++++++--------
>  arch/arm64/boot/dts/qcom/qru1000-idp.dts | 16 ++++++++--------
>  2 files changed, 16 insertions(+), 16 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
> index 6e129dc123ed..89b84fb0f70a 100644
> --- a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
> @@ -96,20 +96,20 @@ vreg_s3a_1p05: smps3 {
>
>                 vreg_s4a_1p8: smps4 {
>                         regulator-name = "vreg_s4a_1p8";
> -                       regulator-min-microvolt = <1800000>;
> -                       regulator-max-microvolt = <1800000>;
> +                       regulator-min-microvolt = <1574000>;
> +                       regulator-max-microvolt = <2040000>;
>                 };
>
>                 vreg_s5a_2p0: smps5 {
>                         regulator-name = "vreg_s5a_2p0";
> -                       regulator-min-microvolt = <1904000>;
> -                       regulator-max-microvolt = <2000000>;
> +                       regulator-min-microvolt = <1200000>;
> +                       regulator-max-microvolt = <1400000>;
>                 };
>
>                 vreg_s6a_0p9: smps6 {
>                         regulator-name = "vreg_s6a_0p9";
> -                       regulator-min-microvolt = <920000>;
> -                       regulator-max-microvolt = <1128000>;
> +                       regulator-min-microvolt = <382000>;
> +                       regulator-max-microvolt = <1120000>;
>                 };
>
>                 vreg_s7a_1p2: smps7 {
> @@ -120,8 +120,8 @@ vreg_s7a_1p2: smps7 {
>
>                 vreg_s8a_1p3: smps8 {
>                         regulator-name = "vreg_s8a_1p3";
> -                       regulator-min-microvolt = <1352000>;
> -                       regulator-max-microvolt = <1352000>;
> +                       regulator-min-microvolt = <752000>;
> +                       regulator-max-microvolt = <752000>;
>                 };
>
>                 vreg_l1a_0p91: ldo1 {
> diff --git a/arch/arm64/boot/dts/qcom/qru1000-idp.dts b/arch/arm64/boot/dts/qcom/qru1000-idp.dts
> index 2a862c83309e..258483af065b 100644
> --- a/arch/arm64/boot/dts/qcom/qru1000-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/qru1000-idp.dts
> @@ -96,20 +96,20 @@ vreg_s3a_1p05: smps3 {
>
>                 vreg_s4a_1p8: smps4 {
>                         regulator-name = "vreg_s4a_1p8";
> -                       regulator-min-microvolt = <1800000>;
> -                       regulator-max-microvolt = <1800000>;
> +                       regulator-min-microvolt = <1574000>;
> +                       regulator-max-microvolt = <2040000>;
>                 };
>
>                 vreg_s5a_2p0: smps5 {
>                         regulator-name = "vreg_s5a_2p0";
> -                       regulator-min-microvolt = <1904000>;
> -                       regulator-max-microvolt = <2000000>;
> +                       regulator-min-microvolt = <1200000>;
> +                       regulator-max-microvolt = <1400000>;
>                 };
>
>                 vreg_s6a_0p9: smps6 {
>                         regulator-name = "vreg_s6a_0p9";
> -                       regulator-min-microvolt = <920000>;
> -                       regulator-max-microvolt = <1128000>;
> +                       regulator-min-microvolt = <382000>;
> +                       regulator-max-microvolt = <1120000>;
>                 };
>
>                 vreg_s7a_1p2: smps7 {
> @@ -120,8 +120,8 @@ vreg_s7a_1p2: smps7 {
>
>                 vreg_s8a_1p3: smps8 {
>                         regulator-name = "vreg_s8a_1p3";
> -                       regulator-min-microvolt = <1352000>;
> -                       regulator-max-microvolt = <1352000>;
> +                       regulator-min-microvolt = <752000>;
> +                       regulator-max-microvolt = <752000>;
>                 };
>
>                 vreg_l1a_0p91: ldo1 {
> --
> 2.42.0
>
>


-- 
With best wishes
Dmitry