Received-SPF: pass (google.com: domain of linux-kernel+bounces-188562-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <88d22b96-2754-40ba-a8d2-dcf4880446d6@amd.com>
Date: Fri, 24 May 2024 11:35:38 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] i2c: xiic: improve error message when transfer fails
 to start
To: marc.ferland@gmail.com
Cc: andi.shyti@kernel.org, linux-arm-kernel@lists.infradead.org,
 linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
 Marc Ferland <marc.ferland@sonatest.com>
References: <20240513160324.3761564-1-marc.ferland@sonatest.com>
Content-Language: en-US
From: Michal Simek <michal.simek@amd.com>
Autocrypt: addr=michal.simek@amd.com; keydata=
 xsFNBFFuvDEBEAC9Amu3nk79+J+4xBOuM5XmDmljuukOc6mKB5bBYOa4SrWJZTjeGRf52VMc
 howHe8Y9nSbG92obZMqsdt+d/hmRu3fgwRYiiU97YJjUkCN5paHXyBb+3IdrLNGt8I7C9RMy
 svSoH4WcApYNqvB3rcMtJIna+HUhx8xOk+XCfyKJDnrSuKgx0Svj446qgM5fe7RyFOlGX/wF
 Ae63Hs0RkFo3I/+hLLJP6kwPnOEo3lkvzm3FMMy0D9VxT9e6Y3afe1UTQuhkg8PbABxhowzj
 SEnl0ICoqpBqqROV/w1fOlPrm4WSNlZJunYV4gTEustZf8j9FWncn3QzRhnQOSuzTPFbsbH5
 WVxwDvgHLRTmBuMw1sqvCc7CofjsD1XM9bP3HOBwCxKaTyOxbPJh3D4AdD1u+cF/lj9Fj255
 Es9aATHPvoDQmOzyyRNTQzupN8UtZ+/tB4mhgxWzorpbdItaSXWgdDPDtssJIC+d5+hskys8
 B3jbv86lyM+4jh2URpnL1gqOPwnaf1zm/7sqoN3r64cml94q68jfY4lNTwjA/SnaS1DE9XXa
 XQlkhHgjSLyRjjsMsz+2A4otRLrBbumEUtSMlPfhTi8xUsj9ZfPIUz3fji8vmxZG/Da6jx/c
 a0UQdFFCL4Ay/EMSoGbQouzhC69OQLWNH3rMQbBvrRbiMJbEZwARAQABzSlNaWNoYWwgU2lt
 ZWsgKEFNRCkgPG1pY2hhbC5zaW1la0BhbWQuY29tPsLBlAQTAQgAPgIbAwULCQgHAgYVCgkI
 CwIEFgIDAQIeAQIXgBYhBGc1DJv1zO6bU2Q1ajd8fyH+PR+RBQJkK9VOBQkWf4AXAAoJEDd8
 fyH+PR+ROzEP/1IFM7J4Y58SKuvdWDddIvc7JXcal5DpUtMdpuV+ZiHSOgBQRqvwH4CVBK7p
 ktDCWQAoWCg0KhdGyBjfyVVpm+Gw4DkZovcvMGUlvY5p5w8XxTE5Xx+cj/iDnj83+gy+0Oyz
 VFU9pew9rnT5YjSRFNOmL2dsorxoT1DWuasDUyitGy9iBegj7vtyAsvEObbGiFcKYSjvurkm
 MaJ/AwuJehZouKVfWPY/i4UNsDVbQP6iwO8jgPy3pwjt4ztZrl3qs1gV1F4Zrak1k6qoDP5h
 19Q5XBVtq4VSS4uLKjofVxrw0J+sHHeTNa3Qgk9nXJEvH2s2JpX82an7U6ccJSdNLYbogQAS
 BW60bxq6hWEY/afbT+tepEsXepa0y04NjFccFsbECQ4DA3cdA34sFGupUy5h5la/eEf3/8Kd
 BYcDd+aoxWliMVmL3DudM0Fuj9Hqt7JJAaA0Kt3pwJYwzecl/noK7kFhWiKcJULXEbi3Yf/Y
 pwCf691kBfrbbP9uDmgm4ZbWIT5WUptt3ziYOWx9SSvaZP5MExlXF4z+/KfZAeJBpZ95Gwm+
 FD8WKYjJChMtTfd1VjC4oyFLDUMTvYq77ABkPeKB/WmiAoqMbGx+xQWxW113wZikDy+6WoCS
 MPXfgMPWpkIUnvTIpF+m1Nyerqf71fiA1W8l0oFmtCF5oTMkzsFNBFFuvDEBEACXqiX5h4IA
 03fJOwh+82aQWeHVAEDpjDzK5hSSJZDE55KP8br1FZrgrjvQ9Ma7thSu1mbr+ydeIqoO1/iM
 fZA+DDPpvo6kscjep11bNhVa0JpHhwnMfHNTSHDMq9OXL9ZZpku/+OXtapISzIH336p4ZUUB
 5asad8Ux70g4gmI92eLWBzFFdlyR4g1Vis511Nn481lsDO9LZhKyWelbif7FKKv4p3FRPSbB
 vEgh71V3NDCPlJJoiHiYaS8IN3uasV/S1+cxVbwz2WcUEZCpeHcY2qsQAEqp4GM7PF2G6gtz
 IOBUMk7fjku1mzlx4zP7uj87LGJTOAxQUJ1HHlx3Li+xu2oF9Vv101/fsCmptAAUMo7KiJgP
 Lu8TsP1migoOoSbGUMR0jQpUcKF2L2jaNVS6updvNjbRmFojK2y6A/Bc6WAKhtdv8/e0/Zby
 iVA7/EN5phZ1GugMJxOLHJ1eqw7DQ5CHcSQ5bOx0Yjmhg4PT6pbW3mB1w+ClAnxhAbyMsfBn
 XxvvcjWIPnBVlB2Z0YH/gizMDdM0Sa/HIz+q7JR7XkGL4MYeAM15m6O7hkCJcoFV7LMzkNKk
 OiCZ3E0JYDsMXvmh3S4EVWAG+buA+9beElCmXDcXPI4PinMPqpwmLNcEhPVMQfvAYRqQp2fg
 1vTEyK58Ms+0a9L1k5MvvbFg9QARAQABwsF8BBgBCAAmAhsMFiEEZzUMm/XM7ptTZDVqN3x/
 If49H5EFAmQr1YsFCRZ/gFoACgkQN3x/If49H5H6BQ//TqDpfCh7Fa5v227mDISwU1VgOPFK
 eo/+4fF/KNtAtU/VYmBrwT/N6clBxjJYY1i60ekFfAEsCb+vAr1W9geYYpuA+lgR3/BOkHlJ
 eHf4Ez3D71GnqROIXsObFSFfZWGEgBtHBZ694hKwFmIVCg+lqeMV9nPQKlvfx2n+/lDkspGi
 epDwFUdfJLHOYxFZMQsFtKJX4fBiY85/U4X2xSp02DxQZj/N2lc9OFrKmFJHXJi9vQCkJdIj
 S6nuJlvWj/MZKud5QhlfZQsixT9wCeOa6Vgcd4vCzZuptx8gY9FDgb27RQxh/b1ZHalO1h3z
 kXyouA6Kf54Tv6ab7M/fhNqznnmSvWvQ4EWeh8gddpzHKk8ixw9INBWkGXzqSPOztlJbFiQ3
 YPi6o9Pw/IxdQJ9UZ8eCjvIMpXb4q9cZpRLT/BkD4ttpNxma1CUVljkF4DuGydxbQNvJFBK8
 ywyA0qgv+Mu+4r/Z2iQzoOgE1SymrNSDyC7u0RzmSnyqaQnZ3uj7OzRkq0fMmMbbrIvQYDS/
 y7RkYPOpmElF2pwWI/SXKOgMUgigedGCl1QRUio7iifBmXHkRrTgNT0PWQmeGsWTmfRit2+i
 l2dpB2lxha72cQ6MTEmL65HaoeANhtfO1se2R9dej57g+urO9V2v/UglZG1wsyaP/vOrgs+3
 3i3l5DA=
In-Reply-To: <20240513160324.3761564-1-marc.ferland@sonatest.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RERtRVJrbkhNcE00N0lLTllnZHF1SGlwOFhINGI4dmpkbGluMkl6aHFtNXVE?=
 =?utf-8?B?dVZ6Mmc4LzRQd2Q3cDhYOXp1SDFsTzJuS0d2d29kUG9ycGxJaGpIYW9sZFd0?=
 =?utf-8?B?L3dDRDZRaWxlaFJhY0lzL0d0OU50b3FVMzFVYllYU29GVHVxMXJKZHh2RXVk?=
 =?utf-8?B?SlR6ald5Ly85YVVRVnJkSFRvdDJ2UTZ1cVJiKzlvbG5HWDdQbEpkY2pJUDlv?=
 =?utf-8?B?czA3aWpWVHdwek9EQ2NVL2dUK01JQjlwRTRxQlIrY2F0UmR5OTlaMnNHbUZN?=
 =?utf-8?B?eVkwUEk0akE2V1JEejMrZWFma25XOHFyOEg0emVWcWNiSElIRDNDVS9aWnFn?=
 =?utf-8?B?NVNLUTBNSm04U0RZMUdNOE5LSHV0SXg4TDA3aFQ3SUdScnRpZStUOEt3RTJ3?=
 =?utf-8?B?SUFkcWQxUWpVWEx4SC9UT0pYQjhDSDdEdEFCemYxbGQrRDNaQXd2b1FTMGw0?=
 =?utf-8?B?aFVqTzF1V3pWZlhTVGYwYUN1TGxPT005L2dOM1NLSFFZZTZvMkFHRUxiL3A1?=
 =?utf-8?B?TFZ4Y1RJUEFCUnUzQXdDNTdMQnRlSXhOYW1rcFJuOFVENnplNkJyRkY0VTBk?=
 =?utf-8?B?QS9ncTJTbk9XdlVGYWdES3cyNGRvRlgyR2J2bmRMSVpjS25MSURiNEIydzVV?=
 =?utf-8?B?Y1RiRG1OTjExWU1CdEdnT1JMVVNCMXkrVFgvekJNeWtDay9MR0ZGRGc2UjJn?=
 =?utf-8?B?L082cnR4OStjKzcyalpzMytVZUFoWS9CTzJFNW4xN1hIdE9BeXl1cWNuZVZs?=
 =?utf-8?B?RUM0UVpleUl4MmlMWjRZckgwRFU0NHJ5cis4ajhpNzJGbVB5OXhCQ0EzUlpH?=
 =?utf-8?B?REtVRmZSZ0t0MEJEUVk1dGIzN21PVUFKbkViVjBYbWZVK3lQSGlnZWhRRTNh?=
 =?utf-8?B?dm0xWTQzbkN2dzdzR21nOTZIWjh0VjJzUU15N1YzS0JJbWhIYVg2Wm9ZM1ZU?=
 =?utf-8?B?MjM2dFBOanJjek4zRkNXSDZaNldXcU5adCs2RVA3elpKWnMrci9ZN0hkdHlC?=
 =?utf-8?B?Y0prczRKOXhCZGNneGtzSm9vSXZaUUJ3QjBKYi9sekNsYjNOV2M0ZmtENTNz?=
 =?utf-8?B?RjA0aEFxajlVUmlNT3lRbm9YQXVxUXpkWDZGWERQbzN4Z1FJMkZSTVg3QXh4?=
 =?utf-8?B?a201dmlPOE9tSG5XSHhvWmN3azdmVlZIeVZScmdSWFBNeFcvdVRJblpCU2R5?=
 =?utf-8?B?YkRsaE0yV3hKbVhuS001d2pCelNiekJ0aHFXNDVURWlaSjdzUXJkbHk2NlB0?=
 =?utf-8?B?c1FFY1hIQmFGY1d0SEpjZ1A4MndEclF1K0FROFhQUUxRTTZFM1hQb0dLbGdU?=
 =?utf-8?B?blA5MTBOQmlIa2lBVFVzRWJxZzY1azk0NDdwd3FTeDcxb2FGYlpUeGY2TGV3?=
 =?utf-8?B?VVROMUxXTU4ySytFdzJjTUg1czBlZnFSMTVVVDJ3d05yem9jV09PaEJ6QnRU?=
 =?utf-8?B?QkhpdmdlYkxkYmpveXRXbWM0VG5JdDd0RmZ2aUN6Qllnb3lldXZaUmFiZERC?=
 =?utf-8?B?UUhOVDJ3aEQ4SnlzbUJxWU9lRWh5ZHFFdC96QmF0ZW5SWEoxTlE2SG1maXYz?=
 =?utf-8?B?MFZCQ2FpWFMwV0I3c3ZrTFlxeTl0TkZjTmlhMGc2NGpKblVDZDRLL2pNd08v?=
 =?utf-8?B?RXpESCtjUlpUVG1KRzRBT0wyUzhDS1VBcmdCRlpmMU1qdnNPeEVpTno3ZWND?=
 =?utf-8?B?K25mTWNwUTVUM2wrellsNjhiMlUvZ0ZBZjJ4ZVBPOUIyQitwSmpqZFYvNjZT?=
 =?utf-8?B?clZtcUZUcDUvSjdOUVlyZkg4bEVYNkxUNVRsOEhzMEpDcVZpcnVGd2R0ZkQw?=
 =?utf-8?B?VWd2YVB6ek84RmlKTXhGbmxXQnBUWjlIMndkY0x5TUIrZElPTk52QkIyR096?=
 =?utf-8?B?VGs1S0d2MGEzTlBIOGNQa0pLa3o3dmpIVFcySXlnNUZGaUVIOTh0KzdxL0c0?=
 =?utf-8?B?Vks3SThEcFRGSTNBNzVsdUwxbUZ4WUZaNHdtUmdROVprZGVTVlVEWjVQeEJW?=
 =?utf-8?B?VHB0ckxsb0Z1ODN1Ris5WmYzT1ptTU5haEcyNEh1MDd4anppVWZGMzRwd3E2?=
 =?utf-8?B?MDdsMlRGSkpzU2R1L3p5V3BrTUczOFh2ekNHcDQzOEtPcytncW9Td0pMZ1VG?=
 =?utf-8?Q?46uustfVOckmcOZ0mHIiIosON?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a4b914e5-c4b3-4fe6-f26e-08dc7bd4e699
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8109.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2024 09:35:51.4340
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: G/jk3ipkoWbkt9Gm/uIHVBg2aEmWVV/ScwcdTSNsTDe480GEgjjV1UZjsDqlzXny
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7384


On 5/13/24 18:03, marc.ferland@gmail.com wrote:
> From: Marc Ferland <marc.ferland@sonatest.com>
> 
> xiic_start_xfer can fail for different reasons:
> 
> - EBUSY: bus is busy or i2c messages still in tx_msg or rx_msg
> - ETIMEDOUT: timed-out trying to clear the RX fifo
> - EINVAL: wrong clock settings
> 
> Both EINVAL and ETIMEDOUT will currently print a specific error
> message followed by a generic one, for example:
> 
>      Failed to clear rx fifo
>      Error xiic_start_xfer
> 
> however EBUSY will simply output the generic message:
> 
>      Error xiic_start_xfer
> 
> which is not really helpful.
> 
> This commit adds a new error message when a busy condition is detected
> and also removes the generic message since it does not provide any
> relevant information to the user.
> 
> Signed-off-by: Marc Ferland <marc.ferland@sonatest.com>
> ---
> Changes in v2:
>   - add a message where the error actually occurs (suggested by
>     Andi Shyti)
>   - remove the generic message completely (Andi Shyti)
> 
>   drivers/i2c/busses/i2c-xiic.c | 9 +++++----
>   1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
> index b9ad935d7ff3..afb242be456d 100644
> --- a/drivers/i2c/busses/i2c-xiic.c
> +++ b/drivers/i2c/busses/i2c-xiic.c
> @@ -1114,8 +1114,11 @@ static int xiic_start_xfer(struct xiic_i2c *i2c, struct i2c_msg *msgs, int num)
>   	mutex_lock(&i2c->lock);
>   
>   	ret = xiic_busy(i2c);
> -	if (ret)
> +	if (ret) {
> +		dev_err(i2c->adap.dev.parent,
> +			"cannot start a transfer while busy\n");
>   		goto out;
> +	}
>   
>   	i2c->tx_msg = msgs;
>   	i2c->rx_msg = NULL;
> @@ -1173,10 +1176,8 @@ static int xiic_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num)
>   		return err;
>   
>   	err = xiic_start_xfer(i2c, msgs, num);
> -	if (err < 0) {
> -		dev_err(adap->dev.parent, "Error xiic_start_xfer\n");
> +	if (err < 0)
>   		goto out;
> -	}
>   
>   	err = wait_for_completion_timeout(&i2c->completion, XIIC_XFER_TIMEOUT);
>   	mutex_lock(&i2c->lock);


Acked-by: Michal Simek <michal.simek@amd.com>

Thanks,
Michal