Received-SPF: pass (google.com: domain of linux-kernel+bounces-188626-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <31a428855b7094030ba506d8638d8d830f6e01d5.camel@gmail.com>
Subject: Re: [PATCH v4 02/10] drivers: iio: imu: Add support for ADIS16501
From: Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To: Ramona Gradinariu <ramona.bolboaca13@gmail.com>, 
	linux-kernel@vger.kernel.org, jic23@kernel.org, linux-iio@vger.kernel.org, 
	devicetree@vger.kernel.org, conor+dt@kernel.org, 
	krzysztof.kozlowski+dt@linaro.org, robh@kernel.org, nuno.sa@analog.com
Date: Fri, 24 May 2024 12:58:30 +0200
In-Reply-To: <20240524090030.336427-3-ramona.bolboaca13@gmail.com>
References: <20240524090030.336427-1-ramona.bolboaca13@gmail.com>
	 <20240524090030.336427-3-ramona.bolboaca13@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.1 (3.52.1-1.fc40) 
Precedence: bulk
MIME-Version: 1.0

On Fri, 2024-05-24 at 12:00 +0300, Ramona Gradinariu wrote:
> Add support for ADIS16501 device in already existing ADIS16475
> driver.
>=20
> Signed-off-by: Ramona Gradinariu <ramona.bolboaca13@gmail.com>
> ---

Reviewed-by: Nuno Sa <nuno.sa@analog.com>

> no changes in v4
> =C2=A0drivers/iio/imu/Kconfig=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 4 ++--
> =C2=A0drivers/iio/imu/adis16475.c | 23 +++++++++++++++++++++++
> =C2=A02 files changed, 25 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/iio/imu/Kconfig b/drivers/iio/imu/Kconfig
> index 52a155ff3250..782fb80e44c2 100644
> --- a/drivers/iio/imu/Kconfig
> +++ b/drivers/iio/imu/Kconfig
> @@ -36,8 +36,8 @@ config ADIS16475
> =C2=A0	select IIO_ADIS_LIB_BUFFER if IIO_BUFFER
> =C2=A0	help
> =C2=A0	=C2=A0 Say yes here to build support for Analog Devices ADIS16470,=
 ADIS16475,
> -	=C2=A0 ADIS16477, ADIS16465, ADIS16467, ADIS16500, ADIS16505, ADIS16507
> inertial
> -	=C2=A0 sensors.
> +	=C2=A0 ADIS16477, ADIS16465, ADIS16467, ADIS16500, ADIS16501, ADIS16505=
,
> +	=C2=A0 ADIS16507 inertial sensors.
>=20
> =C2=A0	=C2=A0 To compile this driver as a module, choose M here: the modu=
le will be
> =C2=A0	=C2=A0 called adis16475.
> diff --git a/drivers/iio/imu/adis16475.c b/drivers/iio/imu/adis16475.c
> index 01f55cc902fa..53872b716f4a 100644
> --- a/drivers/iio/imu/adis16475.c
> +++ b/drivers/iio/imu/adis16475.c
> @@ -661,6 +661,7 @@ enum adis16475_variant {
> =C2=A0	ADIS16467_2,
> =C2=A0	ADIS16467_3,
> =C2=A0	ADIS16500,
> +	ADIS16501,
> =C2=A0	ADIS16505_1,
> =C2=A0	ADIS16505_2,
> =C2=A0	ADIS16505_3,
> @@ -980,6 +981,25 @@ static const struct adis16475_chip_info adis16475_ch=
ip_info[]
> =3D {
> =C2=A0		.flags =3D ADIS16475_HAS_BURST32 | ADIS16475_HAS_BURST_DELTA_DATA=
,
> =C2=A0		.adis_data =3D ADIS16475_DATA(16500, &adis1650x_timeouts),
> =C2=A0	},
> +	[ADIS16501] =3D {
> +		.name =3D "adis16501",
> +		.num_channels =3D ARRAY_SIZE(adis16477_channels),
> +		.channels =3D adis16477_channels,
> +		.gyro_max_val =3D 1,
> +		.gyro_max_scale =3D IIO_RAD_TO_DEGREE(40 << 16),
> +		.accel_max_val =3D 1,
> +		.accel_max_scale =3D IIO_M_S_2_TO_G(800 << 16),
> +		.temp_scale =3D 100,
> +		.deltang_max_val =3D IIO_DEGREE_TO_RAD(720),
> +		.deltvel_max_val =3D 125,
> +		.int_clk =3D 2000,
> +		.max_dec =3D 1999,
> +		.sync =3D adis16475_sync_mode,
> +		/* pulse sync not supported */
> +		.num_sync =3D ARRAY_SIZE(adis16475_sync_mode) - 1,
> +		.flags =3D ADIS16475_HAS_BURST32 | ADIS16475_HAS_BURST_DELTA_DATA,
> +		.adis_data =3D ADIS16475_DATA(16501, &adis1650x_timeouts),
> +	},
> =C2=A0	[ADIS16505_1] =3D {
> =C2=A0		.name =3D "adis16505-1",
> =C2=A0		.num_channels =3D ARRAY_SIZE(adis16477_channels),
> @@ -1482,6 +1502,8 @@ static const struct of_device_id adis16475_of_match=
[] =3D {
> =C2=A0		.data =3D &adis16475_chip_info[ADIS16467_3] },
> =C2=A0	{ .compatible =3D "adi,adis16500",
> =C2=A0		.data =3D &adis16475_chip_info[ADIS16500] },
> +	{ .compatible =3D "adi,adis16501",
> +		.data =3D &adis16475_chip_info[ADIS16501] },
> =C2=A0	{ .compatible =3D "adi,adis16505-1",
> =C2=A0		.data =3D &adis16475_chip_info[ADIS16505_1] },
> =C2=A0	{ .compatible =3D "adi,adis16505-2",
> @@ -1513,6 +1535,7 @@ static const struct spi_device_id adis16475_ids[] =
=3D {
> =C2=A0	{ "adis16467-2", (kernel_ulong_t)&adis16475_chip_info[ADIS16467_2]=
 },
> =C2=A0	{ "adis16467-3", (kernel_ulong_t)&adis16475_chip_info[ADIS16467_3]=
 },
> =C2=A0	{ "adis16500", (kernel_ulong_t)&adis16475_chip_info[ADIS16500] },
> +	{ "adis16501", (kernel_ulong_t)&adis16475_chip_info[ADIS16501] },
> =C2=A0	{ "adis16505-1", (kernel_ulong_t)&adis16475_chip_info[ADIS16505_1]=
 },
> =C2=A0	{ "adis16505-2", (kernel_ulong_t)&adis16475_chip_info[ADIS16505_2]=
 },
> =C2=A0	{ "adis16505-3", (kernel_ulong_t)&adis16475_chip_info[ADIS16505_3]=
 },
> --
> 2.34.1
>=20