Received-SPF: pass (google.com: domain of linux-kernel+bounces-188627-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <87b282fe0e376c0af07b21feb13be1a98fb4e3eb.camel@gmail.com>
Subject: Re: [PATCH v4 04/10] iio: imu: adis_buffer: Add buffer setup API
 with buffer attributes
From: Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To: Ramona Gradinariu <ramona.bolboaca13@gmail.com>, 
	linux-kernel@vger.kernel.org, jic23@kernel.org, linux-iio@vger.kernel.org, 
	devicetree@vger.kernel.org, conor+dt@kernel.org, 
	krzysztof.kozlowski+dt@linaro.org, robh@kernel.org, nuno.sa@analog.com
Date: Fri, 24 May 2024 12:58:45 +0200
In-Reply-To: <20240524090030.336427-5-ramona.bolboaca13@gmail.com>
References: <20240524090030.336427-1-ramona.bolboaca13@gmail.com>
	 <20240524090030.336427-5-ramona.bolboaca13@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.1 (3.52.1-1.fc40) 
Precedence: bulk
MIME-Version: 1.0

On Fri, 2024-05-24 at 12:00 +0300, Ramona Gradinariu wrote:
> Add new API called devm_adis_setup_buffer_and_trigger_with_attrs() which
> also takes buffer attributes as a parameter.
> Rewrite devm_adis_setup_buffer_and_trigger() implementation such that it
> calls devm_adis_setup_buffer_and_trigger_with_attrs() with buffer
> attributes parameter NULL
>=20
> Signed-off-by: Ramona Gradinariu <ramona.bolboaca13@gmail.com>
> ---

Reviewed-by: Nuno Sa <nuno.sa@analog.com>

> no changes in v4
> =C2=A0drivers/iio/imu/adis_buffer.c | 32 ++++++++++++++++++--------------
> =C2=A0include/linux/iio/imu/adis.h=C2=A0 | 19 +++++++++++++++----
> =C2=A02 files changed, 33 insertions(+), 18 deletions(-)
>=20
> diff --git a/drivers/iio/imu/adis_buffer.c b/drivers/iio/imu/adis_buffer.=
c
> index 928933027ae3..871b78b225e2 100644
> --- a/drivers/iio/imu/adis_buffer.c
> +++ b/drivers/iio/imu/adis_buffer.c
> @@ -175,31 +175,36 @@ static void adis_buffer_cleanup(void *arg)
> =C2=A0}
>=20
> =C2=A0/**
> - * devm_adis_setup_buffer_and_trigger() - Sets up buffer and trigger for
> - *					=C2=A0 the managed adis device
> + * devm_adis_setup_buffer_and_trigger_with_attrs() - Sets up buffer and =
trigger
> + * for the managed adis device with buffer attributes.
> =C2=A0 * @adis: The adis device
> =C2=A0 * @indio_dev: The IIO device
> - * @trigger_handler: Optional trigger handler, may be NULL.
> + * @trigger_handler: Trigger handler: should handle the buffer readings.
> + * @ops: Optional buffer setup functions, may be NULL.
> + * @buffer_attrs: Extra buffer attributes.
> =C2=A0 *
> =C2=A0 * Returns 0 on success, a negative error code otherwise.
> =C2=A0 *
> - * This function sets up the buffer and trigger for a adis devices.=C2=
=A0 If
> - * 'trigger_handler' is NULL the default trigger handler will be used. T=
he
> - * default trigger handler will simply read the registers assigned to th=
e
> - * currently active channels.
> + * This function sets up the buffer (with buffer setup functions and ext=
ra
> + * buffer attributes) and trigger for a adis devices with buffer attribu=
tes.
> =C2=A0 */
> =C2=A0int
> -devm_adis_setup_buffer_and_trigger(struct adis *adis, struct iio_dev *in=
dio_dev,
> -				=C2=A0=C2=A0 irq_handler_t trigger_handler)
> +devm_adis_setup_buffer_and_trigger_with_attrs(struct adis *adis, struct =
iio_dev
> *indio_dev,
> +					=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 irq_handler_t trigger_handler,
> +					=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 const struct iio_buffer_setup_ops
> *ops,
> +					=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 const struct iio_dev_attr
> **buffer_attrs)
> =C2=A0{
> =C2=A0	int ret;
>=20
> =C2=A0	if (!trigger_handler)
> =C2=A0		trigger_handler =3D adis_trigger_handler;
>=20
> -	ret =3D devm_iio_triggered_buffer_setup(&adis->spi->dev, indio_dev,
> -					=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 &iio_pollfunc_store_time,
> -					=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 trigger_handler, NULL);
> +	ret =3D devm_iio_triggered_buffer_setup_ext(&adis->spi->dev, indio_dev,
> +						=C2=A0 &iio_pollfunc_store_time,
> +						=C2=A0 trigger_handler,
> +						=C2=A0 IIO_BUFFER_DIRECTION_IN,
> +						=C2=A0 ops,
> +						=C2=A0 buffer_attrs);
> =C2=A0	if (ret)
> =C2=A0		return ret;
>=20
> @@ -212,5 +217,4 @@ devm_adis_setup_buffer_and_trigger(struct adis *adis,=
 struct
> iio_dev *indio_dev,
> =C2=A0	return devm_add_action_or_reset(&adis->spi->dev, adis_buffer_clean=
up,
> =C2=A0					adis);
> =C2=A0}
> -EXPORT_SYMBOL_NS_GPL(devm_adis_setup_buffer_and_trigger, IIO_ADISLIB);
> -
> +EXPORT_SYMBOL_NS_GPL(devm_adis_setup_buffer_and_trigger_with_attrs, IIO_=
ADISLIB);
> diff --git a/include/linux/iio/imu/adis.h b/include/linux/iio/imu/adis.h
> index 8898966bc0f0..8dda3cfa5773 100644
> --- a/include/linux/iio/imu/adis.h
> +++ b/include/linux/iio/imu/adis.h
> @@ -21,6 +21,7 @@
> =C2=A0#define ADIS_REG_PAGE_ID 0x00
>=20
> =C2=A0struct adis;
> +struct iio_dev_attr;
>=20
> =C2=A0/**
> =C2=A0 * struct adis_timeouts - ADIS chip variant timeouts
> @@ -515,11 +516,19 @@ int adis_single_conversion(struct iio_dev *indio_de=
v,
> =C2=A0#define ADIS_ROT_CHAN(mod, addr, si, info_sep, info_all, bits) \
> =C2=A0	ADIS_MOD_CHAN(IIO_ROT, mod, addr, si, info_sep, info_all, bits)
>=20
> +#define devm_adis_setup_buffer_and_trigger(adis, indio_dev, trigger_hand=
ler)	\
> +	devm_adis_setup_buffer_and_trigger_with_attrs((adis), (indio_dev),	\
> +						=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (trigger_handler), NULL,	\
> +						=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 NULL)
> +
> =C2=A0#ifdef CONFIG_IIO_ADIS_LIB_BUFFER
>=20
> =C2=A0int
> -devm_adis_setup_buffer_and_trigger(struct adis *adis, struct iio_dev *in=
dio_dev,
> -				=C2=A0=C2=A0 irq_handler_t trigger_handler);
> +devm_adis_setup_buffer_and_trigger_with_attrs(struct adis *adis,
> +					=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct iio_dev *indio_dev,
> +					=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 irq_handler_t trigger_handler,
> +					=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 const struct iio_buffer_setup_ops
> *ops,
> +					=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 const struct iio_dev_attr
> **buffer_attrs);
>=20
> =C2=A0int devm_adis_probe_trigger(struct adis *adis, struct iio_dev *indi=
o_dev);
>=20
> @@ -529,8 +538,10 @@ int adis_update_scan_mode(struct iio_dev *indio_dev,
> =C2=A0#else /* CONFIG_IIO_BUFFER */
>=20
> =C2=A0static inline int
> -devm_adis_setup_buffer_and_trigger(struct adis *adis, struct iio_dev *in=
dio_dev,
> -				=C2=A0=C2=A0 irq_handler_t trigger_handler)
> +devm_adis_setup_buffer_and_trigger_with_attrs(struct adis *adis, struct =
iio_dev
> *indio_dev,
> +					=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 irq_handler_t trigger_handler,
> +					=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 const struct iio_buffer_setup_ops
> *ops,
> +					=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 const struct iio_dev_attr
> **buffer_attrs)
> =C2=A0{
> =C2=A0	return 0;
> =C2=A0}
> --
> 2.34.1
>=20