Received-SPF: pass (google.com: domain of linux-kernel+bounces-188628-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <20d139d06895f29ba69e4ab8ed362acd4c352279.camel@gmail.com>
Subject: Re: [PATCH v4 05/10] iio: imu: adis16475: Create push single sample
 API
From: Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To: Ramona Gradinariu <ramona.bolboaca13@gmail.com>, 
	linux-kernel@vger.kernel.org, jic23@kernel.org, linux-iio@vger.kernel.org, 
	devicetree@vger.kernel.org, conor+dt@kernel.org, 
	krzysztof.kozlowski+dt@linaro.org, robh@kernel.org, nuno.sa@analog.com
Date: Fri, 24 May 2024 12:58:59 +0200
In-Reply-To: <20240524090030.336427-6-ramona.bolboaca13@gmail.com>
References: <20240524090030.336427-1-ramona.bolboaca13@gmail.com>
	 <20240524090030.336427-6-ramona.bolboaca13@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.1 (3.52.1-1.fc40) 
Precedence: bulk
MIME-Version: 1.0

On Fri, 2024-05-24 at 12:00 +0300, Ramona Gradinariu wrote:
> Create push single sample API reposnsible for pushing a single
> sample into the buffer.
> This is a preparation patch for FIFO support where more than
> one sample has to be pushed in the trigger handler.
>=20
> Signed-off-by: Ramona Gradinariu <ramona.bolboaca13@gmail.com>
> ---

Reviewed-by: Nuno Sa <nuno.sa@analog.com>

> no changes in v4
> =C2=A0drivers/iio/imu/adis16475.c | 12 ++++++++++--
> =C2=A01 file changed, 10 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/iio/imu/adis16475.c b/drivers/iio/imu/adis16475.c
> index f9455ecb348c..ab955efdad92 100644
> --- a/drivers/iio/imu/adis16475.c
> +++ b/drivers/iio/imu/adis16475.c
> @@ -1249,9 +1249,8 @@ static void adis16475_burst32_check(struct adis1647=
5 *st)
> =C2=A0	}
> =C2=A0}
>=20
> -static irqreturn_t adis16475_trigger_handler(int irq, void *p)
> +static int adis16475_push_single_sample(struct iio_poll_func *pf)
> =C2=A0{
> -	struct iio_poll_func *pf =3D p;
> =C2=A0	struct iio_dev *indio_dev =3D pf->indio_dev;
> =C2=A0	struct adis16475 *st =3D iio_priv(indio_dev);
> =C2=A0	struct adis *adis =3D &st->adis;
> @@ -1340,6 +1339,15 @@ static irqreturn_t adis16475_trigger_handler(int i=
rq, void
> *p)
> =C2=A0	 * array.
> =C2=A0	 */
> =C2=A0	adis16475_burst32_check(st);
> +	return ret;
> +}
> +
> +static irqreturn_t adis16475_trigger_handler(int irq, void *p)
> +{
> +	struct iio_poll_func *pf =3D p;
> +	struct iio_dev *indio_dev =3D pf->indio_dev;
> +
> +	adis16475_push_single_sample(pf);
> =C2=A0	iio_trigger_notify_done(indio_dev->trig);
>=20
> =C2=A0	return IRQ_HANDLED;
> --
> 2.34.1
>=20