Received: by 2002:a89:d88:0:b0:1fa:5c73:8e2d with SMTP id eb8csp545444lqb; Fri, 24 May 2024 06:29:50 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVLwqgSBfQIumvq/nbUrFRu0o0ahSUtoWADsJFcdjuo+jY1mpSvLh4vnYHCtfai7c0A5zkODtKg9OftUmlFddx23GwGn4N/Pxd3zq24DQ== X-Google-Smtp-Source: AGHT+IEOHmsimonk6FRfPowS9YK2pBhjvFT+nlR48LvYF4CTKK8S6UMXp9jGwbsrxIwYIB3zfeV0 X-Received: by 2002:a05:6214:2f0c:b0:6a9:2c8c:1acb with SMTP id 6a1803df08f44-6abccfab4e8mr26345276d6.34.1716557390342; Fri, 24 May 2024 06:29:50 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716557390; cv=pass; d=google.com; s=arc-20160816; b=dJG4JWMOFstJUKgZmOw3PwjsI0QJod3uDRcLh/gK1MH3Rn5XVfXN5nbFCXL67mZp1B Nr31Jg4tu0RSkpoD+OCp4xs9IRpPnhRCFpbbWLAmoxF8FkiSr3Y5GD3Bu82KYCzrHXjF VLa8jfd9SZ8UdB3LsD1p0V+gl6E6K4YTzX5TVtGyhNlm6Bsu3WnSdPvoN7XZ+VVbV6IF SXzSclG4gRyWhJNZd35YEnGdnIV072HcCAo+qPLkHk0yFKDkMYZei8omgDDK3DYQ71A7 xUsgfVD1XeUXn7lMRgM8yfNyAbTit9ZPc6SSdqAuacaqPqT5ssdcTHAhkink1UfbePJR ttIQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id; bh=gnj5eiRVpeHUdOiTHPTB3uVCYhEgbsYJt2dKFAgOxwc=; fh=udcX5VP1Y1mjpV7UzQDLWPHRLMPD4AkuqKM+EJYKa2o=; b=jrT4xo5m3f90dbPRYF0buAq5PDX9qfaMqDKCbe+TIJ0/52TOnurWtI9CtPDAzeyEGx vDZTwhwpkKK/qsd1g+R71EqhHDYSRGnD7OXLDlAMJx9p7UgT3CRkWD2+jOYwB6sUqAUt Kigoer7X0gfQl1MWU5JHxfF0HKG/Lj3DBGMkokRaoRJoCBkiP09/GCGWjdXXjDXFnnrW O4fJI4xiGnpRmOyN+t8eC+c4+swubD9Bp6yZrjUkeyRWGVz2KVdQxe7Lx1XgqW6chXkp ohxIqbL+AedK2P7bSymGO6OmVfejRDmC6nY/kg+2icJVxUl8ZjcVLbUY66K/Du2chmTX +r5g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=i-love.sakura.ne.jp); spf=pass (google.com: domain of linux-kernel+bounces-188740-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-188740-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id 6a1803df08f44-6ac162da9ddsi16287566d6.582.2024.05.24.06.29.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 May 2024 06:29:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-188740-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=i-love.sakura.ne.jp); spf=pass (google.com: domain of linux-kernel+bounces-188740-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-188740-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 03D0E1C21C0C for ; Fri, 24 May 2024 13:29:50 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F2C0E12BF39; Fri, 24 May 2024 13:29:44 +0000 (UTC) Received: from www262.sakura.ne.jp (www262.sakura.ne.jp [202.181.97.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 884526EB4A for ; Fri, 24 May 2024 13:29:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.181.97.72 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716557384; cv=none; b=S8Qn/AOqXjCicXm3p0aW8OgxjUQBSF/Ulf8fDawMDYbfYmvDznkRzWLgsnO/0lkCs4Ni2yRJH6ecqNwVe1q+5fW1NGYFt61N8UuegmLrPfeVw174huiUYGPOf7NmFLSsSy/zBq5OFlQwceYrGNUYOrwam2UCvcuJjoOo6WT3rJM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716557384; c=relaxed/simple; bh=2JDf92Tog9KBmuidK5Ef5p9+4ys6GFSdcqyfl4DeWXU=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=f90waOIBkkXCcPJPjbl0Zqs2m7qYR6HbouvAmp/FMVrm/7C4Ygf9ysrmIQXZ1w1c/Ywx1Cl4AyeDMo5NhvJr2xRoeyzkVx3/5ic45AzEPzBsCQOcqOUqhOiMxs8QI25MEgh4W1MUdCmB4WX6+UBPlw2dUZeT0S0QapXc5J0VHJA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=I-love.SAKURA.ne.jp; spf=pass smtp.mailfrom=I-love.SAKURA.ne.jp; arc=none smtp.client-ip=202.181.97.72 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=I-love.SAKURA.ne.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=I-love.SAKURA.ne.jp Received: from fsav313.sakura.ne.jp (fsav313.sakura.ne.jp [153.120.85.144]) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTP id 44ODSJ4D038392; Fri, 24 May 2024 22:28:19 +0900 (JST) (envelope-from penguin-kernel@I-love.SAKURA.ne.jp) Received: from www262.sakura.ne.jp (202.181.97.72) by fsav313.sakura.ne.jp (F-Secure/fsigk_smtp/550/fsav313.sakura.ne.jp); Fri, 24 May 2024 22:28:19 +0900 (JST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/fsav313.sakura.ne.jp) Received: from [192.168.1.6] (M106072142033.v4.enabler.ne.jp [106.72.142.33]) (authenticated bits=0) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTPSA id 44ODSJD4038388 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NO); Fri, 24 May 2024 22:28:19 +0900 (JST) (envelope-from penguin-kernel@I-love.SAKURA.ne.jp) Message-ID: <19563aef-ed63-47b6-94c4-079db1bf8576@I-love.SAKURA.ne.jp> Date: Fri, 24 May 2024 22:28:20 +0900 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH (REPOST)] profiling: initialize prof_cpu_mask from profile_online_cpu() From: Tetsuo Handa To: Hugh Dickins , Ingo Molnar , akpm@linux-foundation.org Cc: tglx@linutronix.de, paskripkin@gmail.com, rostedt@goodmis.org, glider@google.com, ebiederm@xmission.com, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com, syzbot , Linus Torvalds References: <000000000000d6b55e060d6bc390@google.com> <7227c8d1-08f6-4f95-ad0f-d5c3e47d874d@I-love.SAKURA.ne.jp> <85edf211-aa30-4671-93e0-5173b3f7adf2@I-love.SAKURA.ne.jp> <239eadaf-d694-4dff-89b9-b476be35f4e9@I-love.SAKURA.ne.jp> <60011cc3-b9fc-49c8-b0c0-35aafe46f313@I-love.SAKURA.ne.jp> Content-Language: en-US In-Reply-To: <60011cc3-b9fc-49c8-b0c0-35aafe46f313@I-love.SAKURA.ne.jp> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2024/05/05 15:18, Tetsuo Handa wrote: > On 2024/04/27 15:51, Tetsuo Handa wrote: >> Can somebody test this patch? I don't know how not using >> cpu_possible_mask affects expected profile data collection >> (especially when written to /sys/kernel/profiling interface >> when some of CPUs are offline). > > I confirmed that writing to /sys/kernel/profiling while some of > /sys/devices/system/cpu/cpu$num/online are 0 will not affect profile data > collection, for profile_online_cpu() is called (and corresponding bit is set) > when /sys/devices/system/cpu/cpu$num/online becomes 1. Thus, I consider that > this patch itself is correct and safe. Who can take this patch?