Received: by 2002:a89:d88:0:b0:1fa:5c73:8e2d with SMTP id eb8csp564290lqb; Fri, 24 May 2024 06:58:18 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU1zjPqOg8l0bvBZ2dfceX7/f0svkz/zkZxxqCJIfyBbzwNROgt0n1b7yK52Ln9mNp7McesIvQ55qh67BA8QJRUj0U1W9HVJpSd1aX0lw== X-Google-Smtp-Source: AGHT+IF393g5X98BCAAFdOR0iJEYizlUAZfG6NrL1iUNqrPJ/qWWa6vq5pSf+H7oyDtjRlrgQtms X-Received: by 2002:a05:6808:19a6:b0:3c9:9379:e833 with SMTP id 5614622812f47-3d1a745de71mr3070343b6e.40.1716559097794; Fri, 24 May 2024 06:58:17 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716559097; cv=pass; d=google.com; s=arc-20160816; b=IY//yE2xMzwPW4Z29jLmzp04C1yLCLFVsMIQyw2RNdNOOPfiQLqRGZ3+GpXRXWsDR3 wOwvKEk0NmRY2F+ngtuMNxzwCRoZyW3MivLBpumy7Idg/N0p3hllTozCql32+8bWWiHj p2eM8TlBcxU4WhigVN3xEFLNxW1PphkNvjsmqoNbm+UfEa3Yv+5QRlWU1/2LOL9got4B EYa+sNbKjpCEpzRzw9abEvefiBDrbPdDfOi77gnRuYyFYeJ+SmiZ+SD8zNF2U5Xadxrx IYKqn2+4VMY/EcwImRcFYtCVMmuksq5BAWmaYj2e/znH40cmrUr9F7lMBejo9vYIKaTR TSeg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=YSAvrSBYQ1N+WHlYWnVL/esXHnHkzq/h8R3JKbIoeoA=; fh=WkAuL2TDzdPJUF5xHr6WH6RbmdAcjVdp8yG13cJbF6U=; b=msTCnOQppWa2oD4g3JLfNtFpIfNj1I0ucYGzsvO4nET6BDM6LWJGr2n8QIMwolPy3B 1Kx1M15SQl5bZ/8qab+LDYSF9RWMe1+KHgsnWTqTH9t3x/V7YcjjdOSIjSAyWnslBvuE mugKfKC+Rc/A2eyHL7qihSHCKaxELntHH4t+nsA22U6mjx+MErRWNUOj0EbgUS0nVkki xrfDB3G/IFibqBwLjV9OnLok48tJaG0YWMnUt8xwS5BiKZ9dO1zXa2z3vPVIeXtZ91GE xIU3AQwr9I5K2lVgQ9Lnmw5GgvKAi5J4Ia9d6IFDrWnfupgXWB2eruBi3k7cLhveulGE kphA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@acm.org header.s=mr01 header.b=e7V9Lm77; arc=pass (i=1 spf=pass spfdomain=acm.org dkim=pass dkdomain=acm.org dmarc=pass fromdomain=acm.org); spf=pass (google.com: domain of linux-kernel+bounces-188758-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-188758-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=acm.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id af79cd13be357-794abcabe52si157883885a.46.2024.05.24.06.58.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 May 2024 06:58:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-188758-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@acm.org header.s=mr01 header.b=e7V9Lm77; arc=pass (i=1 spf=pass spfdomain=acm.org dkim=pass dkdomain=acm.org dmarc=pass fromdomain=acm.org); spf=pass (google.com: domain of linux-kernel+bounces-188758-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-188758-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=acm.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 7C7481C21A7D for ; Fri, 24 May 2024 13:58:17 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 051B312C469; Fri, 24 May 2024 13:58:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b="e7V9Lm77" Received: from 008.lax.mailroute.net (008.lax.mailroute.net [199.89.1.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA29E1E52C; Fri, 24 May 2024 13:58:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=199.89.1.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716559090; cv=none; b=mrEx2YIgVrCQGV4R2pLN4L5ye2z+Ca8k3Y2C1dbCPAQnL0MvoYePlNYaCPZH1RnDG1PNfSdfeUnvQ5BXz1CMwZSK2JblBfADOLQlajlwfPApT98FPFFh7Q+1inaLMWdp7FSWp5Ug1/2pD6dW6JEG4PwSiwGdL865QVRuDVdPtuc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716559090; c=relaxed/simple; bh=My46v/q3vuGUyzhpBjk8iJOci71XYAlSL0dzslvRT94=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=XN4I8g+QCMfGv0ialZ8U0ecmnbb3D5e//q4pkTmbOPo2xvrdQWTkmI/95glH5VDXln/ZYmYn7vK3yP/JQxuPBYf6k6iWmJKoI4FdZ+z995XZYHguDDT7bKwsazqpO0k1+hi7aUXgpkbfxtQsw+dX3GoNw1C0vJNvwX2jPRYT/Vg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org; spf=pass smtp.mailfrom=acm.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b=e7V9Lm77; arc=none smtp.client-ip=199.89.1.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=acm.org Received: from localhost (localhost [127.0.0.1]) by 008.lax.mailroute.net (Postfix) with ESMTP id 4Vm67h2CkLz6Cnk98; Fri, 24 May 2024 13:58:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=acm.org; h= content-transfer-encoding:content-type:content-type:in-reply-to :from:from:content-language:references:subject:subject :user-agent:mime-version:date:date:message-id:received:received; s=mr01; t=1716559085; x=1719151086; bh=YSAvrSBYQ1N+WHlYWnVL/esX HnHkzq/h8R3JKbIoeoA=; b=e7V9Lm77kIZf29EMMJzHB/H3dvp5vL3WtxOauLqu PalH564fnUrroI7IyvU+lTJ55USND8R+tPxNtffRIhxXKhlpDMkGqiIShm6VRaP9 xp7QUpJMW5IjO47eUSo9gibNdKiDcmt30r+lxDSzw+4hvyLWldSypa7zn2Orgm8j /rDHoQ7gzXfNTFt7D6Xy/xBB8I8alp3f76m14RCF3V1++94RPGkatpr3Sx5Kjpi/ MY9n0LGK/k4MqZ/EjcKxbdBtQwxc5ofiVlHFsUGGa4MZYfiRB4kNlBIbkdPMpEJv gywL83Zx+F7kxU4FUrTYVtjc60v0p3EEgJy+YuQdzdEp8w== X-Virus-Scanned: by MailRoute Received: from 008.lax.mailroute.net ([127.0.0.1]) by localhost (008.lax [127.0.0.1]) (mroute_mailscanner, port 10029) with LMTP id L21v3LBY9ndt; Fri, 24 May 2024 13:58:05 +0000 (UTC) Received: from [192.168.50.14] (c-73-231-117-72.hsd1.ca.comcast.net [73.231.117.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bvanassche@acm.org) by 008.lax.mailroute.net (Postfix) with ESMTPSA id 4Vm67Z6ZL0z6Cnk94; Fri, 24 May 2024 13:58:02 +0000 (UTC) Message-ID: <396e5a4f-b9a1-4d82-bfc7-9264dd741a00@acm.org> Date: Fri, 24 May 2024 06:58:01 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] ufs:mcq:Fixing Error Output and cleanup for ufshcd_mcq_abort To: Chanwoo Lee , alim.akhtar@samsung.com, avri.altman@wdc.com, James.Bottomley@HansenPartnership.com, martin.petersen@oracle.com, quic_nguyenb@quicinc.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240524015904.1116005-1-cw9316.lee@samsung.com> Content-Language: en-US From: Bart Van Assche In-Reply-To: <20240524015904.1116005-1-cw9316.lee@samsung.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/23/24 18:59, Chanwoo Lee wrote: > An error unrelated to ufshcd_try_to_abort_task is being output and > can cause confusion. So, I modified it to output the result of abort > fail. > * dev_err(hba->dev, "%s: device abort failed %d\n", __func__, err); > > And for readability,I modified it to return immediately instead of 'goto'. Reviewed-by: Bart Van Assche