Received: by 2002:a89:d88:0:b0:1fa:5c73:8e2d with SMTP id eb8csp577650lqb; Fri, 24 May 2024 07:14:03 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVqId83XQvoFu0W/lZpDrNEgAAVxB6H33Fgq6hZNOv4kp53VHphJLcm+pj6DZwgX0Kfgst9FkGgStNVPpIzAhhz/LNCzz4kW7Ef0cseoQ== X-Google-Smtp-Source: AGHT+IE7Z9f0uJVmktrMsa2CHEI1dZtSTPVF8Fywn/e/YuqDK/rgXqocsSut3nVBQh/F6RF5qIId X-Received: by 2002:a17:902:c94b:b0:1f4:6093:671 with SMTP id d9443c01a7336-1f460930b9fmr2986305ad.28.1716560043399; Fri, 24 May 2024 07:14:03 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716560043; cv=pass; d=google.com; s=arc-20160816; b=Zqey756puo2MNtN1sMwB/zxUSoikZdh502HaS0NeiOp5Au/8OsBfbzbd5+2TYKBd9L 1r3FmO2MqvhuabUOYdNFf4HTg5BCYZSAGRu0LXyoSQO5LXjpiaZp0/JLQiQa5v4EWAC0 X0m1PdhPlrOJEjDTiqP43BwYzSqHVn8UwQDJ5Dy7+vk5byJspFMyHrM4uaP2xBEsTV1M Pa0CfvLs8yGR5ulpmYGrpnP4/DSF3MChEw9rhT/dqWQWDxaXec5KeOX9ZkLdWsmsabbU O51Y34R1Iw78r7zyzZtLtVMsqDlexgkK1NKdqfX2MI9WEOc09kZSSu5UxE7vZK5VtTrL o9zA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature:dkim-signature:dkim-signature :dkim-signature; bh=1ENZk+YNrymrvrrD0I2MRl9n2PBLEnhCmMDbUSSQHsE=; fh=RSlZFVUE5oQxdFUXl9O5HmvxWZQBsxJ0SO5NFMJE27Y=; b=VC7iKxllg9IDgEbLlJFhxkJdvyvvadtSdlZpNLCMtdL5Mn5FJaH5s8/GuLIdfRfemQ F9/otu/0CoQt2yO86T1plocG5KP8ZQ4tuzHjXx8GYmnH7nKraQGrPHoR3KERoGl9qPqH nN6YuLLVIC37ar6atCN7KaimlMCrVT4xB/okO6kqxMnoA0xKCofeQbvXHpCv1O2yvdUO jmboKiTu8282pQ2eSgaoYM+LJKu0BCVIt4RKNI9tiBp75uATMqOg6ERABWhHjSOHX0sW cq9iBBLwxyVxiXV+RkUiJZMiz+eZw2Vg9WpUsOdb4pLJ+kBhMoogaNccBcLJNtvJgcj8 YjSQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=hoCB6JU9; dkim=neutral (no key) header.i=@suse.cz; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=hoCB6JU9; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.cz dkim=pass dkdomain=suse.cz dkim=pass dkdomain=suse.cz); spf=pass (google.com: domain of linux-kernel+bounces-188776-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-188776-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id d9443c01a7336-1f44c9b8825si14727725ad.469.2024.05.24.07.14.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 May 2024 07:14:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-188776-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=hoCB6JU9; dkim=neutral (no key) header.i=@suse.cz; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=hoCB6JU9; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.cz dkim=pass dkdomain=suse.cz dkim=pass dkdomain=suse.cz); spf=pass (google.com: domain of linux-kernel+bounces-188776-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-188776-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 4BA20281560 for ; Fri, 24 May 2024 14:14:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F317512C47F; Fri, 24 May 2024 14:13:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="hoCB6JU9"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="Au2a7eBm"; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="hoCB6JU9"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="Au2a7eBm" Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B544585933; Fri, 24 May 2024 14:13:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716560037; cv=none; b=nVlSk+T/9nu4AERgFgvDJ+cyGwIq1P8SdBZGmomszVmkBe1vIAIjB/NdVpUGnGnhz4yI65TZfYxjedcsM9GlRZu37VJePLNiKIDNeElzoaU4QKxDTA2NxyelqCJxbwywvNDMC9Cj0PdPkXlJePdG6+Mu8flAD3BoqlW7o2hT2uI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716560037; c=relaxed/simple; bh=E5+8fyOw15iLM3lIB1Gmk2lZYVOBl+crVzUTt50b210=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WPk+WcDOV+YbP+GGYk/MA8hVO/u/gF1KXFeTR62mjdmlCp9Mp4NFhZXs9hsEXisQQqm7wH86l/z5QzIHrZWFs2rpMM7Gw7fvhYwEIOhnUmEhtlJR5DKwvlcWKtjO/SRFPNurdamtHFappbT50FhZzpZGzVfWY1jJOHjB77jqHg4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz; spf=pass smtp.mailfrom=suse.cz; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=hoCB6JU9; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=Au2a7eBm; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=hoCB6JU9; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=Au2a7eBm; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.cz Received: from localhost (unknown [10.100.12.32]) by smtp-out2.suse.de (Postfix) with ESMTP id ABBFA20A94; Fri, 24 May 2024 14:13:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1716560033; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1ENZk+YNrymrvrrD0I2MRl9n2PBLEnhCmMDbUSSQHsE=; b=hoCB6JU9XprYJdvuL8+l1iNbmT1ZYa1Rl5VRmYqZ0oS1KNS1EC1IJ8wJp1vSO/hvRptPz1 S8EAzBSwXldgUqjrxj2QsbMl+eH0jp4MpyO53psZ0R2dXFuWThK9150jb9vDZrOhzM900H y9pH3EfD64HQ1lTur4u3nsgb7GzEZmA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1716560033; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1ENZk+YNrymrvrrD0I2MRl9n2PBLEnhCmMDbUSSQHsE=; b=Au2a7eBmvLDVIBcZVVGbc+XGLHrRaIQIPCMaePnoTad5afSIwUqsgcrg/2VSin5J71GR9h PDXEX3hEV9NkHWBg== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1716560033; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1ENZk+YNrymrvrrD0I2MRl9n2PBLEnhCmMDbUSSQHsE=; b=hoCB6JU9XprYJdvuL8+l1iNbmT1ZYa1Rl5VRmYqZ0oS1KNS1EC1IJ8wJp1vSO/hvRptPz1 S8EAzBSwXldgUqjrxj2QsbMl+eH0jp4MpyO53psZ0R2dXFuWThK9150jb9vDZrOhzM900H y9pH3EfD64HQ1lTur4u3nsgb7GzEZmA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1716560033; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1ENZk+YNrymrvrrD0I2MRl9n2PBLEnhCmMDbUSSQHsE=; b=Au2a7eBmvLDVIBcZVVGbc+XGLHrRaIQIPCMaePnoTad5afSIwUqsgcrg/2VSin5J71GR9h PDXEX3hEV9NkHWBg== Date: Fri, 24 May 2024 16:13:53 +0200 From: Jiri Bohac To: Greg Kroah-Hartman Cc: cve@kernel.org, linux-kernel@vger.kernel.org, linux-cve-announce@vger.kernel.org, Eric Biederman , kexec@lists.infradead.org Subject: Re: CVE-2023-52823: kernel: kexec: copy user-array safely Message-ID: References: <2024052106-CVE-2023-52823-3d81@gregkh> <2024052420-clang-flatterer-366b@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Flag: NO X-Spam-Score: -4.30 X-Spam-Level: X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.992]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_ZERO(0.00)[0]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; MISSING_XM_UA(0.00)[]; MID_RHS_MATCH_FROMTLD(0.00)[]; FROM_HAS_DN(0.00)[]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCPT_COUNT_FIVE(0.00)[6] On Fri, May 24, 2024 at 02:38:04PM +0200, Jiri Bohac wrote: > On Fri, May 24, 2024 at 12:15:47PM +0200, Greg Kroah-Hartman wrote: > > Nice, but then why was this commit worded this way? Now we check twice? > > Double safe? Should it be reverted? > > double safe's good; turning it into a CVE not so much :( > CVE-2023-52822, CVE-2023-52824 and CVE-2023-52820, originally from the same patch > series, seem to be the exact same case. Same thing: CVE-2023-52758 -- Jiri Bohac SUSE Labs, Prague, Czechia