Received-SPF: pass (google.com: domain of linux-kernel+bounces-188786-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Fri, 24 May 2024 16:23:09 +0200
From: Michal =?utf-8?Q?Koutn=C3=BD?= <mkoutny@suse.com>
To: "T.J. Mercier" <tjmercier@google.com>
Cc: Tejun Heo <tj@kernel.org>, Zefan Li <lizefan.x@bytedance.com>, 
	Johannes Weiner <hannes@cmpxchg.org>, shakeel.butt@linux.dev, cgroups@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Subject: Re: [RFC] cgroup: Fix /proc/cgroups count for v2
Message-ID: <h5xdtfh7dc4rjh74b4cwkpjszro73hfbxzdobwtivyx4hl4hyn@p5lp5h5gzjuj>
References: <20240519174650.559538-1-tjmercier@google.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="u3go6jexu2jhya5a"
Content-Disposition: inline
In-Reply-To: <20240519174650.559538-1-tjmercier@google.com>


--u3go6jexu2jhya5a
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello.

On Sun, May 19, 2024 at 05:46:48PM GMT, "T.J. Mercier" <tjmercier@google.co=
m> wrote:
> The number of cgroups using a controller is an important metric since
> kernel memory is used for each cgroup, and some kernel operations scale
> with the number of cgroups for some controllers (memory, io). So users
> have an interest in minimizing/tracking the number of them.

I agree this is good for debugging or quick checks of unified hierarchy
enablement status.

> To deal with num_cgroups being reported as 1 for those utility
> controllers regardless of the number of cgroups that exist and support
> their use,

But '1' is correct number no? Those utility controllers are v1-only and
their single group only exists on (default) root.

> @@ -675,11 +699,19 @@ int proc_cgroupstats_show(struct seq_file *m, void =
*v)
>  	 * cgroup_mutex contention.
>  	 */
> =20
> -	for_each_subsys(ss, i)
> +	for_each_subsys(ss, i) {
> +		int count;
> +
> +		if (!cgroup_on_dfl(&ss->root->cgrp) || is_v2_utility_controller(i))
> +			count =3D atomic_read(&ss->root->nr_cgrps);

I think is_v2_utility_controller(ssid) implies
!cgroup_on_dfl(&ss->root->cgrp). I'd only decide based on the
cgroup_on_dfl() predicate.

> --- a/kernel/cgroup/cgroup.c
> +++ b/kernel/cgroup/cgroup.c
> @@ -2047,6 +2047,8 @@ void init_cgroup_root(struct cgroup_fs_context *ctx)
> =20
>  	INIT_LIST_HEAD_RCU(&root->root_list);
>  	atomic_set(&root->nr_cgrps, 1);
> +	for (int i =3D 0; i < CGROUP_SUBSYS_COUNT; ++i)
> +		atomic_set(&root->nr_css[i], 0);

Strictly not needed, non-dfl roots are kzalloc'd and dfl root is global
variable (zeroed).

HTH,
Michal

--u3go6jexu2jhya5a
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQQpEWyjXuwGT2dDBqAGvrMr/1gcjgUCZlCivgAKCRAGvrMr/1gc
jn5kAP0UpDlq3OnH0BApmPMsVi8dO/Baaa8axaOvCT6ompqJAQD/UtyesfG24KvI
alR0WPXjv2oqy9TCoF6Rt8wKARtd1AI=
=z8YD
-----END PGP SIGNATURE-----

--u3go6jexu2jhya5a--