Received: by 2002:a89:d88:0:b0:1fa:5c73:8e2d with SMTP id eb8csp612137lqb; Fri, 24 May 2024 08:06:42 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWFI9BIY0pDH+TpIc1R1zzGW+UTU7apSvXrdYwI3eyDaVsulO0/Hz3UGNHHrAbgfK2nb3t6KGSK7j+bKDy+lSQU1tyMc/QO8LUit4cwWA== X-Google-Smtp-Source: AGHT+IFTIAL4benmPqiKX7cEUv1Mwa3EvYdG7ERut1OhmkOxryTbDzhivF8zqJSDFbYbX+S7XzJr X-Received: by 2002:a17:902:e848:b0:1f2:fab9:a0a2 with SMTP id d9443c01a7336-1f448124e12mr38098555ad.1.1716563202274; Fri, 24 May 2024 08:06:42 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716563202; cv=pass; d=google.com; s=arc-20160816; b=zO/UvqmPuiPJbi7Hi953dAcad9pe0+mxJ5mCBEuIowLIxaIhc9c86XV7zIkGyIasGH oDmuEN54vV1K+tqx/lYB8XBbU6ju9dLrH5tiUc76vQFJNA+a75Tcu29/nubaV0VPcAQR jFn3o8ussvtVyKmaYveTjRA8zHmtHzMBULYftsYDu58Qc4YNFKWxzuYnAaceNqMtK94G SmYdTRZuehN2QJW9lxDOvp1JAje08hKnJhGQHx62/JM04NzijD/JVZxTBhL3Fncuav5W LVKIL9XCUA+4JXhhydw5fozYcUS6KPc3CELwohjQxEeZHnRY4eM2MYtokn8UdhAEGGzA HBVg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :date:message-id:dkim-signature; bh=I1BCpL/PStPCH7MJBW+moVlonxUq2Qtd0gJwH5QgdVc=; fh=VrOJwt+XLV6jpWyJbnk2Hw3s2P4mO37fMVo32SY3nlA=; b=P4WtE7qHbN8vPiPe/UAzMtivlhSs5NlQ1VXIGUo3x+oy1fttRkylvmlvAtgwtkDWr7 lma9y7ugePDjflCLGxLp99eXF6vLoxBBNV6U1nEdRfMGpkLIjMfuX/5X1IXJqbDabtf6 mAEMAF/RtTtj3qC138+JZxYul+JtWHBgJtUSKtGW5MBthNrLcKwXY1kmiDUKKD+RMCEC jZ9nY864zv/wcWZYufVY8RzlwqDLtIcyKFMRyxUH2NlQ8eT4lsOoa9mzUAw507uKVu4d nliBnjQAGzGmA5HVozzkLpqG1+0+Lr+uaaM/TMg2XC/T/ZXsJ8T2qV9Az1eZJbD1nvRA q9Kw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=IEqdJmya; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-188826-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-188826-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id d9443c01a7336-1f44c78a306si15143905ad.86.2024.05.24.08.06.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 May 2024 08:06:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-188826-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=IEqdJmya; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-188826-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-188826-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id DC771282993 for ; Fri, 24 May 2024 15:06:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1FF8B12D752; Fri, 24 May 2024 15:06:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IEqdJmya" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EDCE12D1E9 for ; Fri, 24 May 2024 15:06:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716563180; cv=none; b=Gv8+D/UoA5bQfkcoVuwxniXeryzJK2AMSHLFpCc6d0OnkglCfSF6W9s4rcdZv5CyLgw78Q9Y+yofT7mPxkb4bw9XUIRbGxg1y/s7fkCFGgtU0UYGBzYqsxmQolcveLVMMb/R1nrIV9I+l7bbRXZTJaKcwJxOXuQakokcXbPH+Js= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716563180; c=relaxed/simple; bh=7jEQdSU7Rg63/C2v0Z0arE+Uxrcq0NTUUdiTgoLsLdc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kQp0w3o8z81TdwO0ND0q5c6za3MViDLnLWv/im7+lIU7Lt3oqm0yEAjNZO3c0jfKgZ51ipV+WE5Pmbqagcm/cqhYxWdtEzrGKPVmDg+VhP0m0Ro2SpQINdj8pasmNszcR1nRWByzde6LAzJpj6FfyJBeBzUeVyWcCObdVrhO3f0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=IEqdJmya; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1716563176; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=I1BCpL/PStPCH7MJBW+moVlonxUq2Qtd0gJwH5QgdVc=; b=IEqdJmyaOSDj3zA2NM/5EO1lyBRpBG3Umxv+gYB+vn4w5GQWn6rxza81mttNUQcLI3OHQm lRpToNaSLNuOjeZOinUMRhojwKv+BMHBfDSXUpz7bZz3QfGCOj6mf7HgFC2WJQd55bgO1P 4fEZ45Ld2sDBQOAdBXBcSL0wJFSweTI= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-652-mirOepdNNNG7AAbKhI9gnA-1; Fri, 24 May 2024 11:06:14 -0400 X-MC-Unique: mirOepdNNNG7AAbKhI9gnA-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-41fda32e6c0so1814575e9.1 for ; Fri, 24 May 2024 08:06:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716563173; x=1717167973; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=I1BCpL/PStPCH7MJBW+moVlonxUq2Qtd0gJwH5QgdVc=; b=fR8IlNjXO8nAJhoDvqQhjE1P0dmgg/GgGCK88YKGPa8QFV8s8nCOAFiPX2DReU6xjT RZL5YKAUjAl+4URxyR0SkGhrb7BY0Ks03YfIuiswp+jwRhmvoUrp2YfIhQ30f08gsqJV iheUCD9RzIEAlBP/VCoeNWUMqFQTjA2hJB6ud65KkLvO9BFnFpTWFoO0oeVBXsj/Wl0U pclqf+qSWP9YgOEmNxGu3+7Fhlt05GsckbRQ/wPTdL1y8wkW7pe3qSZYEtl9s2Kw7H+v snniTkQfODK0WsGNIqnOwpmiFrZPfkXHFaQ7VraLqVE4k6Ds7mcfhfMfL/lmTMSQL3ZD f+tg== X-Forwarded-Encrypted: i=1; AJvYcCVSLc/yjlLDrVD4vtX1/pPmFEAa7+QrF/4Juyk7DRI9yk1lLzGLvkhFRSQEimQoRp3Mza3Jy6Eg7bcngX1HjhVEakLnf1BRs+dtZBxR X-Gm-Message-State: AOJu0YzXaxuxuwTW89KrOZYeVXghdSvV8ot+zbGec09iBw3fdPpwUEzk lS4iRK+EQmFJZv4WvFC6raoQtSQxiDlaOUkigFVukKAjXYfdf6eA9kSAi3hUB/l/J8UF5ZOYHZt iuNxyA8nvcXf2dxHt9nzvVz8dKVoyLSKZsA9pn7G5z8UtynI936lGNskn/BNl3Q== X-Received: by 2002:a05:600c:358b:b0:418:7ec1:7bdb with SMTP id 5b1f17b1804b1-421015ae128mr52793195e9.5.1716563173605; Fri, 24 May 2024 08:06:13 -0700 (PDT) X-Received: by 2002:a05:600c:358b:b0:418:7ec1:7bdb with SMTP id 5b1f17b1804b1-421015ae128mr52792805e9.5.1716563173120; Fri, 24 May 2024 08:06:13 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-421089cc4e2sm22879045e9.39.2024.05.24.08.06.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 May 2024 08:06:12 -0700 (PDT) Message-ID: <65447480-f46f-4256-a093-f8232fb6ed84@redhat.com> Date: Fri, 24 May 2024 17:06:11 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 04/13] mm/memory-failure: save a page_folio() call To: Miaohe Lin , akpm@linux-foundation.org, tony.luck@intel.com, bp@alien8.de Cc: nao.horiguchi@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org References: <20240524091310.1430048-1-linmiaohe@huawei.com> <20240524091310.1430048-5-linmiaohe@huawei.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240524091310.1430048-5-linmiaohe@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 24.05.24 11:13, Miaohe Lin wrote: > Use local variable folio directly to save a page_folio() call. > No functional change intended. > > Signed-off-by: Miaohe Lin > --- > mm/memory-failure.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index b571aaf987a2..73878ecdec22 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -1658,7 +1658,7 @@ static bool hwpoison_user_mappings(struct folio *folio, struct page *p, > unmap_success = !page_mapped(p); We should be using folio_mapped() here. > if (!unmap_success) > pr_err("%#lx: failed to unmap page (folio mapcount=%d)\n", > - pfn, folio_mapcount(page_folio(p))); > + pfn, folio_mapcount(folio)); Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb