Received: by 2002:a89:d88:0:b0:1fa:5c73:8e2d with SMTP id eb8csp626775lqb; Fri, 24 May 2024 08:27:51 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUtc+KgUsrJtRMUqgV7obhJ2tRestowczuPDLG4A663L8yXzHjwXUDcNhoT3TcXLzCqSZE1hAEDGsIU3xpkKi4ivBOliVr8HazmW5vQBw== X-Google-Smtp-Source: AGHT+IFwWW8nGTtnuRGEuhCwF0v7ZynwrG++DYwtFP2pOOWzbKBHqLj6gwwQWIY/qXSSpZWhaO+h X-Received: by 2002:a05:6870:2320:b0:23d:79c3:5629 with SMTP id 586e51a60fabf-24ca12f4b25mr2593726fac.28.1716564471607; Fri, 24 May 2024 08:27:51 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716564471; cv=pass; d=google.com; s=arc-20160816; b=M+ju8g9clRQdfceQciPVQ8nuaHxQtAz3jVZwKZAETy8kvtGCo+SbNZp1zIJ0su9Tpa A51LZ0LaQHbVT9Pl8OSaeGRBB0f+qy5B3zqUH5rvavcWYleiw0QvelwHluOZ0CJ2AXPu p721Qtkr2hn3vTqAi+JCWsqa0gzWn/WOfsbGp/7DxsN5bKAvnYrczmKnfWoM8CgfY+Uy etsNoL0AFV78oWXndS4R9O87CWAmnQniPijAEas+TEZq5PwmvkMRtG5p4OYS9HfE4Qc6 zsoAUsPKFrHw98zYbj/FCSc5us4hoANdFxp8iPLixPrgb3klgu1F3ZgFllaUEVrXjsjF +oHQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=S6q5Sh4Apeb4H1kqskbQd+WdCbpNzzrrs+aIEp4fenQ=; fh=6w1WhOOfoTPm3TAzZ0TEvTJY7PMhNgQ7GupS1KuGQxg=; b=G9sGOZIRETmI/xJmdTQI8SfbHOWNF2m0chsSqbh4S0WbhfDn3q4dsAijO6Oj7a1dXz UiqnGb+h41Be//F5wMZ+TLsOx9k55LxtNBr7irXdaSspVsLHrRYOBfBsvT63CbVSHq9p 0UYuFo6N54+hQK2KLEBHw7SH14V+tmUQh/ET1FD935sAjrc2UBpuePIVyZN96EvZpqAl 8oI9f0MauYiqYuiS6XLCrUgVdMA/sF8K1k+mH8AfVGkApUnFqxmwVJowKbKHoIO85u7w YxLAaziaJYo5+9n6DyUmVQud3ZJg7Vgy5mnMS0DOBkqhtdhKGmPfbxmkjC8hw+C5Vziv LuVA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ySVIarrI; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-188856-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-188856-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id d75a77b69052e-43fb17c0917si19533801cf.91.2024.05.24.08.27.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 May 2024 08:27:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-188856-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ySVIarrI; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-188856-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-188856-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 2C9C01C21988 for ; Fri, 24 May 2024 15:27:51 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D417712DDA7; Fri, 24 May 2024 15:27:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ySVIarrI" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07CD612DD98; Fri, 24 May 2024 15:27:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716564463; cv=none; b=Dq3Ae6XBp8pi2rplNd02cHarGK6qeec1fN0ZRVZ9xVz6xlwtpkOYBD+T1sJjObu1BHVBqw1BxAhdL/X5KdwJLVMeJwd5W2xm1lKF9u6hz0qJd/SXk0IADHuenf9TharA1JB3NlCK0YY1SLwMO6g3VmjopgpIo7I7PIx7h4esZU8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716564463; c=relaxed/simple; bh=EWjF42HyXFIgPE/ta6fPNwbxqec2D+5L3iGHiCR4VVE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UUIvRG/qSqlobwgvDioP4rE/qR8Pb0j0/jP6DhzlXwHzyGQkASa745b0DIc826zmWSwacOMozYHUf1AxVqDWKm/vbChn3Rk0gXk4M99HItUUMAp2oFHwHAZ4W8IaVIk2/5s50LfACkDr9wxgM++NBQGI5sHH9qBOlc7oF1XJ+Fg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ySVIarrI; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id E2D2FC2BBFC; Fri, 24 May 2024 15:27:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1716564462; bh=EWjF42HyXFIgPE/ta6fPNwbxqec2D+5L3iGHiCR4VVE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ySVIarrIR6ZWmjPpQVVQ9tWKvUgXSa6m1ze/sqoVetRaVplOtZC/3uK+7FFWyCtmu tHdk1KijyfvxBZx0nonTxR8+lddXEXVXPa1RjyMy66uQiXI+TThy/cnhT/ux+zW1YS XXBmXfuFAYjKCXx0bObb7N7LcHSo/fBkpyA7yWC8= Date: Fri, 24 May 2024 17:27:39 +0200 From: Greg Kroah-Hartman To: Jiri Bohac Cc: cve@kernel.org, linux-kernel@vger.kernel.org, linux-cve-announce@vger.kernel.org, Eric Biederman , kexec@lists.infradead.org Subject: Re: CVE-2023-52823: kernel: kexec: copy user-array safely Message-ID: <2024052431-decline-limes-da66@gregkh> References: <2024052106-CVE-2023-52823-3d81@gregkh> <2024052420-clang-flatterer-366b@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, May 24, 2024 at 04:13:53PM +0200, Jiri Bohac wrote: > On Fri, May 24, 2024 at 02:38:04PM +0200, Jiri Bohac wrote: > > On Fri, May 24, 2024 at 12:15:47PM +0200, Greg Kroah-Hartman wrote: > > > Nice, but then why was this commit worded this way? Now we check twice? > > > Double safe? Should it be reverted? > > > > double safe's good; turning it into a CVE not so much :( > > CVE-2023-52822, CVE-2023-52824 and CVE-2023-52820, originally from the same patch > > series, seem to be the exact same case. > > Same thing: CVE-2023-52758 Agreed, now rejected, thanks for the review! greg k-h