Received-SPF: pass (google.com: domain of linux-kernel+bounces-188899-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 24 May 2024 17:54:01 +0200
From: Andrew Lunn <andrew@lunn.ch>
To: Xiaolei Wang <xiaolei.wang@windriver.com>
Cc: wei.fang@nxp.com, shenwei.wang@nxp.com, xiaoning.wang@nxp.com,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, imx@lists.linux.dev, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [net v3 PATCH] net:fec: Add fec_enet_deinit()
Message-ID: <9eb45fe8-a0df-4b5d-88a3-ed61f9e320f1@lunn.ch>
References: <20240524050528.4115581-1-xiaolei.wang@windriver.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240524050528.4115581-1-xiaolei.wang@windriver.com>

On Fri, May 24, 2024 at 01:05:28PM +0800, Xiaolei Wang wrote:
> When fec_probe() fails or fec_drv_remove() needs to release the
> fec queue and remove a NAPI context, therefore add a function
> corresponding to fec_enet_init() and call fec_enet_deinit() which
> does the opposite to release memory and remove a NAPI context.
> 
> Fixes: 59d0f7465644 ("net: fec: init multi queue date structure")
> Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com>
> Reviewed-by: Wei Fang <wei.fang@nxp.com>
> ---
> v1 -> v2
>  - Add fec_enet_free_queue() in fec_drv_remove()
> v2 -> v3
>  - Add fec_enet_deinit()
> 
>  drivers/net/ethernet/freescale/fec_main.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
> index a72d8a2eb0b3..881ece735dcf 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -4130,6 +4130,14 @@ static int fec_enet_init(struct net_device *ndev)
>  	return ret;
>  }
>  
> +static void fec_enet_deinit(struct net_device *ndev)
> +{
> +	struct fec_enet_private *fep = netdev_priv(ndev);
> +
> +	netif_napi_del(&fep->napi);
> +	fec_enet_free_queue(ndev);
> +}

That is much better, and using the correct structure helped you find
other bug....

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew