Received-SPF: pass (google.com: domain of linux-kernel+bounces-188957-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Fri, 24 May 2024 16:58:22 +0000
From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: dmitry.torokhov@gmail.com, christophe.jaillet@wanadoo.fr
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: tca6416 remove unused struct 'tca6416_drv_data'
Message-ID: <ZlDHLrkv6oHl_EaF@gallifrey>
References: <20240523002910.492558-1-linux@treblig.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <20240523002910.492558-1-linux@treblig.org>
User-Agent: Mutt/2.2.12 (2023-09-09)

* linux@treblig.org (linux@treblig.org) wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'tca6416_drv_data' is unused since the original
> commit 30ba3ead0576 ("Input: add keypad driver for keys interfaced to
> TCA6416").
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

Oops, looks like Christophe got there first!

Dave

> ---
>  drivers/input/keyboard/tca6416-keypad.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/input/keyboard/tca6416-keypad.c b/drivers/input/keyboard/tca6416-keypad.c
> index 677bc4baa5d1..b2060229bd0f 100644
> --- a/drivers/input/keyboard/tca6416-keypad.c
> +++ b/drivers/input/keyboard/tca6416-keypad.c
> @@ -32,11 +32,6 @@ static const struct i2c_device_id tca6416_id[] = {
>  };
>  MODULE_DEVICE_TABLE(i2c, tca6416_id);
>  
> -struct tca6416_drv_data {
> -	struct input_dev *input;
> -	struct tca6416_button data[];
> -};
> -
>  struct tca6416_keypad_chip {
>  	uint16_t reg_output;
>  	uint16_t reg_direction;
> -- 
> 2.45.1
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/