Received-SPF: pass (google.com: domain of linux-kernel+bounces-188977-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Erick Archer <erick.archer@outlook.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Hans de Goede <hdegoede@redhat.com>,
	Kees Cook <keescook@chromium.org>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	Justin Stitt <justinstitt@google.com>
Cc: Erick Archer <erick.archer@outlook.com>,
	linux-input@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-hardening@vger.kernel.org
Subject: [PATCH] Input: keyboard - use sizeof(*pointer) instead of sizeof(type)
Date: Fri, 24 May 2024 19:33:08 +0200
Message-ID:
 <AS8PR02MB7237277464F23CA168BFB3B18BF52@AS8PR02MB7237.eurprd02.prod.outlook.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: AS8PR02MB7237:EE_|AS1PR02MB8092:EE_
X-MS-Office365-Filtering-Correlation-Id: da199884-9f06-4cf5-a4bf-08dc7c17a069
X-Microsoft-Antispam:
	BCL:0;ARA:14566002|461199019|440099019|3412199016|1710799017;
X-Microsoft-Antispam-Message-Info:
	TfczYUtds3mfrNQuLOhwKhpt+0m+cgWaY7LiZt9cMO6cwI5pzU6ILVklQIm9vweEBunT+3/N9OvPt8epckK6GFjNfoO7iTUyH1VwZoFMSOJlHpUjeNosZ4IoJlj6+TzleHppAN5IB7ryjlzMKYvtfIGQb9MsxCVjpiPklDANlnUY36BcJv+PH4JYGzXJYEr/ruMcrQvEeP0LfkOiK6a1oAIrfAteASiFM+CuQ6dlZMw+I8SQl6eQKCi3gsjTEIK99nCqSZnBRLmzQrp4dZF65s8IIm7p6vpgB80HNqJmwxgqxWn0p5ldXffMGBu/aoPdfONBl3UTFUncLGIg8oXUsAWJdhryG+ExO0cFWoDRu02ufoUt1nPYnvRDWTx5SByUHJomtP3u5YpUKwWYeTl9Mck+0GgjTz8qL25K07bMfiZMEq74Kwa8dC/yJ8uayAgzDMPNKTwX735RlquHj8IBM16lOcwp9pvBuoTqlfytjCqkBFuesm8ztE8zd4KRdADpNmwryit+/dk0BpPOzNH6Tkz4NSRE3ml4BF+9fr6Xu1b9h9XKXWD/qk+uA1svOo8UOc1E8E8RdZGb5F5ixNvxGXsMcs+dXnkAYr45Q41X0yZeXYOfuTxckprFc+i9zx6p
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?mGesQWM0aueoZJq1iYZVxNOCzrhdINLYHPa/snexDQw8/1VQYeBGLF1MZgTX?=
 =?us-ascii?Q?WNnVDgQ7R8BBpxt2lgdf+hRFrequ9r4QN+2dFPoELilSxvoA3Gv5sf5iJdQt?=
 =?us-ascii?Q?OeUKnq8KS9bGZle5h+KFNdCST2jD4dOfIm+qMc9+d2B7EuHMgLXdLPxre3qO?=
 =?us-ascii?Q?p+BactK0GfBm6YITy6f7xMqGvAp3oBak5t+AqfkLBcWKTfIy8bz+wwPsrK6G?=
 =?us-ascii?Q?KUUcPTxO7pBlGCHaCUJ5EcsN6Igcjyhy9x4rGS8yaWh+tT29BubpU4Ci9Kw2?=
 =?us-ascii?Q?7uGRT5402qqnNGdH17koiCFk5hB0CQmRml9EuLFsKykvMWefqEUJuPPW/Z59?=
 =?us-ascii?Q?FWfu3Xfjv0zdQjoh/LH7fHm7FawjD77kjzj3GvQyP960j85eviLRoJWUpYf/?=
 =?us-ascii?Q?Rootk7WHnToB8Tgibj7bNGrkDd7FswXh4IbJI6SGvmakJgkoO2cAb2EhNcdZ?=
 =?us-ascii?Q?YkPWp2VGEVmyor56aF7Nv8yaiVcyWu2YCFq7S4x0O8QHqsm2E7cV8x5Zn6au?=
 =?us-ascii?Q?J5LqRN3HyzEj4HTcqwewPL7sr2BpmvNn0SmPbpUMKDb+x7a70rLTOYRESNRN?=
 =?us-ascii?Q?3Uakv9PDiittiBawjBU8Cf2/rBLVnjGW1vSDzEvzTNdnaadGaaW4xA+NaPer?=
 =?us-ascii?Q?iujjx1kJwskweOaOfQNgwlzYn59iWPsE1Y47RD9e/0n9+Dyi5PABRRzp1WNC?=
 =?us-ascii?Q?IuEx4v2dQxDIw5/EdCMV7jqp8SqCvVOU6e+v8wGIeJ+5h0s4o/RkqLAKar4b?=
 =?us-ascii?Q?9pDFmaZ8eNzBAq9atL0/5rQOaqkCwApGyTDcIwLG+15wkngspFraBZBqb9Y7?=
 =?us-ascii?Q?vhIFF3/ggA2ti1ioufIgyZEAw625t5MSFNU3JUbLbyCP+JdVKgPxDln4K3E4?=
 =?us-ascii?Q?50skgdFlaxxnhTSpbfBzt7WDSiQq2ZvQGIG1TtCnBeMv7BlzRK6nhxwiOJv9?=
 =?us-ascii?Q?EOXbrZAPTTLxRf1Qj7LUZurwiWzh43P1Un1YP0rhqFILns4U8qnXMWkGdkH4?=
 =?us-ascii?Q?u50FWxx5a4c5kj7opS2YIzFo9pFtcQn9cxJcUHAvf+1T2YNIdvCiaxlDatc2?=
 =?us-ascii?Q?QoCAdo0BRPx55ooZ7qTKZaS+nehTnC3JlK43Ur5+gJ6kvWf3asgJ+jjEZBwR?=
 =?us-ascii?Q?TPhiDBoPrG0dfC/gvNO/coHsjdm7N6EYRH0OImPMb8r7tWLPwnHTfCJY8AsK?=
 =?us-ascii?Q?Rg+bDNgqv20Ry9j6Pg25kTBEcubEUGHP+QdRFIJU/SheVYD6vAb35YgG/3cu?=
 =?us-ascii?Q?u6ZOLU1uX11WSrx24xt6?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: da199884-9f06-4cf5-a4bf-08dc7c17a069
X-MS-Exchange-CrossTenant-AuthSource: AS8PR02MB7237.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2024 17:33:29.9833
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR02MB8092

It is preferred to use sizeof(*pointer) instead of sizeof(type)
due to the type of the variable can change and one needs not
change the former (unlike the latter). This patch has no effect
on runtime behavior.

Signed-off-by: Erick Archer <erick.archer@outlook.com>
---
 drivers/input/keyboard/atkbd.c      | 2 +-
 drivers/input/keyboard/lkkbd.c      | 2 +-
 drivers/input/keyboard/locomokbd.c  | 2 +-
 drivers/input/keyboard/maple_keyb.c | 2 +-
 drivers/input/keyboard/newtonkbd.c  | 2 +-
 drivers/input/keyboard/stowaway.c   | 2 +-
 drivers/input/keyboard/sunkbd.c     | 2 +-
 drivers/input/keyboard/xtkbd.c      | 2 +-
 8 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
index 7f67f9f2946b..f4f2078cf501 100644
--- a/drivers/input/keyboard/atkbd.c
+++ b/drivers/input/keyboard/atkbd.c
@@ -1279,7 +1279,7 @@ static int atkbd_connect(struct serio *serio, struct serio_driver *drv)
 	struct input_dev *dev;
 	int err = -ENOMEM;
 
-	atkbd = kzalloc(sizeof(struct atkbd), GFP_KERNEL);
+	atkbd = kzalloc(sizeof(*atkbd), GFP_KERNEL);
 	dev = input_allocate_device();
 	if (!atkbd || !dev)
 		goto fail1;
diff --git a/drivers/input/keyboard/lkkbd.c b/drivers/input/keyboard/lkkbd.c
index 047b654b3752..c035216dd27c 100644
--- a/drivers/input/keyboard/lkkbd.c
+++ b/drivers/input/keyboard/lkkbd.c
@@ -608,7 +608,7 @@ static int lkkbd_connect(struct serio *serio, struct serio_driver *drv)
 	int i;
 	int err;
 
-	lk = kzalloc(sizeof(struct lkkbd), GFP_KERNEL);
+	lk = kzalloc(sizeof(*lk), GFP_KERNEL);
 	input_dev = input_allocate_device();
 	if (!lk || !input_dev) {
 		err = -ENOMEM;
diff --git a/drivers/input/keyboard/locomokbd.c b/drivers/input/keyboard/locomokbd.c
index f866c03b9d0e..4b0f8323c492 100644
--- a/drivers/input/keyboard/locomokbd.c
+++ b/drivers/input/keyboard/locomokbd.c
@@ -227,7 +227,7 @@ static int locomokbd_probe(struct locomo_dev *dev)
 	struct input_dev *input_dev;
 	int i, err;
 
-	locomokbd = kzalloc(sizeof(struct locomokbd), GFP_KERNEL);
+	locomokbd = kzalloc(sizeof(*locomokbd), GFP_KERNEL);
 	input_dev = input_allocate_device();
 	if (!locomokbd || !input_dev) {
 		err = -ENOMEM;
diff --git a/drivers/input/keyboard/maple_keyb.c b/drivers/input/keyboard/maple_keyb.c
index d08b565be24c..91a1d2958109 100644
--- a/drivers/input/keyboard/maple_keyb.c
+++ b/drivers/input/keyboard/maple_keyb.c
@@ -154,7 +154,7 @@ static int probe_maple_kbd(struct device *dev)
 	mdev = to_maple_dev(dev);
 	mdrv = to_maple_driver(dev->driver);
 
-	kbd = kzalloc(sizeof(struct dc_kbd), GFP_KERNEL);
+	kbd = kzalloc(sizeof(*kbd), GFP_KERNEL);
 	if (!kbd) {
 		error = -ENOMEM;
 		goto fail;
diff --git a/drivers/input/keyboard/newtonkbd.c b/drivers/input/keyboard/newtonkbd.c
index df00a119aa9a..71e0a3f830dd 100644
--- a/drivers/input/keyboard/newtonkbd.c
+++ b/drivers/input/keyboard/newtonkbd.c
@@ -68,7 +68,7 @@ static int nkbd_connect(struct serio *serio, struct serio_driver *drv)
 	int err = -ENOMEM;
 	int i;
 
-	nkbd = kzalloc(sizeof(struct nkbd), GFP_KERNEL);
+	nkbd = kzalloc(sizeof(*nkbd), GFP_KERNEL);
 	input_dev = input_allocate_device();
 	if (!nkbd || !input_dev)
 		goto fail1;
diff --git a/drivers/input/keyboard/stowaway.c b/drivers/input/keyboard/stowaway.c
index 56e784936059..7ef0b3f4f549 100644
--- a/drivers/input/keyboard/stowaway.c
+++ b/drivers/input/keyboard/stowaway.c
@@ -72,7 +72,7 @@ static int skbd_connect(struct serio *serio, struct serio_driver *drv)
 	int err = -ENOMEM;
 	int i;
 
-	skbd = kzalloc(sizeof(struct skbd), GFP_KERNEL);
+	skbd = kzalloc(sizeof(*skbd), GFP_KERNEL);
 	input_dev = input_allocate_device();
 	if (!skbd || !input_dev)
 		goto fail1;
diff --git a/drivers/input/keyboard/sunkbd.c b/drivers/input/keyboard/sunkbd.c
index b123a208ef36..72fb46029710 100644
--- a/drivers/input/keyboard/sunkbd.c
+++ b/drivers/input/keyboard/sunkbd.c
@@ -263,7 +263,7 @@ static int sunkbd_connect(struct serio *serio, struct serio_driver *drv)
 	int err = -ENOMEM;
 	int i;
 
-	sunkbd = kzalloc(sizeof(struct sunkbd), GFP_KERNEL);
+	sunkbd = kzalloc(sizeof(*sunkbd), GFP_KERNEL);
 	input_dev = input_allocate_device();
 	if (!sunkbd || !input_dev)
 		goto fail1;
diff --git a/drivers/input/keyboard/xtkbd.c b/drivers/input/keyboard/xtkbd.c
index c9d7c2481726..befa713268ae 100644
--- a/drivers/input/keyboard/xtkbd.c
+++ b/drivers/input/keyboard/xtkbd.c
@@ -70,7 +70,7 @@ static int xtkbd_connect(struct serio *serio, struct serio_driver *drv)
 	int err = -ENOMEM;
 	int i;
 
-	xtkbd = kmalloc(sizeof(struct xtkbd), GFP_KERNEL);
+	xtkbd = kmalloc(sizeof(*xtkbd), GFP_KERNEL);
 	input_dev = input_allocate_device();
 	if (!xtkbd || !input_dev)
 		goto fail1;
-- 
2.25.1