Received: by 2002:a89:d88:0:b0:1fa:5c73:8e2d with SMTP id eb8csp745643lqb; Fri, 24 May 2024 11:48:34 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVU1OteF/KrfsIx+3VVX1lSZc5v7UQHuovtYKzZ3lfk2XsIbFEFEvUZqeJcUic9+spOwHQR1r96FB1BHO7Oiop3KDuEKqmX9+swWx5TRQ== X-Google-Smtp-Source: AGHT+IF2jMp01z+zbFja7ENGLS9jmEmWSdlpk0qlP05z4zW0cPMau1a99+724pt+sd8PksmuCHGN X-Received: by 2002:a17:902:db0d:b0:1f3:39d9:b2d5 with SMTP id d9443c01a7336-1f44990376fmr39326595ad.67.1716576514623; Fri, 24 May 2024 11:48:34 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716576514; cv=pass; d=google.com; s=arc-20160816; b=hWJvQkeO+BLz+GP5XsIkIlV+z1UuMF0K9d9LYF1Hd8Gjk9xsj8XwY6ldxdB3Qz14UD UsORB29SPJrnCOWUyjkcZkV9BCwKsRYDHbWb8VM1cXVpZ4/mBqEOXQENRlNRNPieGIot mmgLXHUcxYpqC7mCRBl7zfTfmHEGpgvSRyFTugn6BfcG32XOV5Ymh8cNQ9LkXyXflrNG vv3ypR2agzvBmuBp8Z2TmyrVI7whTFUdZOSgM+vFye3wNPSt0/GjmgJufdwkADKlRVjA 8o7f2UQr2XO9zj45mz27k8E/koCLdOw8RRr9r0k/pIE29V5KlSrqu9oxBu4kRvLoplJT TmNw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=K03GNtWVmJPKVVQMTb7a854Ol2QjAiRCHfbNxrRekzI=; fh=oR1qi/7X1yvysSfpTsJR4C6lMZSzW5cYjlskMOSh00Q=; b=zvpk2ctsjcXCtGCNsB7lh9X2JqpzYoDwUgSpeTEN2qfRvmte0+DX5pPQZXYmqNzNct YKKoXczaivyKcUiPe9Sa5LHnEZxLVm2LSRup5Bi/zxbCowiqbD2yvdoZVPyVLFOWkUZl bVDHVKXC4ANHG57NPEeMAxp5FZWKdQ+lerFLa04dUUOzit+7XfU4ES7ES5Gp8UU3ALIH oYKFIKtyVwQdrx+JhXSz0izraaAB6XtFvnp7ecvHWYCFSCXY/yLAuW4q4ltwPgEg0Lvl 0+upiNWUbBej2Zq9WFDg3Ro/E5ALm5ZymEtzwCqMg31p1VlZFuuZJJhffQnPrHY6GkoY 5RtA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=ZBNDhN4m; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-189015-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-189015-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id d9443c01a7336-1f44c785cf7si17997175ad.66.2024.05.24.11.48.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 May 2024 11:48:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-189015-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=ZBNDhN4m; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-189015-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-189015-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id A7804B24580 for ; Fri, 24 May 2024 18:34:30 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7362145948; Fri, 24 May 2024 18:32:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="ZBNDhN4m" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BE7141C85; Fri, 24 May 2024 18:32:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716575535; cv=none; b=m+uzyGfEmiwDN4NWtGl06CngDHXH1nEiDC7ntx609UJUTKffBDc7RCcRwst8BdGFLhl+YWr9aIBZlWTEqgdvoR/Skp2hJTZvx/RE3PUKn3pRBmM0dSttOgWsmiSj5IStrKkc4jqIij9g63i8vehDi6QpkXf2DFCf35m5IAJtfvs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716575535; c=relaxed/simple; bh=ZDW6n8R+BbYSZWdXmek/HnmZttNw+oIvTXE643uclug=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IBB7v3MZp6cuFpgSbcwxh+lznojv0HHHE5ZNMt3mqKQa/G9hNTiyTpXJ+YBRPk+WwLCsHJWb2uXC15CqohFz0VMxLWNaRSkV3bUDJ8l8me7wnfRd4myt4Ly43tifRzH4geqvtQxdhxM8XCe88/qDlonN5fzLbtiLhv3eFePDaE4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=ZBNDhN4m; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=K03GNtWVmJPKVVQMTb7a854Ol2QjAiRCHfbNxrRekzI=; b=ZBNDhN4mHvJ+uJ7Nn43x5PtElC zwBeXSm6fuQRM4NIbuYbs9Kl7sLYc+iR+wt45j4h7nP19aW5ivLR03hIftzsQLAEZhRvWh+1xR7iX PZMUtXY2lqOGXzjbZ90YrnzQ+QS4Wddd3IHXLoojOMBK5ApH7u5Y6nSWOG5axhfStUWI=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1sAZhp-00FyHj-J9; Fri, 24 May 2024 20:31:53 +0200 Date: Fri, 24 May 2024 20:31:53 +0200 From: Andrew Lunn To: =?iso-8859-1?Q?Ram=F3n?= Nordin Rodriguez Cc: Parthiban.Veerasooran@microchip.com, Pier.Beruto@onsemi.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, saeedm@nvidia.com, anthony.l.nguyen@intel.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, corbet@lwn.net, linux-doc@vger.kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org, Horatiu.Vultur@microchip.com, ruanjinjie@huawei.com, Steen.Hegelund@microchip.com, vladimir.oltean@nxp.com, UNGLinuxDriver@microchip.com, Thorsten.Kummermehr@microchip.com, Selvamani.Rajagopal@onsemi.com, Nicolas.Ferre@microchip.com, benjamin.bigler@bernformulastudent.ch Subject: Re: [PATCH net-next v4 05/12] net: ethernet: oa_tc6: implement error interrupts unmasking Message-ID: <7aaff08b-a770-4d93-b691-e89b4c40625e@lunn.ch> References: <708d29de-b54a-40a4-8879-67f6e246f851@lunn.ch> <6e4207cd-2bd5-4f5b-821f-bc87c1296367@microchip.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: > After a considerable ammount of headscratching it seems that disabling collision > detection on the macphy is the only way of getting it stable. > When PLCA is enabled it's expected that CD causes problems, when running > in CSMA/CD mode it was unexpected (for me at least). Now we are back to, why is your system different? What is triggering a collision for you, but not Parthiban? There is nothing in the standard about reporting a collision. So this is a Microchip extension? So the framework is not doing anything when it happens, which will explain why it becomes a storm.... Until we do have a mechanism to handle vendor specific interrupts, the frame work should disable them all, to avoid this storm. Does the datasheet document what to do on a collision? How are you supposed to clear the condition? Andrew