Received-SPF: pass (google.com: domain of linux-kernel+bounces-189083-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240521010439.321264-1-irogers@google.com> <CAM9d7cibAi-Xnr5HTCT6HB0sat=w5qicDrr+pcMuUF0OfNQRPQ@mail.gmail.com>
 <ZlDVLBQ84O7fN9K4@google.com>
In-Reply-To: <ZlDVLBQ84O7fN9K4@google.com>
From: Ian Rogers <irogers@google.com>
Date: Fri, 24 May 2024 13:22:43 -0700
Message-ID: <CAP-5=fU7V9F2vq=E=vHyD2E=ijx61UCsE=oywd3mTG7mnO3ttA@mail.gmail.com>
Subject: Re: [PATCH v2 0/3] Use BPF filters for a "perf top -u" workaround
To: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>, 
	Arnaldo Carvalho de Melo <acme@kernel.org>, Mark Rutland <mark.rutland@arm.com>, 
	Alexander Shishkin <alexander.shishkin@linux.intel.com>, Jiri Olsa <jolsa@kernel.org>, 
	Adrian Hunter <adrian.hunter@intel.com>, Kan Liang <kan.liang@linux.intel.com>, 
	Changbin Du <changbin.du@huawei.com>, John Fastabend <john.fastabend@gmail.com>, 
	Andrii Nakryiko <andrii@kernel.org>, linux-perf-users@vger.kernel.org, 
	linux-kernel@vger.kernel.org, bpf@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, May 24, 2024 at 10:58=E2=80=AFAM Namhyung Kim <namhyung@kernel.org>=
 wrote:
>
> On Wed, May 22, 2024 at 09:38:57PM -0700, Namhyung Kim wrote:
> > On Mon, May 20, 2024 at 6:04=E2=80=AFPM Ian Rogers <irogers@google.com>=
 wrote:
> > >
> > > Allow uid and gid to be terms in BPF filters by first breaking the
> > > connection between filter terms and PERF_SAMPLE_xx values. Calculate
> > > the uid and gid using the bpf_get_current_uid_gid helper, rather than
> > > from a value in the sample. Allow filters to be passed to perf top, t=
his allows:
> > >
> > > $ perf top -e cycles:P --filter "uid =3D=3D $(id -u)"
> > >
> > > to work as a "perf top -u" workaround, as "perf top -u" usually fails
> > > due to processes/threads terminating between the /proc scan and the
> > > perf_event_open.
> > >
> > > v2. Allow PERF_SAMPLE_xx to be computed from the PBF_TERM_xx value
> > >     using a shift as requested by Namhyung.
> > >
> > > Ian Rogers (3):
> > >   perf bpf filter: Give terms their own enum
> > >   perf bpf filter: Add uid and gid terms
> > >   perf top: Allow filters on events
>
> Hmm.. I'm seeing this.
>
>   $ make build-test
>   ...
>   cd . && make GEN_VMLINUX_H=3D1 FEATURES_DUMP=3D/home/namhyung/project/l=
inux/tools/perf/BUILD_TEST_FEATURE_DUMP -j64 O=3D/tmp/tmp.EeXFOfLPt5 DESTDI=
R=3D/tmp/tmp.Y0eiZKvc9D
>   ...
>     CLANG   /tmp/tmp.EeXFOfLPt5/util/bpf_skel/.tmp/sample_filter.bpf.o
>   In file included from util/bpf_skel/sample_filter.bpf.c:8:
>   In file included from util/bpf_skel/sample-filter.h:4:
>   /home/namhyung/project/linux/tools/include/uapi/linux/perf_event.h:29:6=
: error: redefinition of 'perf_type_id'
>   enum perf_type_id {
>        ^
>   /tmp/tmp.EeXFOfLPt5/util/bpf_skel/.tmp/../vmlinux.h:54086:6: note: prev=
ious definition is here
>   enum perf_type_id {
>        ^
>   In file included from util/bpf_skel/sample_filter.bpf.c:8:
>   In file included from util/bpf_skel/sample-filter.h:4:
>   /home/namhyung/project/linux/tools/include/uapi/linux/perf_event.h:30:2=
: error: redefinition of enumerator 'PERF_TYPE_HARDWARE'
>           PERF_TYPE_HARDWARE                      =3D 0,
>           ^
>   /tmp/tmp.EeXFOfLPt5/util/bpf_skel/.tmp/../vmlinux.h:54087:2: note: prev=
ious definition is here
>           PERF_TYPE_HARDWARE =3D 0,
>           ^
>   ...
>   make[3]: *** [Makefile.perf:264: sub-make] Error 2
>   make[2]: *** [Makefile:70: all] Error 2
>   make[1]: *** [tests/make:340: make_gen_vmlinux_h_O] Error 1
>   make: *** [Makefile:103: build-test] Error 2

IIRC this only exists for the sake of asserts. I can move the asserts
to placate the generated vmlinux.h. I'll send a v3.

Thanks,
Ian

> Thanks,
> Namhyung
>