Received-SPF: pass (google.com: domain of linux-kernel+bounces-189143-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Sat, 25 May 2024 00:24:30 +0300
Message-Id: <D1I6WMDSLOW0.2RS18E7T61X9A@kernel.org>
Cc: "david" <david@sigma-star.at>, "oe-kbuild-all"
 <oe-kbuild-all@lists.linux.dev>, "linux-kernel"
 <linux-kernel@vger.kernel.org>, "david oberhollenzer"
 <david.oberhollenzer@sigma-star.at>
Subject: Re: security/keys/trusted-keys/trusted_dcp.c:206:24: sparse:
 sparse: incorrect type in assignment (different base types)
From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Richard Weinberger" <richard@nod.at>, "kernel test robot"
 <lkp@intel.com>
References: <202405240610.fj53EK0q-lkp@intel.com>
 <1855855000.144805.1716584815663.JavaMail.zimbra@nod.at>
In-Reply-To: <1855855000.144805.1716584815663.JavaMail.zimbra@nod.at>

On Sat May 25, 2024 at 12:06 AM EEST, Richard Weinberger wrote:
> >| Reported-by: kernel test robot <lkp@intel.com>
> >| Closes:
> >| https://lore.kernel.org/oe-kbuild-all/202405240610.fj53EK0q-lkp@intel.=
com/
> >=20
> > sparse warnings: (new ones prefixed by >>)
> >>> security/keys/trusted-keys/trusted_dcp.c:206:24: sparse: sparse: inco=
rrect type
> >>> in assignment (different base types) @@     expected restricted __le3=
2
> >>> [usertype] payload_len @@     got unsigned int @@
> >   security/keys/trusted-keys/trusted_dcp.c:206:24: sparse:     expected=
 restricted
> >   __le32 [usertype] payload_len
> >   security/keys/trusted-keys/trusted_dcp.c:206:24: sparse:     got unsi=
gned int
> >=20
> > vim +206 security/keys/trusted-keys/trusted_dcp.c
> >=20
> >   179
> >   180	static int trusted_dcp_seal(struct trusted_key_payload *p, char *=
datablob)
> >   181	{
> >   182		struct dcp_blob_fmt *b =3D (struct dcp_blob_fmt *)p->blob;
> >   183		int blen, ret;
> >   184
> >   185		blen =3D calc_blob_len(p->key_len);
> >   186		if (blen > MAX_BLOB_SIZE)
> >   187			return -E2BIG;
> >   188
> >   189		b->fmt_version =3D DCP_BLOB_VERSION;
> >   190		get_random_bytes(b->nonce, AES_KEYSIZE_128);
> >   191		get_random_bytes(b->blob_key, AES_KEYSIZE_128);
> >   192
> >   193		ret =3D do_aead_crypto(p->key, b->payload, p->key_len, b->blob_k=
ey,
> >   194				     b->nonce, true);
> >   195		if (ret) {
> >   196			pr_err("Unable to encrypt blob payload: %i\n", ret);
> >   197			return ret;
> >   198		}
> >   199
> >   200		ret =3D encrypt_blob_key(b->blob_key);
> >   201		if (ret) {
> >   202			pr_err("Unable to encrypt blob key: %i\n", ret);
> >   203			return ret;
> >   204		}
> >   205
> > > 206		b->payload_len =3D get_unaligned_le32(&p->key_len);
>
> I think this should be a put_unaligned_le32(p->key_len, &b->payload_len).

Please send then fix, reasoning of that, and finally:

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202405240610.fj53EK0q-lkp@int=
el.com/

> Thanks,
> //richard

BR, Jarkko