Received-SPF: pass (google.com: domain of linux-kernel+bounces-189148-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 24 May 2024 23:27:42 +0200 (CEST)
From: Richard Weinberger <richard@nod.at>
To: Jarkko Sakkinen <jarkko@kernel.org>
Cc: kernel test robot <lkp@intel.com>, david <david@sigma-star.at>, 
	oe-kbuild-all <oe-kbuild-all@lists.linux.dev>, 
	linux-kernel <linux-kernel@vger.kernel.org>, 
	david oberhollenzer <david.oberhollenzer@sigma-star.at>
Message-ID: <39518719.144820.1716586062550.JavaMail.zimbra@nod.at>
In-Reply-To: <D1I6WMDSLOW0.2RS18E7T61X9A@kernel.org>
References: <202405240610.fj53EK0q-lkp@intel.com> <1855855000.144805.1716584815663.JavaMail.zimbra@nod.at> <D1I6WMDSLOW0.2RS18E7T61X9A@kernel.org>
Subject: Re: security/keys/trusted-keys/trusted_dcp.c:206:24: sparse:
 sparse: incorrect type in assignment (different base types)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Thread-Topic: security/keys/trusted-keys/trusted_dcp.c:206:24: sparse: sparse: incorrect type in assignment (different base types)
Thread-Index: YxKdVb/v6foZyOVf4L0HtOwHX9OJ0Q==

----- Urspr=C3=BCngliche Mail -----
> Von: "Jarkko Sakkinen" <jarkko@kernel.org>
> An: "richard" <richard@nod.at>, "kernel test robot" <lkp@intel.com>
> CC: "david" <david@sigma-star.at>, "oe-kbuild-all" <oe-kbuild-all@lists.l=
inux.dev>, "linux-kernel"
> <linux-kernel@vger.kernel.org>, "david oberhollenzer" <david.oberhollenze=
r@sigma-star.at>
> Gesendet: Freitag, 24. Mai 2024 23:24:30
> Betreff: Re: security/keys/trusted-keys/trusted_dcp.c:206:24: sparse: spa=
rse: incorrect type in assignment (different
> base types)

> On Sat May 25, 2024 at 12:06 AM EEST, Richard Weinberger wrote:
>> >| Reported-by: kernel test robot <lkp@intel.com>
>> >| Closes:
>> >| https://lore.kernel.org/oe-kbuild-all/202405240610.fj53EK0q-lkp@intel=
com/
>> >=20
>> > sparse warnings: (new ones prefixed by >>)
>> >>> security/keys/trusted-keys/trusted_dcp.c:206:24: sparse: sparse: inc=
orrect type
>> >>> in assignment (different base types) @@     expected restricted __le=
32
>> >>> [usertype] payload_len @@     got unsigned int @@
>> >   security/keys/trusted-keys/trusted_dcp.c:206:24: sparse:     expecte=
d restricted
>> >   __le32 [usertype] payload_len
>> >   security/keys/trusted-keys/trusted_dcp.c:206:24: sparse:     got uns=
igned int
>> >=20
>> > vim +206 security/keys/trusted-keys/trusted_dcp.c
>> >=20
>> >   179
>> >   180=09static int trusted_dcp_seal(struct trusted_key_payload *p, cha=
r *datablob)
>> >   181=09{
>> >   182=09=09struct dcp_blob_fmt *b =3D (struct dcp_blob_fmt *)p->blob;
>> >   183=09=09int blen, ret;
>> >   184
>> >   185=09=09blen =3D calc_blob_len(p->key_len);
>> >   186=09=09if (blen > MAX_BLOB_SIZE)
>> >   187=09=09=09return -E2BIG;
>> >   188
>> >   189=09=09b->fmt_version =3D DCP_BLOB_VERSION;
>> >   190=09=09get_random_bytes(b->nonce, AES_KEYSIZE_128);
>> >   191=09=09get_random_bytes(b->blob_key, AES_KEYSIZE_128);
>> >   192
>> >   193=09=09ret =3D do_aead_crypto(p->key, b->payload, p->key_len, b->b=
lob_key,
>> >   194=09=09=09=09     b->nonce, true);
>> >   195=09=09if (ret) {
>> >   196=09=09=09pr_err("Unable to encrypt blob payload: %i\n", ret);
>> >   197=09=09=09return ret;
>> >   198=09=09}
>> >   199
>> >   200=09=09ret =3D encrypt_blob_key(b->blob_key);
>> >   201=09=09if (ret) {
>> >   202=09=09=09pr_err("Unable to encrypt blob key: %i\n", ret);
>> >   203=09=09=09return ret;
>> >   204=09=09}
>> >   205
>> > > 206=09=09b->payload_len =3D get_unaligned_le32(&p->key_len);
>>
>> I think this should be a put_unaligned_le32(p->key_len, &b->payload_len)=
.
>=20
> Please send then fix, reasoning of that, and finally:

Sure. Let me first talk to David and give it a test...

Thanks,
//richard