Received-SPF: pass (google.com: domain of linux-kernel+bounces-189153-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <2339db0d-db21-4372-808d-8648500e971a@ti.com>
Date: Fri, 24 May 2024 16:44:05 -0500
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 2/8] dt-bindings: counter: Add new ti,am62-eqep
 compatible
To: David Lechner <david@lechnology.com>, Rob Herring <robh@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley
	<conor+dt@kernel.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon
	<will@kernel.org>,
        William Breathitt Gray <william.gray@linaro.org>
CC: <linux-arm-kernel@lists.infradead.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-iio@vger.kernel.org>,
        Nishanth Menon
	<nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>
References: <20240523231516.545085-1-jm@ti.com>
 <20240523231516.545085-3-jm@ti.com>
 <2956d10b-d2cf-4019-adc8-d8053e435767@lechnology.com>
 <e6a03921-532c-4aa7-92b6-812cd9a356d6@lechnology.com>
Content-Language: en-US
From: Judith Mendez <jm@ti.com>
In-Reply-To: <e6a03921-532c-4aa7-92b6-812cd9a356d6@lechnology.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit

On 5/24/24 3:57 PM, David Lechner wrote:
> On 5/24/24 3:50 PM, David Lechner wrote:
>> On 5/23/24 6:15 PM, Judith Mendez wrote:
>>> Add new compatible ti,am62-eqep for TI K3 devices. If a device
>>> uses this compatible, require power-domains property.
>>>
>>> Since there is only one functional and interface clock for eqep,
>>> clock-names is not really required. The clock-name also changed
>>> for TI K3 SoCs so make clock-names optional for the new compatible
>>> since there is only one clock that is routed to the IP.
>>>
>>> While we are here, add an example using ti,am62-eqep compatible.
>>>
>>> Signed-off-by: Judith Mendez <jm@ti.com>
>>> ---
>>> Changes since v1:
>>> - Fix eqep binding for new compatible, require
>>>   power-domains for new compatible
>>> ---
>>>   .../devicetree/bindings/counter/ti-eqep.yaml  | 53 +++++++++++++++++--
>>>   1 file changed, 48 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/counter/ti-eqep.yaml b/Documentation/devicetree/bindings/counter/ti-eqep.yaml
>>> index 85f1ff83afe72..c4bb0231f166a 100644
>>> --- a/Documentation/devicetree/bindings/counter/ti-eqep.yaml
>>> +++ b/Documentation/devicetree/bindings/counter/ti-eqep.yaml
>>> @@ -11,7 +11,9 @@ maintainers:
>>>   
>>>   properties:
>>>     compatible:
>>> -    const: ti,am3352-eqep
>>> +    enum:
>>> +      - ti,am3352-eqep
>>> +      - ti,am62-eqep
>>>   
>>>     reg:
>>>       maxItems: 1
>>> @@ -21,19 +23,43 @@ properties:
>>>       maxItems: 1
>>>   
>>>     clocks:
>>> -    description: The clock that determines the SYSCLKOUT rate for the eQEP
>>> -      peripheral.
>>> +    description: The functional and interface clock that determines the clock
>>> +      rate for the eQEP peripheral.
>>>       maxItems: 1
>>>   
>>>     clock-names:
>>> -    const: sysclkout
>>> +    enum:
>>> +      - sysclkout
>>> +      - fck
>>> +
>>
>> If we are making this optional for ti,am62-eqep, why add a new name?
>>
>> Also, we could change the description to say that sysclockout is not a
>> great name but is required for backwards compatibility.
>>
>>> +  power-domains:
>>> +    maxItems: 1
>>> +
>>> +allOf:
>>> +  - if:
>>> +      properties:
>>> +        compatible:
>>> +          contains:
>>> +            enum:
>>> +              - ti,am3352-eqep
>>> +    then:
>>> +      required:
>>> +        - clock-names
> 
> I just looked at the Linux driver for this and the clock name is
> not used in the driver. So we could probably just deprecate the
> clock-names property here and not make it required for
> ti,am3352-eqep (and not allowed for any new compatibles as
> suggested below).

We could do this, although I was under the impression that we should
not drop DT properties just because the linux driver isn't using it,
that is why I went with keeping clock-names around for am335x compatible
and making it optional for am62x compatible.

But if it is all the same, we could drop the the DT property.

~ Judith

> 
>>
>> What if we just add
>>
>>    else:
>>      clock-names: false
>>
>> since there is only one clock and not worry about the name?
>>
>>> +  - if:
>>> +      properties:
>>> +        compatible:
>>> +          contains:
>>> +            enum:
>>> +              - ti,am62-eqep
>>> +    then:
>>> +      required:
>>> +        - power-domains
>>>   
>>>   required:
>>>     - compatible
>>>     - reg
>>>     - interrupts
>>>     - clocks
>>> -  - clock-names
>>>   
>