Received-SPF: pass (google.com: domain of linux-kernel+bounces-189188-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240521173952.3397644-1-weilin.wang@intel.com> <20240521173952.3397644-8-weilin.wang@intel.com>
In-Reply-To: <20240521173952.3397644-8-weilin.wang@intel.com>
From: Namhyung Kim <namhyung@kernel.org>
Date: Fri, 24 May 2024 16:24:04 -0700
Message-ID: <CAM9d7chURO---Gw1M+T9AafgAJHsN=sOqQzqx5M31RR57m_i2A@mail.gmail.com>
Subject: Re: [RFC PATCH v9 7/7] perf test: Add test for Intel TPEBS counting mode
To: weilin.wang@intel.com
Cc: Ian Rogers <irogers@google.com>, Arnaldo Carvalho de Melo <acme@kernel.org>, 
	Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>, 
	Alexander Shishkin <alexander.shishkin@linux.intel.com>, Jiri Olsa <jolsa@kernel.org>, 
	Adrian Hunter <adrian.hunter@intel.com>, Kan Liang <kan.liang@linux.intel.com>, 
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, 
	Perry Taylor <perry.taylor@intel.com>, Samantha Alt <samantha.alt@intel.com>, 
	Caleb Biggers <caleb.biggers@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, May 21, 2024 at 10:40=E2=80=AFAM <weilin.wang@intel.com> wrote:
>
> From: Weilin Wang <weilin.wang@intel.com>
>
> Intel TPEBS sampling mode is supported through perf record. The counting =
mode
> code uses perf record to capture retire_latency value and use it in metri=
c
> calculation. This test checks the counting mode code.
>
> Signed-off-by: Weilin Wang <weilin.wang@intel.com>
> ---
>  .../perf/tests/shell/test_stat_intel_tpebs.sh | 27 +++++++++++++++++++
>  1 file changed, 27 insertions(+)
>  create mode 100755 tools/perf/tests/shell/test_stat_intel_tpebs.sh
>
> diff --git a/tools/perf/tests/shell/test_stat_intel_tpebs.sh b/tools/perf=
/tests/shell/test_stat_intel_tpebs.sh
> new file mode 100755
> index 000000000000..4cb749d84367
> --- /dev/null
> +++ b/tools/perf/tests/shell/test_stat_intel_tpebs.sh
> @@ -0,0 +1,27 @@
> +#!/bin/sh
> +# test Intel TPEBS counting mode
> +# SPDX-License-Identifier: GPL-2.0
> +
> +set e
> +err=3D0
> +
> +# Use this event for testing because it should exist in all platforms
> +e=3Dcache-misses:R
> +
> +# Without this cmd option, default value or zero is returned
> +echo "Testing without --enable-tpebs-recording"
> +result=3D$(perf stat -e "$e" true 2>&1)
> +[[ "$result" =3D~ "$e" ]] && err=3D0 || err=3D1
> +
> +if [[ "$err" =3D=3D 1 ]]
> +then
> +       exit "$err"
> +fi

Probably you can just do

[[ "$result" =3D~ "$e" ]] || exit 1


> +
> +# In platforms that do not support TPEBS, it should execute without erro=
r.
> +echo "Testing with --enable-tpebs-recording"
> +result=3D$(perf stat -e "$e" --enable-tpebs-recording -a sleep 0.01 2>&1=
)
> +[[ "$result" =3D~ "perf record" && "$result" =3D~ "$e" ]] && err=3D0 || =
err=3D1

Ditto.

Thanks,
Namhyung


> +
> +
> +exit "$err"
> --
> 2.43.0
>