Received: by 2002:a89:d88:0:b0:1fa:5c73:8e2d with SMTP id eb8csp881449lqb; Fri, 24 May 2024 17:44:22 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVoyAxkDmpgbqmtEYeBh5vblEnk56WhG2KSQLX3LDh5IVylYLSCIPtyQOTZLM3Kcc4F7ePWbj0rzWuM8i5igd/5ujIFgJqfNNUqdSSmiw== X-Google-Smtp-Source: AGHT+IGskkWvVggYw29hUN+cwfeZ88iXaijz8XxsB5EIpMEXiu3H0J14ZZV76UOTzDim7miPDU22 X-Received: by 2002:a05:6a20:1008:b0:1b2:b2b:5698 with SMTP id adf61e73a8af0-1b212d3be71mr3788796637.33.1716597861688; Fri, 24 May 2024 17:44:21 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716597861; cv=pass; d=google.com; s=arc-20160816; b=mcH6jpwFF/1yylTNMsth9drPNUMwWAg29CIOA37WvVdkUWZPVum0xh7JY42O2Q8nl0 IZ6O58JWdjkhq0XDIDDN/hdyiKip1222RwIW/eWF9RH64YDxe4zIXdcWNnext0ZlfebD RZweal5GCo9FY6H9FRXLTieoTYaV145luocHU78/lC1zY9QpIko+m1ryCtjzF703wHAe bfo9iaNL8YQTc2LN+/6Fp1qycOPrr7CW/5UAi5jgq/1UmZ2kxm4SaYjWoMa2NZ7GMB2o VwXjiQWIgSdzWdfbQB5RJutEnLJVunYSLuQx4B2vFtU2bOgn+C8udtzZ8puk28sgwi5+ ARCA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=wxIJIPCIKkt3/mHS0ipe4p00+OQoqeZ3PhggMkOF4GA=; fh=6Lmy1xK196Ez5xT5beSJn9ZZIuVsfevDAxd18QkH+Eo=; b=b8XqFu1xjOdreOkM+Mx4GHgoiXgn43yJ1UbagF4gB29kz4Eef2lw1BCTX89MRzofoW 8g1m/OyIk1UVM/cFVZD9j31ypJMDUsNO6EJsgCjgfqiXLHPLeaS2GjGKUNwgVdvB7ZDZ 6tapj7x3f26D14uMzzR2wMfWoPH2eLIjDEWdaawKyH1GdjjcBLJmFEcnY0YIwIp2dTlU ENWY9qihQ/lXQ3p2eLLY4gvh2YrO0GxMEohjjnO1xfrvTS2WXfb/IyGBzumUPkCwF+ZP 8bUxePAoYp1KYhE2r+VwUx1msIMDdsbGOz7TrRRbKzyggWiZDLDHRwNMHqd8GtB0yygL a8WQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pdiYzJEo; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-189217-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-189217-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id 98e67ed59e1d1-2bdd9f4de78si4112752a91.104.2024.05.24.17.44.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 May 2024 17:44:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-189217-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pdiYzJEo; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-189217-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-189217-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 8552B282C77 for ; Sat, 25 May 2024 00:44:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6E67B4A0C; Sat, 25 May 2024 00:44:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="pdiYzJEo" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B5F12913; Sat, 25 May 2024 00:44:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716597851; cv=none; b=o37VGuoP9xtPKGjX/FREcjVnkvu1qfhg/TGSqtCKtBjp29StosLLd1PWJz0kRV0IMvht2nBnVlupCsJTxROLwnelcImWDnVva4ztB27qBY6BnTGXlP+CJV0b0Stloutk3RswkJUM7ykoeCQkv0LXvAR9gyXBk5LlRA3Atc7w3TI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716597851; c=relaxed/simple; bh=wxIJIPCIKkt3/mHS0ipe4p00+OQoqeZ3PhggMkOF4GA=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=X/OSXI0y12qttp3vFBUhPrPcGaFKqkxI22qrIKUJO39yaaQEBMSVqvv32cPkH/el082amBTTyIyqPwUimmi2zZYJQ3CVxNnmsKp/CGB6inB8IKKFZdXIev6b4pYrDesrEe/l2WvAQyNqNHw9ROFaNGqILGYsvYynw/keYmHSC/w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=pdiYzJEo; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1D204C2BBFC; Sat, 25 May 2024 00:44:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716597851; bh=wxIJIPCIKkt3/mHS0ipe4p00+OQoqeZ3PhggMkOF4GA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=pdiYzJEo+n24UbPs/kiRny/2UJq8iEYIZgCmfmTxkGiyh6G/i28gmyFwGEBkDQ5OW JBLBgvWG4fHnFEQ2m0bpZ+VA4LW5CjB5/j4HqJck4uxOLqWoorFrm2UB4SgCR6XWO9 7iLqmQYCHgN3lbPChAY+UUOfemxxPSiax5UdwXLmcodvNaHJolWqMa2hXrHHDOwRvi NXzKwdlI8vTnGMaeVaX0PmM2L9l93QPn1MmWbvQPbl1TXJhYPhExr9t1zQVuGUKo+H kFPEt641aWtJzDW5cshtQa7FhCM20eSPFuJw+cmzCLmGMNI45/irc253+wNis0jMs6 29u3Ex9lxyV4Q== Received: by mail-oa1-f43.google.com with SMTP id 586e51a60fabf-24ca2f48031so528774fac.0; Fri, 24 May 2024 17:44:11 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCU5afPJHiJ87/euaJF4K86IDDgfubhfaleeReas4V8arHLHz4HejQqr/Fkq+2HmQlfb/SaLe/n9wUx55VftysmGjvoU21/50gWzkbsyRMYSGgZBargYB8WMLvVCwdMXJ4+8icWUh1tIC3dxwQ== X-Gm-Message-State: AOJu0Yz4neM9ZW39Q8U4ydUtNmw+87+gtaOPx9X8l/c4zNYdSMcgAqEc J63yS23cMEz7vP2jhrYk4jdFZLH6aoj02PIZWhu3ms3NtvS0k7L7+kIQtKbngU6EoR4U9eRouyq 59fsvlsw3C2CjBJ+H8jtALApQniM= X-Received: by 2002:a05:6871:a588:b0:220:6edc:1fd7 with SMTP id 586e51a60fabf-24ca11f424cmr3993002fac.1.1716597850415; Fri, 24 May 2024 17:44:10 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240523011007.40649-1-mjeanson@efficios.com> <20240524-verordnen-exhumieren-2ea2e8bc2d08@brauner> In-Reply-To: <20240524-verordnen-exhumieren-2ea2e8bc2d08@brauner> From: Namjae Jeon Date: Sat, 25 May 2024 09:43:59 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] exfat: handle idmapped mounts To: Michael Jeanson Cc: Alexander Mikhalitsyn , linux-kernel@vger.kernel.org, Sungjong Seo , Seth Forshee , linux-fsdevel@vger.kernel.org, Christian Brauner Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable 2024=EB=85=84 5=EC=9B=94 24=EC=9D=BC (=EA=B8=88) =EC=98=A4=ED=9B=84 10:58, = Christian Brauner =EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1= : > > [Cc: Alex] > > On Wed, May 22, 2024 at 09:10:07PM -0400, Michael Jeanson wrote: > > Pass the idmapped mount information to the different helper > > functions. Adapt the uid/gid checks in exfat_setattr to use the > > vfsuid/vfsgid helpers. > > > > Based on the fat implementation in commit 4b7899368108 > > ("fat: handle idmapped mounts") by Christian Brauner. > > > > Cc: Namjae Jeon > > Cc: Sungjong Seo > > Cc: Christian Brauner > > Cc: Seth Forshee > > Cc: linux-fsdevel@vger.kernel.org > > Signed-off-by: Michael Jeanson > > --- > > Looks good to me but maybe Alex sees some issues I dont, > Reviewed-by: Christian Brauner Applied it to #dev. Thanks for your patch!