Received-SPF: pass (google.com: domain of linux-kernel+bounces-189223-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240522204254.1841420-1-weilin.wang@intel.com>
In-Reply-To: <20240522204254.1841420-1-weilin.wang@intel.com>
From: Ian Rogers <irogers@google.com>
Date: Fri, 24 May 2024 18:26:27 -0700
Message-ID: <CAP-5=fUtp_vd=EeeesXPR=nsm0VOZoyXico=EVWobOEYsxq27g@mail.gmail.com>
Subject: Re: [PATCH v1 1/1] perf test: make metric validation test return
 early when there is no metric supported on the test system
To: weilin.wang@intel.com
Cc: Kan Liang <kan.liang@linux.intel.com>, Namhyung Kim <namhyung@kernel.org>, 
	Arnaldo Carvalho de Melo <acme@kernel.org>, Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>, 
	Alexander Shishkin <alexander.shishkin@linux.intel.com>, Jiri Olsa <jolsa@kernel.org>, 
	Adrian Hunter <adrian.hunter@intel.com>, linux-perf-users@vger.kernel.org, 
	linux-kernel@vger.kernel.org, Perry Taylor <perry.taylor@intel.com>, 
	Samantha Alt <samantha.alt@intel.com>, Caleb Biggers <caleb.biggers@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, May 22, 2024 at 1:43=E2=80=AFPM <weilin.wang@intel.com> wrote:
>
> From: Weilin Wang <weilin.wang@intel.com>
>
> Add a check to return the metric validation test early when perf list met=
ric
> does not output any metric. This would happen when NO_JEVENTS=3D1 is set =
or in a
> system that there is no metric supported.
>
>
> Signed-off-by: Weilin Wang <weilin.wang@intel.com>

Tested-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
>  tools/perf/tests/shell/lib/perf_metric_validation.py | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/tests/shell/lib/perf_metric_validation.py b/tools=
/perf/tests/shell/lib/perf_metric_validation.py
> index a2d235252183..0b94216c9c46 100644
> --- a/tools/perf/tests/shell/lib/perf_metric_validation.py
> +++ b/tools/perf/tests/shell/lib/perf_metric_validation.py
> @@ -95,7 +95,7 @@ class Validator:
>                        indent=3D4)
>
>      def get_results(self, idx: int =3D 0):
> -        return self.results[idx]
> +        return self.results.get(idx)
>
>      def get_bounds(self, lb, ub, error, alias=3D{}, ridx: int =3D 0) -> =
list:
>          """
> @@ -173,7 +173,10 @@ class Validator:
>          pcnt =3D 0
>          tcnt =3D 0
>          rerun =3D list()
> -        for name, val in self.get_results().items():
> +        results =3D self.get_results()
> +        if not results:
> +            return
> +        for name, val in results.items():
>              if val < 0:
>                  negmetric[name] =3D val
>                  rerun.append(name)
> @@ -532,6 +535,9 @@ class Validator:
>          '''
>          if not self.collectlist:
>              self.parse_perf_metrics()
> +        if not self.metrics:
> +            print("No metric found for testing")
> +            return 0
>          self.create_rules()
>          for i in range(0, len(self.workloads)):
>              self.wlidx =3D i
> --
> 2.42.0
>