Received-SPF: pass (google.com: domain of linux-kernel+bounces-189278-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <94964224-1796-4610-a42d-3aacb4d47341@collabora.com>
Date: Fri, 24 May 2024 21:32:30 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Cc: Muhammad Usama Anjum <usama.anjum@collabora.com>,
 linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] selftests/openat2: Fix build warnings on ppc64
To: Michael Ellerman <mpe@ellerman.id.au>, linux-kselftest@vger.kernel.org,
 skhan@linuxfoundation.org
References: <20240521030325.58095-1-mpe@ellerman.id.au>
Content-Language: en-US
From: Muhammad Usama Anjum <usama.anjum@collabora.com>
In-Reply-To: <20240521030325.58095-1-mpe@ellerman.id.au>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

I was looking at if we can add this flag for ppc64 for all selftests
somewhere. But there isn't any suitable place other than in KHDR_INCLUDES.
But there is a series already trying to add _GNU_SOURCE to it. Once that
gets accepted, we may add this flag there by removing the definitions from
individual files. But until then the current solution seems fine:

Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>

On 5/20/24 8:03 PM, Michael Ellerman wrote:
> Fix warnings like:
> 
>   openat2_test.c: In function ‘test_openat2_flags’:
>   openat2_test.c:303:73: warning: format ‘%llX’ expects argument of type
>   ‘long long unsigned int’, but argument 5 has type ‘__u64’ {aka ‘long
>   unsigned int’} [-Wformat=]
> 
> By switching to unsigned long long for u64 for ppc64 builds.
> 
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> ---
>  tools/testing/selftests/openat2/openat2_test.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/openat2/openat2_test.c b/tools/testing/selftests/openat2/openat2_test.c
> index 9024754530b2..5790ab446527 100644
> --- a/tools/testing/selftests/openat2/openat2_test.c
> +++ b/tools/testing/selftests/openat2/openat2_test.c
> @@ -5,6 +5,7 @@
>   */
>  
>  #define _GNU_SOURCE
> +#define __SANE_USERSPACE_TYPES__ // Use ll64
>  #include <fcntl.h>
>  #include <sched.h>
>  #include <sys/stat.h>

-- 
BR,
Muhammad Usama Anjum