Received: by 2002:a89:d88:0:b0:1fa:5c73:8e2d with SMTP id eb8csp1109636lqb; Sat, 25 May 2024 06:23:08 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXvWWso+bo+c/VdesaA7QuRpgt90OPVGBuiYAvqNOxyiisaH+Dw0AdxOLruY1GxPIplhEkvhieyAoBRPfEumBk9kjWt0p4qRtJFc9cdSg== X-Google-Smtp-Source: AGHT+IGeS65VXOG5BT5MXK6D7tPQ2fdFgKOI6MWE40R4lxzt+0vO6+7OrqqTAYLppI0PtBI7l1Kf X-Received: by 2002:a05:6a00:1f12:b0:6f6:7c6a:2c14 with SMTP id d2e1a72fcca58-6f8f2c56e53mr4732891b3a.4.1716643388590; Sat, 25 May 2024 06:23:08 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716643388; cv=pass; d=google.com; s=arc-20160816; b=C/Io3ye8i32Ln1t3VcQQzJhyHjcsnd0mq2zT9Iom5I4selKcmxnfdpIQesaoSIRr3u riXZHFxV73ZSfak17r+xd0yz1Jf1YU0MUJuSvS1ak1nSQayjj7EOHEK8LonSWBTEFtOm s3DtriL++QpmV+ycXpPc2zv9TwRTd6/W57AOoHJPbXMr4QntgWbJKhmePavdS/Lf4oVN txL3H7Wet+sU+wF1jNznGsGayBSkSZGjjHE7hvyTNWmRKz52uFByGILNliWQcgLBgDc5 7rxdnBrsdxBHjlwsn/hvztVxo/ECy2PUqCg+2U/HFntjenQxyWLHk5QqYwjZO1bv4cP4 m2lw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:in-reply-to:cc:from :content-language:subject:references:to:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=twZv0XwD38Sgrc7cZswUW04/P8d8QPz8QlGCO53cniQ=; fh=izmVUZQpiK+80/eieYGEm5TQ39rHbuCjElZthX1ykME=; b=Jg/30ro4PQlPcsPqy+tQLebOCzSWvvEZXWSYPSWBRGWkIhkC4fFvjBw9oyYjIXw6Zp +JnwprBgaHQ0ARitPaZjLRPKwP8a1UT+C6oCYZkbuf8f/GT2c1qu3RXVEW3ZYG4/oE3R r2BKMaZvHCe9812wdqVN2KgKKffGwN+1QM3wpNVxpFIqh5yCucF+1Pm8nhMps5TzNSd3 mj/rqmDYMYc8OLV+cpOw/hJFsiIZVPC/q0scfAwO7fdLVJc9eDqIbj03mMitYkMwb/EM 00sIoWuy92tyCUbiw4r8wnr0fH7G1uyh/rJkjyYsg7jBpHG5s7Hi9+UehckIUJIINcs3 wkTg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=G8dNiMUb; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-189354-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-189354-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id d2e1a72fcca58-6f8fd4d3c7dsi3038000b3a.275.2024.05.25.06.23.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 May 2024 06:23:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-189354-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=G8dNiMUb; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-189354-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-189354-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id D70DC2819D1 for ; Sat, 25 May 2024 13:23:07 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A8F0E482D8; Sat, 25 May 2024 13:22:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="G8dNiMUb" Received: from mout.web.de (mout.web.de [212.227.15.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80B4A101F4; Sat, 25 May 2024 13:22:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.15.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716643377; cv=none; b=T5BugqcDnB2u+5IapwJu1Am+uYjoM6Z9N5OjLLJwXc0RyJb1UT374ID40ouqt05FUYv8ZF8HyIIxDQH2NKy0taj3aJz8HKOXfBb/95BobOqDWyK8v4e3VABSDMl8cesnBWg0GDVOxlT1G13rVIGjQ5Zj8hoX1hH4j/ineZFNnzs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716643377; c=relaxed/simple; bh=twZv0XwD38Sgrc7cZswUW04/P8d8QPz8QlGCO53cniQ=; h=Message-ID:Date:MIME-Version:To:References:Subject:From:Cc: In-Reply-To:Content-Type; b=Z85e7zFBUZziUjtf7QJO6iIIrK32PjvgDRXASF0Zp1EaQKdBVoWI1Wz3ZdKZRAqAhY9aiZHu7KprF+a+1Tdm7JpZDQeVsPM8clS4m/0FURY18DFS1AH6wwba2x1eJKJMrAqMhp0dRnFIDSOM9VbIE19uiZG1cWLEAan4dKnm310= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=G8dNiMUb; arc=none smtp.client-ip=212.227.15.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1716643351; x=1717248151; i=markus.elfring@web.de; bh=twZv0XwD38Sgrc7cZswUW04/P8d8QPz8QlGCO53cniQ=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:To:References: Subject:From:Cc:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=G8dNiMUbwUKjzXMaWkHcvdLfiXs3jWf45cPgiEfjG9T0zQLr4FYfz/Rp50ihAv6B BX3uWY8Frx9sfjGK5DIM06ITMTBpe7SIUfNKwWg4U4UAo3rChE27JwikO0wizsE/E H/g3L+HJ7ju0fDUj3TAeTUTMmtmCtbeXl+UebmdhsOu7fcaGVolL3hTXV/J3vQ1WJ MdQRz3Hb1CKSRC7j5ohuT6arVN9zsPQEN8mzmdwmTjSgXwoNdSQG/R9O6uqotGEZ8 ot+UZHOn3bx5IV6QNc9VkGxz83Y1eCT7cgdi+SaonN00zmP3K0/hzf401e/Wbhl5A L/H7lVrArypDL3htfA== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.83.95]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MKM5z-1rwloW2E4l-00Lxhx; Sat, 25 May 2024 15:22:31 +0200 Message-ID: Date: Sat, 25 May 2024 15:22:30 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Yazen Ghannam , linux-edac@vger.kernel.org, linux-hwmon@vger.kernel.org, kernel-janitors@vger.kernel.org, x86@kernel.org, =?UTF-8?B?R8O8bnRlciBSw7Zjaw==?= References: <20240523-fix-smn-bad-read-v3-2-aa44c622de39@amd.com> Subject: Re: [PATCH v3 2/8] EDAC/amd64: Check return value of amd_smn_read() Content-Language: en-GB From: Markus Elfring Cc: LKML , Mario Limonciello In-Reply-To: <20240523-fix-smn-bad-read-v3-2-aa44c622de39@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:h9m6DHXFR84RKzbcIb+FaTFLgvibH9mmJn4paw4Qt9pUSGJ3Od1 nQUAbZjvazlKRaZs06sabcarChxiTkFHP/IioLOfUxtH0DRQsMRxE1yv5idWv5zrt31V5B0 dmKB0k7L1KBbWmV+aXsNdvQpri/fsQo5D1RhqDvhJC3m1260hp29FChdfklFTZsGls5kk1g ACkGD3JXkFUoxBx9ok6DA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:HMLPTIJfApg=;xDoy1xlEVS2hpwr5HArNs8O5zrr nFRNbneLkEeMvq80JZ524EbzsyU+rZCOwFK19GKTluHxPj+wsBYkA3Fje7mUyTUW7chLCvqu+ O7ij7zgkVJHsUGMS7H7IIwARcZ184JWr1WzEBNTiPiihC0OLG2xE/EQfSddPT8JDE2obEyAsS PKsL14Omf+ykRHbNjllJwTHNdJyEY3cef2mhjvUG/4tXkdd7yFNwGqkbASxvOW5W9EskPuAxJ Hi8g/6kylZXZp6/36vUpriq1+Cn6ZVOp4ZD9mj+cu00vP0Qj8khuHAdsWo6M1dJ8S9M6U+gq7 50RH8XIMZOfscfQr4bmyLBdTdcP7e0Nh2l0M+FrsNXW1gIj9Rzm1Es/R8oP/bXA4xq6YW2hKE iCPQudJt8TkWaHeVulvPpk5GLfqRcTdmJCaYEo1sE/BrSKwfiFnNV4rBGOLVz6cKjEueh9D15 pdPLGPli75AA48polfPADoRbGw7KKMUAoW2IwDzUg3/rySTTkI4X+f6mvRnyVxOVCnYpuh9JD PMePvSXaEibvEQUTjFLPRX3YU/+Czbw6UmGk6lJL/x+cenMJnxxTDEe78GG3W7fMBoxt5JmV1 Dg3xPL8FwN4Vm4SJUz7xzw1RNrHbojLaaU/iR40KywJ3fKZNwLEcZA04exVXwup9Ld3S1EczF qaVdNpweezPoTfWEfD89R0vW/Rojr60hiX/BAqPiL0CaWB1q0WmVP/WsYDmnH3oU83la3i/ss h1mLED9x+wsSwJQr0JccKP3ZF9p41+SJa1aNmsXNgspYvSUMsqBZG/8SOrS89edbHzzd5/OxZ NEorrtGdKE9V12OktZTdC2+NTP+mh21mlO4G/Ahnm8HDc= =E2=80=A6 > Check the return value of amd_smn_read() before saving a value. > This ensures invalid values aren't saved. =E2=80=A6 Does such information indicate a need for the tag =E2=80=9CFixes=E2=80=9D? Regards, Markus