Received: by 2002:a89:d88:0:b0:1fa:5c73:8e2d with SMTP id eb8csp1113967lqb; Sat, 25 May 2024 06:32:43 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWmlEnmFCV1kvKoXuIXW8TMM+I0fRqFxTpDBPZ1DV7sVaDytCPTsN6nhmW2VFCtmGqxDXVr+Prx6xoYcd0kSKllW2BIiS1yIoYZXW0HUQ== X-Google-Smtp-Source: AGHT+IEuQkjOtG/lsWAVvXEkFmdt+21GNMp8wJBFJXmXvXI9ZcsWgFt1EY7G3/IIDjJYFollPix7 X-Received: by 2002:a05:6512:34c2:b0:51d:d630:365c with SMTP id 2adb3069b0e04-52965290455mr3269277e87.4.1716643963499; Sat, 25 May 2024 06:32:43 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716643963; cv=pass; d=google.com; s=arc-20160816; b=hSvxZ5E9OF5aBERWS2L8N5uj6Ab7bAEAs0tpW1EZhVg6w1rBWBRaTZSDpaVZA+eRZZ +zkxPdYx+d+G8/lbAvsDMTD8NkBAhmRHkDn+rY8XgYh0XXrM6/Y2kUrzWMlnmIBt1dxq GNKT4LXOak1CPrfPoCG6uxYjLRv8+czCyKzTJXFP3AQMpnzUAuKvf+t33QohbjsOvdTb ck9xQNZlgTs6D/g4zlx0kLpufGOZhDc73no1qfnYtO4v4UaHAM7Wnrv7E2wFnGSG3Uo5 c2pck2v3rpMdaWJO58iCdIAr8qxWGkpluvvo+8MO3r7/RZW7sfLMgxg8dNEK2kJSPNF7 D2kQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:in-reply-to:from :content-language:subject:references:cc:to:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=JP4di3yKoXAyHQTDL4MSNwnDqzZtn247np5kkTP3B5E=; fh=izmVUZQpiK+80/eieYGEm5TQ39rHbuCjElZthX1ykME=; b=QT/t7qUB2XwXEesVR3NsziDgOcRBn5xNnowCTebyb2H6qF0qOW05G8fy6H+5h4zxfy NJf/4Tjk+Z6FIgznIT5hbFdiOB65juBnlO2/qmweOx2MxDvlCWq5WDlbdGJ01ygK76oM DJQFwKceXahWFR2n8OIYaTjDAFtCDdgKkU+1iBOiInjVUCxVEymtHI11O3P1FEgU1IF5 yNKyPF+olrTX/IGDkSER+WTyM06s5U+m8jR6IYkwMCfHVnb4l0JvJ+58prc0Krtr+RBZ UIKbqlmxta6pSa9/FZAbMXYeRvlxLnmMh3OifxsqQaS/4m4D3GnXk8fNpv2RvA4zDcIf UibQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b="YH8FdB/l"; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-189366-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-189366-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id a640c23a62f3a-a6286b26436si130216466b.668.2024.05.25.06.32.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 May 2024 06:32:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-189366-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b="YH8FdB/l"; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-189366-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-189366-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 3359D1F21736 for ; Sat, 25 May 2024 13:32:43 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8CE584DA13; Sat, 25 May 2024 13:32:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="YH8FdB/l" Received: from mout.web.de (mout.web.de [212.227.15.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A91C3B297; Sat, 25 May 2024 13:32:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.15.3 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716643953; cv=none; b=A+QvJqQctuT9CX4LDWYDIt9hlOGuFz+oCbqaEM5MxfCuLeopHhrLd96W3weoj+tidauE5Fpv3Wiv7KiV8QrL5lT0LRtLWI5QOjKslcNjUMSYoeWA3OCk4a/7cwUooy5RfXaz3Dl+vcMoMAyuEGVMZxdn0JY7h8cqzGzbwPv2BTU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716643953; c=relaxed/simple; bh=JP4di3yKoXAyHQTDL4MSNwnDqzZtn247np5kkTP3B5E=; h=Message-ID:Date:MIME-Version:To:Cc:References:Subject:From: In-Reply-To:Content-Type; b=C77+G/ri+RrTzQxh3lIcnI/JsToaFhfoPBlLFo3Jm2RSbOOeI1xXOHPsG9t61XPCCY90sFg5wI4VnY4G3Kie+Ut2BzS63Pp1XQVE03UCmsuKINTODR3bYWH+syV+/CNPwaVvUg5W6I5Bjen1UZwb47KBwlxQfbSU7XHcfJeqH/I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=YH8FdB/l; arc=none smtp.client-ip=212.227.15.3 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1716643928; x=1717248728; i=markus.elfring@web.de; bh=JP4di3yKoXAyHQTDL4MSNwnDqzZtn247np5kkTP3B5E=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:To:Cc:References: Subject:From:In-Reply-To:Content-Type:Content-Transfer-Encoding: cc:content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=YH8FdB/lUS36NPdYcOmahpPmRDpyYvatL4dKxuwsGKOlL+rnVWvxwupeaj57IaG4 RIJN8bCtxZhhMswv90aLMHq2KRVa7o47Z/+ObN0uYRFFHCRMNyQti0ll8EUPytuc8 qvlAjYNmDMH2fAOlmu7TIPBDDJ07ziq/itLCVCryWCqHfq/+kUHD/y4yBT5YYe/ld hsyc7iwvry4f5XD1TJCgw3gAYP0gOrFpcqa/1BeljMURfMob0w8g77NoLz8bA3qiq EfqgmOYE2NW0ti14zHrZ4+z7G4pLb9tX6CkglA6Qgs8E4nmE6ouhDro5ZQqueofo3 JLxSqNsFzizHDEqAvg== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.83.95]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1M28SL-1sCmNV1jp3-002daF; Sat, 25 May 2024 15:32:08 +0200 Message-ID: <8e3cc13d-c2d0-46f9-82f1-67849c6add91@web.de> Date: Sat, 25 May 2024 15:32:07 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Yazen Ghannam , linux-edac@vger.kernel.org, linux-hwmon@vger.kernel.org, kernel-janitors@vger.kernel.org, x86@kernel.org, =?UTF-8?B?R8O8bnRlciBSw7Zjaw==?= Cc: LKML , Mario Limonciello References: <20240523-fix-smn-bad-read-v3-3-aa44c622de39@amd.com> Subject: Re: [PATCH v3 3/8] hwmon: (k10temp) Check return value of amd_smn_read() Content-Language: en-GB From: Markus Elfring In-Reply-To: <20240523-fix-smn-bad-read-v3-3-aa44c622de39@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:UMwIlxbVxCxbl6+EBLJ18Kg/xiTYPFfku5uWGn/ab5Gh1o0V2uk a6QK2TsSiLBT9oGRgqxWMsTpKCR5MfSOYsYfHYKG2brGF4H+sqVvoUh1zFYoiAhS3z2nZaX O0veVbiNYcuWCaQT5Q+7RS33eXHU0hDr4P+mRGmg6bJ/8JefgHGUTWpHBX5P0kZw0CtlIHo /jVZ4rSp4bjzbJzSBHLtw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:yDbl8Q/FwLo=;Pl32SA/RLxsVM2tVdUy05gy+8cL rLcmEhxZMpBifK3RveJ+MiJzAeerd83AYXJnK/y3W+kH1Iu00/36xZqkwFl+oybiDUBj40rrD /VNPazUX3dLgkHqU+hch8zCVGwH4EAnEIWNKC8iJBvlriYmJsN8XOvSG27/YWilxcmaBPSIUw 1OlVdI6DIRAgt56d5kMp7GFQPSabCA+WjZLS72uRqrE5QhSCR3jiFlBM0Jj+1zBcEpdvdNGIF y0VAEd/oVHsJYoPqLiQfjRbChs1ozd7hlR3BzDYQAygHs9Zi/dQajClIF23el1qWm0psnBT4A hvVxiENowIZnLSV/rDFPAYcNe1lHgFIWAnXI9tFjgoEjtOQ0ky2iqSAOoK3czuLpyY6VWkSjH hKIExLNaaG2/DntEBjz8imfSGkt6AqDXtLhBVFLd/vhDibUEFr0GjUSQcuQYXmNKk18nugJ7I Pk21v8Ir68cAFjbwV649aZfbgYIA6dYMWrecsSspBrm6dhQeuokLN3yttFDcXud0upQRaxyij +0Z1idxC4ilmUFduxKqlqM0u88ecj0vMXNLX/QbA5RhmydBGOvSoP+WsUklu1cVma7TdeBxg8 wvMU1moMn1/Xbj13kEKn7MaHpXOhyw1f6jnExU5T37AHdwlhrVT8x8hLIs8EjjJBPurTVLzFP rp+cJljGoIO8qk+gP1MCtj0pSSctuekSBWQ7cgM4W1pUOFwjKqn+IuZA3hkPD6OI20etXZfMu JMJ8GQrmqh8foxzSBSRli769Z/1m8q4udZ9CJ712ykVAoO29mYI6qH2T9uXxVUtSze4XAv3O0 RBfKD4ZK6J9qfF6nG7uZNn3uzeYhQOpo4Fxsm43EXrHBw= > Check the return value of amd_smn_read() before saving a value. > This ensures invalid values aren't saved or used. =E2=80=A6 Does such information indicate a need for the tag =E2=80=9CFixes=E2=80=9D = once more? Regards, Markus