Received-SPF: pass (google.com: domain of linux-kernel+bounces-189369-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240525063653.2331587-1-shichaorai@gmail.com> <503256e5-fea7-42ab-af15-015b0f78ab33@rowland.harvard.edu>
In-Reply-To: <503256e5-fea7-42ab-af15-015b0f78ab33@rowland.harvard.edu>
From: shichao lai <shichaorai@gmail.com>
Date: Sat, 25 May 2024 21:46:44 +0800
Message-ID: <CACjpba7uNtPPDAh+mkHc5fU2vzTGiTWkkS9WOqkPZ5sXQXZPGg@mail.gmail.com>
Subject: Re: [PATCH v4] usb-storage: Check whether the media is initialized successfully
To: Alan Stern <stern@rowland.harvard.edu>, gregkh@linuxfoundation.org, oneukum@suse.com
Cc: linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, 
	linux-kernel@vger.kernel.org, xingwei lee <xrivendell7@gmail.com>, 
	yue sun <samsun1006219@gmail.com>
Content-Type: text/plain; charset="UTF-8"

> Oliver did not suggest that the patch be written this way.
>
> Now with the patch written out, I think a better name for this variable
> would be media_initialized.  That is a better description of what it
> means (it doesn't mean that the driver or the device is initialized).
> And then you could remove the comment, because it would be obvious.
>
> You don't need to do this.  The info pointer is an alias for us->extra,
> which is allocated by kzalloc(), which clears all the memory it
> allocates to zero.
>
> Alan Stern

Thanks for your patient feedback!
I will rewrite the patch soon.