Received-SPF: pass (google.com: domain of linux-kernel+bounces-189431-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Sat, 25 May 2024 11:51:34 -0400
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Chengen Du <chengen.du@canonical.com>, 
 Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: davem@davemloft.net, 
 edumazet@google.com, 
 kuba@kernel.org, 
 pabeni@redhat.com, 
 netdev@vger.kernel.org, 
 linux-kernel@vger.kernel.org, 
 alexandre.ferrieux@orange.com
Message-ID: <66520906120ae_215a8029466@willemb.c.googlers.com.notmuch>
In-Reply-To: <CAPza5qc+m6aK0hOn8m1OxnmNVibJQn-VFXBAnjrca+UrcmEW4g@mail.gmail.com>
References: <20240520070348.26725-1-chengen.du@canonical.com>
 <664f5938d2bef_1b5d2429467@willemb.c.googlers.com.notmuch>
 <CAPza5qc+m6aK0hOn8m1OxnmNVibJQn-VFXBAnjrca+UrcmEW4g@mail.gmail.com>
Subject: Re: [PATCH] af_packet: Handle outgoing VLAN packets without hardware
 offloading
Precedence: bulk
Mime-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: 7bit

> Firstly, I will submit a patch to add a new bit in the status to
> indicate the presence of VLAN information in the payload and modify
> the header's entry accordingly.
> A new member will be added to the sockaddr_ll struct to represent the
> VLAN-encapsulated protocol, thus avoiding direct modification of the
> sll_protocol.

See my earlier comments to your v1 patch. It's a minor respin. Please
don't add new members.

> Following this patch, I will work on enabling the link layer header
> via a socket option.

Let's focus on the VLAN for now.

Any expansion of the ABI requires a very clear path to use. I'd like
to see the pcap and tcpdump (or wireshark) changes that use it.

First, we need to even understand better why anything is using
SOCK_DGRAM when access to L2.5 headers is important, and whether the
process can convert to using SOCK_RAW instead.