Received-SPF: pass (google.com: domain of linux-kernel+bounces-189464-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Sat, 25 May 2024 18:17:30 +0100
From: Jonathan Cameron <jic23@kernel.org>
To: Kim Seer Paller <kimseer.paller@analog.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-iio@vger.kernel.org>,
 <devicetree@vger.kernel.org>, David Lechner <dlechner@baylibre.com>,
 Lars-Peter Clausen <lars@metafoo.de>, Liam Girdwood <lgirdwood@gmail.com>,
 Mark Brown <broonie@kernel.org>, Dimitri Fedrau <dima.fedrau@gmail.com>,
 Krzysztof Kozlowski <krzk+dt@kernel.org>, "Rob Herring" <robh@kernel.org>,
 Conor Dooley <conor+dt@kernel.org>, "Michael Hennerich"
 <michael.hennerich@analog.com>, Nuno =?UTF-8?B?U8Oh?=
 <noname.nuno@gmail.com>
Subject: Re: [PATCH v2 3/5] dt-bindings: iio: dac: Add adi,ltc2664.yaml
Message-ID: <20240525181730.6cccec73@jic23-huawei>
In-Reply-To: <20240523031909.19427-4-kimseer.paller@analog.com>
References: <20240523031909.19427-1-kimseer.paller@analog.com>
	<20240523031909.19427-4-kimseer.paller@analog.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit


A few comments inline.

> +  adi,manual-span-operation-config:
> +    description:
> +      This property must mimic the MSPAN pin configurations. By tying the MSPAN
> +      pins (MSP2, MSP1 and MSP0) to GND and/or VCC, any output range can be
> +      hardware-configured with different mid-scale or zero-scale reset options.
> +      The hardware configuration is latched during power on reset for proper
> +      operation.
> +        0 - MPS2=GND, MPS1=GND, MSP0=GND
> +        1 - MPS2=GND, MPS1=GND, MSP0=VCC
> +        2 - MPS2=GND, MPS1=VCC, MSP0=GND
> +        3 - MPS2=GND, MPS1=VCC, MSP0=VCC
> +        4 - MPS2=VCC, MPS1=GND, MSP0=GND
> +        5 - MPS2=VCC, MPS1=GND, MSP0=VCC
> +        6 - MPS2=VCC, MPS1=VCC, MSP0=GND
> +        7 - MPS2=VCC, MPS1=VCC, MSP0=VCC (enables SoftSpan feature)
Could you add to the description to say what results of the entries are
(like you have done for 7)
e.g.
          0 - MSP2=GND, MPS1=GND, MSP0=GND (+-10V, reset to 0V)
at least I think that's what reset to mid scale means.

This seems like a reasonable level of information to convey here.

I was going to suggest making this a 3 value array, but that would
make ti hard to add such docs, so perhaps what you have here
is the right approach.


> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    enum: [0, 1, 2, 3, 4, 5, 6, 7]
> +    default: 7
> +
> +  io-channels:
> +    description:
> +      Analog multiplexer output. VOUT0-VOUT3, MUXIN0-MUXIN3, REFLO, REF, V+, V-,
> +      and a temperature monitor output can be internally routed to the MUXOUT pin.
> +
That's a little confusing.   What you are specifying here is the ADC
channels that is connected to. This description sort of suggests it's about
what is routed there.