Received: by 2002:a89:d88:0:b0:1fa:5c73:8e2d with SMTP id eb8csp1408715lqb; Sat, 25 May 2024 22:43:41 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW22iuD/39KRsWzcRQkGzkCPe8ynnrv/zDxEH7oIU4o1K3apWJTOt2/+hDnz6rhnXILkBP72USfN1Yizcb10wHdAt2RADItDkuRnHzDjw== X-Google-Smtp-Source: AGHT+IGHfsVEiAVZJVvXY97UGOajdgpmOLDCuHxTFftSapdIc/pNxxj/wWh/LXmz1uqVdZPjthF/ X-Received: by 2002:a50:9ea4:0:b0:578:5f53:f017 with SMTP id 4fb4d7f45d1cf-5785f53f2c5mr3549670a12.6.1716702221623; Sat, 25 May 2024 22:43:41 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716702221; cv=pass; d=google.com; s=arc-20160816; b=RMBXK7cM7NrUeso5UhT4AiVBFj/ZaPUlRkxarc8d/3X6ifEhzXI7UXfz/SdvpZSeeM uKeERNA7tSdezjAds0GwbNsmvsG3aL9i51FqkqXTw9o4WbO++Fnb6DssnE4SJ/tM5trd e20nW2Fz9+XV7JokHSdq39QJ147Z/PuDfczZnsoGl+MvO+ie2QmUZkTdg6Y/AyCtRfip 65uL/4ZGEGrwf3gYvI8owvExVq2GB3NKwRMhk7PmPoRHqEqJ3BKUHNWqVLS/e5qrg7ZM y6NbFXNpn5A0chUrwUwXlrTSmbZQUj7oF+fwCV5VWbb4DMv+2YO2VUjBMwBksH1ix7eh twZQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id; bh=OPMX6x8YbfjqFbkc4RVAg4/SxYD0td8ZmS8MKp33A+8=; fh=ElqLdLOhFCDyhN/pUZMYTb7nk1AjyVC1ttmnp8ED2EI=; b=k4yASNKNMbK+PYE7IahVqRMKqFuYJCQogV0pwj9KdAV48mRAaUkMrxRLnpCgAvrft5 2HRLndV9vQmcUV7hpEzPdFC4jCLkin+zwecZvjpLaCCL+VVs8aIr83a1DvWVQOwbe13s RKbj2nBGTX9vN4TeO3AEDVrBjG2r//BZRwrYs2sEdN8h25xL4TJqNajKRKfxXpMarHIG 0S9LIWulQXXi0UEw5tGAfPgf8LLlR8zqxRPkqV+RVAtqBgQSq0FeWmcHhnK438/ckIPG l7pp8BJwyVXg8TeJuqMXGuZzO3zgxUXyopDnp1QKojEbJA7jIQwExjbfQGjhZdmcI61K nJMg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=molgen.mpg.de); spf=pass (google.com: domain of linux-kernel+bounces-189592-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-189592-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-579c8c29f81si480330a12.383.2024.05.25.22.43.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 May 2024 22:43:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-189592-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=molgen.mpg.de); spf=pass (google.com: domain of linux-kernel+bounces-189592-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-189592-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 5E35D1F2121C for ; Sun, 26 May 2024 05:43:41 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D163E4C6B; Sun, 26 May 2024 05:43:33 +0000 (UTC) Received: from mx3.molgen.mpg.de (mx3.molgen.mpg.de [141.14.17.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79E2F1849; Sun, 26 May 2024 05:43:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=141.14.17.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716702213; cv=none; b=pBp6e1FWV2TVRWYdBV6RFShqRxvlwgZLAZac7sM8Y4ForSiYeFTPkyi2K/a6ikPNBRpXJJJIdLZWyZT+TTnC7XmVCLk44XHqIZJAhrBk7/RQPXTFLl0/1jBzZM+LEQd5bBDXa0OmXDS3gThOHa3nXeEvghWSTsBb1Ml7S25na/g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716702213; c=relaxed/simple; bh=OPMX6x8YbfjqFbkc4RVAg4/SxYD0td8ZmS8MKp33A+8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QUl5+ZI1U9H9WfCdNiraNGS/iTM48MpE/OmYaoHlW9ydThZ27E6UMbSbEXIYuzuSZQ17Ea+es3SLp6nqYQf7RNj8J+haaMzaiH+H4IVTc5eThczkAaiDVNAEARHpcGpai4K3lVFRLGbckggBIdZJ8bRfrcVx4QLMonBlOpuah9M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=molgen.mpg.de; spf=pass smtp.mailfrom=molgen.mpg.de; arc=none smtp.client-ip=141.14.17.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=molgen.mpg.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=molgen.mpg.de Received: from [192.168.0.3] (ip5f5af45c.dynamic.kabel-deutschland.de [95.90.244.92]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: pmenzel) by mx.molgen.mpg.de (Postfix) with ESMTPSA id 97A2761E5FE3D; Sun, 26 May 2024 07:42:30 +0200 (CEST) Message-ID: <17bbe39e-3c68-4e0b-9862-9658f684b19e@molgen.mpg.de> Date: Sun, 26 May 2024 07:42:29 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] tpm: Open code tpm_buf_parameters() To: Jarkko Sakkinen Cc: linux-integrity@vger.kernel.org, keyrings@vger.kernel.org, James.Bottomley@HansenPartnership.com, Peter Huewe , Jason Gunthorpe , Mimi Zohar , David Howells , Paul Moore , James Morris , "Serge E. Hallyn" , Stefan Berger , Ard Biesheuvel , Mario Limonciello , linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org References: <20240525154406.4811-1-jarkko@kernel.org> Content-Language: en-US From: Paul Menzel In-Reply-To: <20240525154406.4811-1-jarkko@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Dear Jarkko, Thank you for your patch. Am 25.05.24 um 17:44 schrieb Jarkko Sakkinen: > With only single call site, this no sense, and it actually slipped out this *makes* no sense? > of the radar during the review. Open code and document the action > directly to the site, to make it more readable. […] Kind regards, Paul