Received-SPF: pass (google.com: domain of linux-kernel+bounces-189640-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Sun, 26 May 2024 12:27:01 +0300
From: Leon Romanovsky <leon@kernel.org>
To: Greg Sword <gregsword0@gmail.com>
Cc: Haakon Bugge <haakon.bugge@oracle.com>,
	Zhu Yanjun <zyjzyj2000@gmail.com>,
	OFED mailing list <linux-rdma@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	netdev <netdev@vger.kernel.org>,
	"rds-devel@oss.oracle.com" <rds-devel@oss.oracle.com>,
	Jason Gunthorpe <jgg@ziepe.ca>, Saeed Mahameed <saeedm@nvidia.com>,
	Tariq Toukan <tariqt@nvidia.com>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Tejun Heo <tj@kernel.org>, Lai Jiangshan <jiangshanlai@gmail.com>,
	Allison Henderson <allison.henderson@oracle.com>,
	Manjunath Patil <manjunath.b.patil@oracle.com>,
	Mark Zhang <markzhang@nvidia.com>,
	Chuck Lever III <chuck.lever@oracle.com>,
	Shiraz Saleem <shiraz.saleem@intel.com>,
	Yang Li <yang.lee@linux.alibaba.com>
Subject: Re: [PATCH v2 3/6] RDMA/cma: Brute force GFP_NOIO
Message-ID: <20240526092701.GA96190@unreal>
References: <20240515125342.1069999-1-haakon.bugge@oracle.com>
 <20240515125342.1069999-4-haakon.bugge@oracle.com>
 <82bf9e5f-b798-4d29-8473-c074a34f15b0@linux.dev>
 <236B9732-8264-454C-94BF-7C9D491D3A37@oracle.com>
 <CAEz=Lcvbc3O+PtDSLvGAgd5fmps8j69DDn+Mgm8UWMFMNSd8WA@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAEz=Lcvbc3O+PtDSLvGAgd5fmps8j69DDn+Mgm8UWMFMNSd8WA@mail.gmail.com>

On Fri, May 17, 2024 at 03:07:34AM +0800, Greg Sword wrote:
> On Thu, May 16, 2024 at 11:54 PM Haakon Bugge <haakon.bugge@oracle.com> wrote:
> >
> > Hi Yanjun,
> >
> >
> > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/maintainer-netdev.rst?h=v6.9#n376
> > >
> > > "
> > > Netdev has a convention for ordering local variables in functions.
> > > Order the variable declaration lines longest to shortest, e.g.::
> >
> > "Infiniband subsystem" != netdev, right?
> 
> All kernel subsystems should follow this rule, including the network
> and rdma subsystems

Of course not. The request to sort variables is netdev coding style,
rest of the kernel doesn't have this rule and doesn't care about it.

In Infiniband, we accept both styles, just to make sure that people who
submit their patches to both subsystems won't need to bother themselves
with this.

Thanks

> 
> >
> >
> > Thxs, Håkon
> >