Received-SPF: pass (google.com: domain of linux-kernel+bounces-189734-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Sun, 26 May 2024 13:24:22 +0100
From: Jonathan Cameron <jic23@kernel.org>
To: Denis Benato <benato.denis96@gmail.com>
Cc: Jagath Jog J <jagathjog1996@gmail.com>, Lars-Peter Clausen
 <lars@metafoo.de>, "Luke D . Jones" <luke@ljones.dev>, Jonathan LoBue
 <jlobue10@gmail.com>, linux-iio@vger.kernel.org,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] iio: imu: bmi323: Use iio read_acpi_mount_matrix()
 helper
Message-ID: <20240526132422.01d3855b@jic23-huawei>
In-Reply-To: <20240523174736.16692-2-benato.denis96@gmail.com>
References: <20240523174736.16692-1-benato.denis96@gmail.com>
	<20240523174736.16692-2-benato.denis96@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 23 May 2024 19:47:36 +0200
Denis Benato <benato.denis96@gmail.com> wrote:

> bmi150-accel and bmi323-imu are declared in an almost identical way in the ACPI and in some devices such as the Asus RC71L the "ROTM" property can be found: parse and use the ACPI-defined mount-matrix.
> 
> Co-developed-by: Luke D. Jones <luke@ljones.dev>
> Co-developed-by: Jonathan LoBue <jlobue10@gmail.com>
> Signed-off-by: Denis Benato <benato.denis96@gmail.com>
Applied.

Thanks,

Jonathan

> ---
>  drivers/iio/imu/bmi323/bmi323_core.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/imu/bmi323/bmi323_core.c b/drivers/iio/imu/bmi323/bmi323_core.c
> index 5d42ab9b176a..b391e5e701b1 100644
> --- a/drivers/iio/imu/bmi323/bmi323_core.c
> +++ b/drivers/iio/imu/bmi323/bmi323_core.c
> @@ -2083,9 +2083,11 @@ int bmi323_core_probe(struct device *dev)
>  	if (ret)
>  		return -EINVAL;
>  
> -	ret = iio_read_mount_matrix(dev, &data->orientation);
> -	if (ret)
> -		return ret;
> +	if (!iio_read_acpi_mount_matrix(dev, &data->orientation, "ROTM")) {
> +		ret = iio_read_mount_matrix(dev, &data->orientation);
> +		if (ret)
> +			return ret;
> +	}
>  
>  	indio_dev->name = "bmi323-imu";
>  	indio_dev->info = &bmi323_info;