Received-SPF: pass (google.com: domain of linux-kernel+bounces-189737-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Sun, 26 May 2024 13:43:44 +0100
From: Jonathan Cameron <jic23@kernel.org>
To: Nuno =?UTF-8?B?U8Oh?= <noname.nuno@gmail.com>
Cc: Ramona Gradinariu <ramona.bolboaca13@gmail.com>,
 linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
 devicetree@vger.kernel.org, conor+dt@kernel.org,
 krzysztof.kozlowski+dt@linaro.org, robh@kernel.org, nuno.sa@analog.com
Subject: Re: [PATCH v4 08/10] iio: imu: adis16475: Re-define ADIS16475_DATA
Message-ID: <20240526134344.6675ab5c@jic23-huawei>
In-Reply-To: <4ccfe084339360695edb5ae774a3bc67b1781c95.camel@gmail.com>
References: <20240524090030.336427-1-ramona.bolboaca13@gmail.com>
	<20240524090030.336427-9-ramona.bolboaca13@gmail.com>
	<4ccfe084339360695edb5ae774a3bc67b1781c95.camel@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Fri, 24 May 2024 12:47:38 +0200
Nuno S=C3=A1 <noname.nuno@gmail.com> wrote:

> On Fri, 2024-05-24 at 12:00 +0300, Ramona Gradinariu wrote:
> > Re-define ADIS16475_DATA such that it takes _has_fifo as parameter.
> >=20
> > Signed-off-by: Ramona Gradinariu <ramona.bolboaca13@gmail.com>
> > --- =20
>=20
> I may be missing something but do we actually need to patches redefining =
the macro?
> If I'm not missing nothing the first patch is only relevant for the new A=
DIS devices
> which are added in patch 10. So maybe squash both patches changing the ma=
cro.
>=20
> - Nuno S=C3=A1
>=20
If that's not possible for some reason, give them both slightly more detail=
ed
patch titles. It's confusing to have them identical!
=20
I'd prefer them squashed as Nuno suggested.