Received-SPF: pass (google.com: domain of linux-kernel+bounces-189740-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Sun, 26 May 2024 13:48:58 +0100
From: Jonathan Cameron <jic23@kernel.org>
To: Nuno =?UTF-8?B?U8Oh?= <noname.nuno@gmail.com>
Cc: Ramona Gradinariu <ramona.bolboaca13@gmail.com>,
 linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
 devicetree@vger.kernel.org, conor+dt@kernel.org,
 krzysztof.kozlowski+dt@linaro.org, robh@kernel.org, nuno.sa@analog.com
Subject: Re: [PATCH v4 10/10] drivers: iio: imu: Add support for adis1657x
 family
Message-ID: <20240526134858.636d2c8f@jic23-huawei>
In-Reply-To: <bdc88590fe3e54326c1edbe6f2b4ac2d8f453df4.camel@gmail.com>
References: <20240524090329.340810-1-ramona.bolboaca13@gmail.com>
	<bdc88590fe3e54326c1edbe6f2b4ac2d8f453df4.camel@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable


> > @@ -1500,7 +1973,10 @@ static int adis16475_probe(struct spi_device *sp=
i)
> > =C2=A0	indio_dev->name =3D st->info->name;
> > =C2=A0	indio_dev->channels =3D st->info->channels;
> > =C2=A0	indio_dev->num_channels =3D st->info->num_channels;
> > -	indio_dev->info =3D &adis16475_info;
> > +	if (st->adis.data->has_fifo)
> > +		indio_dev->info =3D &adis16575_info;
> > +	else
> > +		indio_dev->info =3D &adis16475_info;
> > =C2=A0	indio_dev->modes =3D INDIO_DIRECT_MODE;
> >=20
> > =C2=A0	ret =3D __adis_initial_startup(&st->adis);
> > @@ -1515,10 +1991,25 @@ static int adis16475_probe(struct spi_device *s=
pi)
> > =C2=A0	if (ret)
> > =C2=A0		return ret;
> >=20
> > -	ret =3D devm_adis_setup_buffer_and_trigger(&st->adis, indio_dev,
> > -						 adis16475_trigger_handler);
> > -	if (ret)
> > -		return ret;
> > +	if (st->adis.data->has_fifo) {
> > +		ret =3D devm_adis_setup_buffer_and_trigger_with_attrs(&st->adis,
> > indio_dev,
> > +								=C2=A0=C2=A0=C2=A0
> > adis16475_trigger_handler_with_fifo,
> > +								=C2=A0=C2=A0=C2=A0
> > &adis16475_buffer_ops,
> > +								=C2=A0=C2=A0=C2=A0
> > adis16475_fifo_attributes);
> > +		if (ret)
> > +			return ret;
> > +
> > +		/* Update overflow behavior to always overwrite the oldest sample.
> > */
> > +		ret =3D adis_update_bits(&st->adis, ADIS16475_REG_FIFO_CTRL,
> > +				=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ADIS16575_OVERFLOW_MASK,
> > (u16)ADIS16575_OVERWRITE_OLDEST); =20
>=20
> Slight preference for local variable to avoid the cast.

Hmm. This is a symptom of adis_update_bits() being 'too clever'.
I'd be tempted to just split that into 16 bit and 32 bit versions but
that is a much larger patch so a local variable is ok if ugly.


>=20
> - Nuno S=C3=A1
>=20
>=20