Received: by 2002:a89:d88:0:b0:1fa:5c73:8e2d with SMTP id eb8csp1577006lqb; Sun, 26 May 2024 07:23:29 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVylKpZ7rmP8OQFG844YZmdYpMyc1V93HmQXzKmMA3BKqI/CRgxYumRztbG5+ko4sbFgqiuCo4m+Z11fHUW7LW3YVZQCLvw5x+h62ucNg== X-Google-Smtp-Source: AGHT+IEzGL98oJAZ9Wv18a8/xPARx8V5v5cXEaFbfXaP3YAnuIqLwXCnOxfjiA/dD/ZhsaEwJCRx X-Received: by 2002:ac8:59cd:0:b0:43a:8248:26f with SMTP id d75a77b69052e-43fb0e74b60mr75566951cf.27.1716733409368; Sun, 26 May 2024 07:23:29 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716733409; cv=pass; d=google.com; s=arc-20160816; b=0RwIgQBZ7iCjE9inU0lG0eCgdlgbf5qCfDj9pgJDAakaM0nIH8kZ4FJAuyu9FePEDH RR2hvDAZihfYb1IoiHKOUgOVcZF5HPtiPj/TDJaaNtnuVE4jDdyZ0WTQF8IUWwx5gYxB xzONAKZQ3aUeEP6E0shN31IpOOYtjN+LPTMAkZ7ckZslT3a1fgETg+HE+pnvXojR6jtA Br8rN6r6f4R3f4tcZKiv/xKTBQOo0RV4InbNzYrFSUuCAh7aVroUU9yTLSlj6xTDAme9 2xgtar2hdExM4JjbZTOCGg7ehGIKJUPshYh5DqTOJIo3vTXIvLEyCYlcIEenouw0wGmh b4hw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:dkim-signature:dkim-signature:date; bh=xnCZ27QyK1irI3tnt2syPDNGF9wfvIINvO/4hdl5qxk=; fh=NjlDC6V+eUkJfTvVNEFSC5PK8BsnfYPiCFmpN2EQ6ZQ=; b=GYbuQPBO7MB4plrOUAP9djU5LjHZNHEpaPIDY1LgS1JqjP4X+ov7/l1ShrH4DQok5C 4fbNz1xsk6lmr0Rn2BfeWqp9JAN/oz4EJFHFKtzGNScN/rrEjF99Ro53JI1Bzn5oGkoK pkpA5TNYPbBPg6VIyzcWReqwTqzodJljQThdBv3BP1It0wkDL4QD8Rktgb9lqcO7UiYN 5nucjmzDMAldNZgM57cITOD+wco2eH3RiVwGVQR/USWE7Q7FREDHF7XRd3odfZqyt3pR RBxqCq9Zy1mc2vNFdQ8esv2kCvnf1jJYdbjR91+VIDy3z8ZMcCa/uKl4Pv/KOgx/Lfdo iqnQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=ZSqgDlld; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; arc=pass (i=1 spf=pass spfdomain=linutronix.de dkim=pass dkdomain=linutronix.de dmarc=pass fromdomain=linutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-189750-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-189750-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id d75a77b69052e-43fb18c7583si61124091cf.645.2024.05.26.07.23.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 May 2024 07:23:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-189750-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=ZSqgDlld; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; arc=pass (i=1 spf=pass spfdomain=linutronix.de dkim=pass dkdomain=linutronix.de dmarc=pass fromdomain=linutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-189750-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-189750-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 1BB781C20AC0 for ; Sun, 26 May 2024 14:23:29 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B49E5171C8; Sun, 26 May 2024 14:23:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="ZSqgDlld"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="5YvxaNoY" Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B70F171B0 for ; Sun, 26 May 2024 14:23:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716733402; cv=none; b=WdvUMXP3HKXoBjMJ0IjzgIMW3fDSvusvEbdbEi9k9I7hGT/eB5e1yn1dZADRHqGMuKEG03hiNNUMBXCAaHuxQRMsc/51etSY9ydhaZRdzDButJ0ZIuD+GShswZGbO7nd4ENHKCI5UyShIUcvVLhkGtN4cRFsPFYWQD9symw1byQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716733402; c=relaxed/simple; bh=0Htsacbl71hMZ/JTxhHysgW2DC0GjMffsquDYGrL/oU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VHj5hPfmZXP7FYDwYYwdCSaP/PhRx1tjY2Qhx/MLcSkwU4izA/MaoNBAtDKA9PiDm/EGIqiYKwWORcP6DLQz7V1P0EPLY1oKmrcXcIX0l6S6CUb8fsGrcZ6GSyv4kWzpWcQFX/sohYgzo2FHE97HdDj6qDO2AX9dFP95Zr9CuFk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=ZSqgDlld; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=5YvxaNoY; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Date: Sun, 26 May 2024 16:23:11 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1716733398; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xnCZ27QyK1irI3tnt2syPDNGF9wfvIINvO/4hdl5qxk=; b=ZSqgDlldMYgaRq0ImxIGO8GhOkh2H5EfzkftWY6MUNgx/osEHiJgmrLdPyY2XcLL3q0byq gtIF3SAPVCnuAzVyF6XHvxa7DJBSjTs9Ku8wI2qQYT7pMDRhj4pY2w180Ah+FcEHvjw8M8 FkgvLgLyTuqrgyLoA+/qRTWTpJkfUDmyvMM5WW7cOj+7Nbj9CRPWFQhAGRgbGr0Xa8ejfj 0EWrRJYXMOjWHB22Hpx8iuGGpkOcyXV9HEZmIT84tKBFwG2eMw5GUvTz3IbovU6jeD+sxZ C5RAhff1jQ1wq06Bw3gGOXCure/kmkbtDO82K4d3zIIppo0ZDig1Z87Qo5S84A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1716733398; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xnCZ27QyK1irI3tnt2syPDNGF9wfvIINvO/4hdl5qxk=; b=5YvxaNoYNyYciKG2s/KkZerhDtblGES6SSQquaBB7zdwzPPajujWBUhNRw36PPQtQqnlp+ WpVW1Ap1UN0yw4Ag== From: Nam Cao To: Michael Straube Cc: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] staging: rtl8192e: reduce indentation level Message-ID: <20240526142311.e1zY6b-Z@linutronix.de> References: <20240526111928.14574-1-straube.linux@gmail.com> <20240526111928.14574-2-straube.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240526111928.14574-2-straube.linux@gmail.com> On Sun, May 26, 2024 at 01:19:26PM +0200, Michael Straube wrote: > Reduce indentation level in _rtl92e_dm_rx_path_sel_byrssi() by negating > if statements and use continue in for loops. This way the indentation > level of the code that is covered by the if checks can be reduced. This > improves readability and clears two checkpatch warnings. > > WARNING: Too many leading tabs - consider code refactoring > > Signed-off-by: Michael Straube I don't see any functional change. This patch does as described: Reviewed-by: Nam Cao Best regards, Nam