Received: by 2002:a89:d88:0:b0:1fa:5c73:8e2d with SMTP id eb8csp1678074lqb; Sun, 26 May 2024 11:48:42 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWmP80ICsPm18z0RLwX3wVc4WdGj/+VQL9LVMAVjzCueugPKy4lwcXuJjjlwc/xxMyWognJN2QaHExlOp0o/5tzaFODCtLSABefcuZYOw== X-Google-Smtp-Source: AGHT+IGs+AxN2u0kuRaz8cfgIUft+VV45o5JGTkkUrgXRFUy+Tvb5tI9FlQ7PFwXe0m3nP8rSxax X-Received: by 2002:a17:90a:c301:b0:2b5:9534:56d6 with SMTP id 98e67ed59e1d1-2bddcf26e97mr12181394a91.24.1716749322206; Sun, 26 May 2024 11:48:42 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716749321; cv=pass; d=google.com; s=arc-20160816; b=O1RcCQBotVgh0N1r8ZGSrL68v7rIQoCL6bM/4aiGBVZBolcBpBc0VXUP3/N6QUoHOp qBZpcH23aZLhqyO0sTJ7SirzwsT2vbm/7Se+7wY7UhnN/vjDynWq9cwTP+/1M7Qu/Ekd 74HHiumZIk2Gfc2w07VcyXLkaHCFfRBpBhlhI6Xoz7BEfxsJo0O4TdcTMub9DSMghxPU V2P1I1zIECzbNEtT/S5jJXPsH9ti0l9cOpO1iEyD3EnEqvPPnlW/3f67y/0bffGG7+YZ 5LT4Ek4XOxgMAp89MRTua/D62zUheiasW3qL5tHQ+1t3XQF9bbSH1hPKg5j31mqGJX3d l2gw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:sender:dkim-signature; bh=8KlyDkDuX+WiAzqsPCy5DCuGhhVymspVkX3ksKKJOrs=; fh=hQSq8Ff7xpPq2a3MgFSY8cjC8Fe/07EWXcHd3UsJ5TI=; b=LXYWislfGBJ9s+VXO/GGSNZb1Izz9gFYHoF9qbpA5xQmHLuFkCW51pVA+aeQw4XQXa 41OWLaldlX+DkkY1bOa0G6N7wiN+zwuj/6xMjSfe0fZD6W5zN1NLAYhj5Fg2xgR+g266 R4f8xXEWYwwxxOKeH8fA5hDxRxCLbzPtH9sXnHJySLbi75FzARTJQLKvf1Oq4Rc/BK1G ODBWXGhGeFyFI79r6ZkG/vphtfC+7LVerBn4cHgDZt8QwoRQdkNhsvgY0HuKS8Wey5Pb 3IgqqH6gsmhD5hjlGu6+Wp2hlLP730LuI4Gxj+jIb8W4Bd3GfdJ3QbrwltNXX+cvbZW9 5pYw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=GP0xJ8qa; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-189844-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-189844-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id 98e67ed59e1d1-2bf5fccc19dsi4855069a91.41.2024.05.26.11.48.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 May 2024 11:48:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-189844-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=GP0xJ8qa; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-189844-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-189844-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 12718280D1F for ; Sun, 26 May 2024 18:48:41 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4E7CB54FAF; Sun, 26 May 2024 18:48:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GP0xJ8qa" Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43E071A2C21; Sun, 26 May 2024 18:48:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716749312; cv=none; b=XmrDyufATzW/MCDt3Gs+d5Wz9ZmQ/SwWaPjt5U1mVU2wLvTyCJRrfe8BjyGc1frcTS0R5iLQBt0WTJFMZHqJhhUkribs+gToz/Cwez3ec5pyB3wM7KtGRDe1lDj5EywjeGGKYYvaFstzoy8V4AHQA8YPf1bBvxJeGYJMsmOFnDo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716749312; c=relaxed/simple; bh=TF/UNXQWWdLsWt90+jGYm/owjZhwkxqzfJ5ba/MKRQ0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tj25GlVHbHAxKQfaP9ITFTbxdznzasda0zhLw8EEYX/2Al8lP0d5sWk9ZwERi7wv6fH8tju4FPDeeg3h2u9fu1eO3onhZ8bjfbaxM1VH06LoWjPfw/Es11X7STNnAzDyxC40mzbphFjEAkpekXT8EXxYWfsWlh1I2Y+tlGHBG0Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GP0xJ8qa; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-2bf5ee192b1so1530207a91.1; Sun, 26 May 2024 11:48:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716749310; x=1717354110; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=8KlyDkDuX+WiAzqsPCy5DCuGhhVymspVkX3ksKKJOrs=; b=GP0xJ8qa12yXGcvfo2W94GBlHDZnK6VxEjYSCzRk+um7T/dGqrN6+kMihxkLa9TdRn VasVsCiFFhmg0DI+VlYrrjhi/2bKoipIu6YC/JbQCLrv8SWmzyPMYJQQZWH0KqyMbjQn cjGhqbfxQoKAriHLcpp67g/1Ssyodl6YjSnR9yNBfoG5mPGobS7rF9R7nJJrS09jwGWX eEDedwyHfosGDC5LwtJV2+4yPj0TygsQYDMC02qenvwFvgPOETwx/z9nzyDQooRYdDC1 fln2ix7sn5y5CcWT+ni67HyV1xqI/pSX2zCRC3cr6DIZMyvksTYFkgRpxvxH+FalWCn4 0DLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716749310; x=1717354110; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8KlyDkDuX+WiAzqsPCy5DCuGhhVymspVkX3ksKKJOrs=; b=t0SkrVCNPFNolz6alcRAK4vhV+o8G0Q5y0jD7NUTLIAicm1jysE4Yw0xa1pYoY0cW3 QsnBrPzzeifEppcMR/7F4ZSsIOK1GqgCPIWtoQdCBkP/rMkXZ06kvwvyZhgalNDs/vWJ Ir8fHCgdyRJCWtaIpds4Un5Kx503uIDCya3Rj3SGI/a+LWeaJsJh77J8PVO59KCq0hCI mBPAgZ+919eqkULSFDyIsqpxqG/4GFX+0IMiOYiiJdbB/jMOD5enXYsZy9Tz4yCaTefO iQA7A89dY6/iwtsmuIuVzUA+eOJPXgQ9AXschnDbG62Qkz74nTJAvUK1CiwWVtoh91n/ 7tvg== X-Forwarded-Encrypted: i=1; AJvYcCXRnENPcAgDYmyWUQi9zC2brkAU29b5ji7rYwYpMcAWiBH+ewZ7HD1SZZteXatsd+c1ZM2TcRc+5L1NLx/NKmqzwHXVvexr6oHeJFIbmMDKxvN30o0bsnNu39YeeQ79qaEar/3KhQ== X-Gm-Message-State: AOJu0YzsnFkhkzTwYsFhwwmD2T1cr6WDsGjYLBkcJLlrWjrqJhF4/iZT ztBVf5oePWrPxB256qrD7vMl/VxX3RhSffuo1N+FCZF2Y3DsKrQE7QLncw== X-Received: by 2002:a17:90a:ea95:b0:2bd:fe71:14f3 with SMTP id 98e67ed59e1d1-2bdfe71201cmr11297706a91.22.1716749310507; Sun, 26 May 2024 11:48:30 -0700 (PDT) Received: from localhost (dhcp-141-239-159-203.hawaiiantel.net. [141.239.159.203]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2bdf7533fc6sm3804276a91.0.2024.05.26.11.48.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 May 2024 11:48:30 -0700 (PDT) Sender: Tejun Heo Date: Sun, 26 May 2024 08:48:28 -1000 From: Tejun Heo To: David Wang <00107082@163.com> Cc: lizefan.x@bytedance.com, hannes@cmpxchg.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] kernel/cgroup: cleanup cgroup_base_files when fail to add cgroup_psi_files Message-ID: References: <20240517062405.115253-1-00107082@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240517062405.115253-1-00107082@163.com> On Fri, May 17, 2024 at 02:24:05PM +0800, David Wang wrote: > Even though css_clear_dir would be called to cleanup > all existing cgroup files when css_populate_dir failed, > reclaiming newly created cgroup files before > css_populate_dir returns with failure makes code more > consistent. > > Signed-off-by: David Wang <00107082@163.com> Applied to cgroup/for-6.11. Thanks. -- tejun