Received-SPF: pass (google.com: domain of linux-kernel+bounces-189877-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Sun, 26 May 2024 23:24:40 +0200
From: "Steinar H. Gunderson" <sesse@google.com>
To: acme@kernel.org
Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	irogers@google.com
Subject: Re: [PATCH v7 4/4] perf report: LLVM-based symbol listing
Message-ID: <ZlOomG5NacWlV_RY@google.com>
References: <20240526182212.544525-1-sesse@google.com>
 <20240526182212.544525-4-sesse@google.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240526182212.544525-4-sesse@google.com>

On Sun, May 26, 2024 at 08:22:12PM +0200, Steinar H. Gunderson wrote:
> +
> +	symbols__fixup_end(dso__symbols(dso), false);
> +	symbols__fixup_duplicate(dso__symbols(dso));
> +	dso__set_adjust_symbols(dso, true);
> +	ret = 0;

Urgh, evidently I forgot to copy over dso->text_offset and dso->text_end
here, which I guess needs to happen.

Even after doing that, I still cannot annotate Windows symbols, though;
I get

  Couldn't annotate RtlLeaveCriticalSection:
  Internal error: Invalid -1 error code

This is true even with libbfd in a non-distro build (without any of my
LLVM patches), so there must be something else at play here.

I _can_ run a Windows binary in WINE and get the right symbols out with
perf report, though. So this leaves only demangling as the final piece
of the puzzle to make distro builds essentially equal to nondistro builds.

/* Steinar */