Received-SPF: pass (google.com: domain of linux-kernel+bounces-189882-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <h23suk5s4hhkf7prhkzxp6a4kmhpgqxyl6ioski5cg7ciihxmj@j4zif6l6dqxc>
In-Reply-To: <h23suk5s4hhkf7prhkzxp6a4kmhpgqxyl6ioski5cg7ciihxmj@j4zif6l6dqxc>
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Sun, 26 May 2024 14:46:04 -0700
Message-ID: <CAHk-=whMS56xLhb7cAmTri2sXtGxK_zKWhZVX87YzjwAfVqTqQ@mail.gmail.com>
Subject: Re: [GIT PULL] header fix for riscv build failure
To: Kent Overstreet <kent.overstreet@linux.dev>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>, 
	Suren Baghdasaryan <surenb@google.com>
Content-Type: text/plain; charset="UTF-8"

On Sun, 26 May 2024 at 10:03, Kent Overstreet <kent.overstreet@linux.dev> wrote:
>
> Hi Linus, this fixes a riscv randconfig build failure from memory
> allocation profiling...

This pull request is odd in multiple ways.

 (a) it's unsigned, and I really don't pull from unsigned sources any more

 (b) the commit message is strange. It says "bcachefs", but I don't see why

 (c) you say riscv randconfig in the pull request but then when I
follow the links in the commit, it says "mips-randconfig". Maybe the
same thing ends up happening elsewhere too - including riscv - but it
sure is confusing and I suspect it was just a typo.

 (d) there's no "Fixes:" tag, so then I had to go and look up that
this wasn't stable material (it doesn't seem to be, the "Fixes" tag
would seem to be 24e44cc22aa3 ("mm: percpu: enable per-cpu allocation
tagging") from the current merge window

All of which means that I ended up just fetching the patch, fixing up
the commit message, and applying it manually instead.

             Linus