Received-SPF: pass (google.com: domain of linux-kernel+bounces-189936-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <03701609-86b7-47a3-85af-db47035695fb@linux.dev>
Date: Mon, 27 May 2024 10:01:35 +0800
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PATCH v6 02/10] drm/bridge: Set firmware node of drm_bridge
 instances automatically
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Robert Foss <rfoss@kernel.org>,
 Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
 dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20240526202115.129049-1-sui.jingfeng@linux.dev>
 <20240526202115.129049-3-sui.jingfeng@linux.dev>
 <lfgb24qv22sohgizlmt7kq3ymnshjeawlkwwcndivbeiloip55@x3qnu4ss3x4y>
Content-Language: en-US, en-AU
From: Sui Jingfeng <sui.jingfeng@linux.dev>
In-Reply-To: <lfgb24qv22sohgizlmt7kq3ymnshjeawlkwwcndivbeiloip55@x3qnu4ss3x4y>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,


On 5/27/24 05:19, Dmitry Baryshkov wrote:
> On Mon, May 27, 2024 at 04:21:07AM +0800, Sui Jingfeng wrote:
>> Normally, the drm_bridge::of_node won't be used by bridge driver instances
>> themselves. Rather, it is mainly used by other modules to find associated
>> drm bridge drvier. Therefore, adding a drm bridge to the global bridge list
>> and setting 'of_node' field of a drm bridge share the same goal. Both are
>> for finding purpose, therefore better to group them to one function.
>>
>> Update the drm_bridge_add() interface and implementation to achieve such
>> goal atomically, new implementation will fetch the device node from the
>> backing device of the drm bridge driver automatically. For the majority
>> cases, which is one device backing one drm bridge driver, this model works
>> well. Drivers still can set it manually by passing NULL if this model
>> doesn't fit.
>>
>> While at it, Add a 'struct device *' pointer to the drm_bridge structure.
>> As it already being passed in by both of drm_bridge_add() and
>> devm_drm_bridge_add(). A lot of driver instances has already added it into
>> their derived structure, promote it into drm_bridge core helps to reduce
>> a batch of boilerplates.
>>
>> Signed-off-by: Sui Jingfeng <sui.jingfeng@linux.dev>
>> ---
> 
> [trimmed]
> 
>> @@ -231,7 +243,7 @@ static void drm_bridge_remove_void(void *bridge)
>>    */
>>   int devm_drm_bridge_add(struct device *dev, struct drm_bridge *bridge)
>>   {
>> -	drm_bridge_add(bridge);
>> +	drm_bridge_add(bridge, dev);
>>   	return devm_add_action_or_reset(dev, drm_bridge_remove_void, bridge);
> 
> This breaks aux-hpd-bridge, which gets of_node as an external pointer
> rather than dev->of_node.
> 

Yes, you are right. I forget to modify that driver.
My bad, will be fixed at the next version.

-- 
Best regards
Sui