Received-SPF: pass (google.com: domain of linux-kernel+bounces-189991-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <1716458390-20120-3-git-send-email-shengjiu.wang@nxp.com> <4c53b063-ad12-405d-b088-9b992284ba08@web.de>
In-Reply-To: <4c53b063-ad12-405d-b088-9b992284ba08@web.de>
From: Shengjiu Wang <shengjiu.wang@gmail.com>
Date: Mon, 27 May 2024 11:43:28 +0800
Message-ID: <CAA+D8ANu6S1vrmAD4FU2X7=9U-B6SwnZu245mu4dXTfgetjDEA@mail.gmail.com>
Subject: Re: [PATCH v5 2/5] clk: imx: clk-audiomix: Add reset controller
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Shengjiu Wang <shengjiu.wang@nxp.com>, linux-clk@vger.kernel.org, 
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, 
	kernel-janitors@vger.kernel.org, imx@lists.linux.dev, 
	Abel Vesa <abelvesa@kernel.org>, Conor Dooley <conor+dt@kernel.org>, 
	Fabio Estevam <festevam@gmail.com>, Krzysztof Kozlowski <krzk+dt@kernel.org>, Marek Vasut <marex@denx.de>, 
	Michael Turquette <mturquette@baylibre.com>, Peng Fan <peng.fan@nxp.com>, 
	Philipp Zabel <p.zabel@pengutronix.de>, Sascha Hauer <s.hauer@pengutronix.de>, 
	Shawn Guo <shawnguo@kernel.org>, Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>, 
	LKML <linux-kernel@vger.kernel.org>, kernel@pengutronix.de
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, May 25, 2024 at 3:27=E2=80=AFPM Markus Elfring <Markus.Elfring@web.=
de> wrote:
>
> =E2=80=A6
> > The reset controller is supported by the auxiliary device
> > framework.
>
> Would you like to add an imperative wording for an improved change descri=
ption?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/D=
ocumentation/process/submitting-patches.rst?h=3Dv6.9#n94

ok, will update it.

>
>
> =E2=80=A6
> > +++ b/drivers/clk/imx/clk-imx8mp-audiomix.c
> =E2=80=A6
> > +static int clk_imx8mp_audiomix_reset_controller_register(struct device=
 *dev,
> > +                                                      struct clk_imx8m=
p_audiomix_priv *priv)
> > +{
> > +     struct auxiliary_device __free(kfree) * adev =3D NULL;
> > +     int ret;
> > +
> > +     adev =3D kzalloc(sizeof(*adev), GFP_KERNEL);
> =E2=80=A6
>
> May the following source code variant be applied here?
>
>         int ret;
>         struct auxiliary_device __free(kfree) *adev =3D kzalloc(sizeof(*a=
dev), GFP_KERNEL);

ok, will update it.

best regards
Shengjiu Wang
>
>
> Regards,
> Markus