Received: by 2002:a89:d88:0:b0:1fa:5c73:8e2d with SMTP id eb8csp1831135lqb; Sun, 26 May 2024 21:07:55 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWJXv77F2P/J5/zle9gjSNHbZfvRZzGY8Lbf2+mMct6VRUNfZM3ur8Z2JIt4gL/S3bmz/60I9cjNT11rd0UH25jVgGaWygKl5Yp0Ro2mw== X-Google-Smtp-Source: AGHT+IH8L2LLsK+UxDDVBThBeY5LqrYDDBEBmaPkvUF/i36JT0P2FHX+T5TSjoCTC2rOWxQbZd+9 X-Received: by 2002:a05:6808:ec8:b0:3c9:6d29:8ec0 with SMTP id 5614622812f47-3d1a7d291b7mr10121612b6e.55.1716782875146; Sun, 26 May 2024 21:07:55 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716782875; cv=pass; d=google.com; s=arc-20160816; b=OLTmB4ZE0yvpvuV4G5T363w8CYIO/4KitXjJlOxKv+26ma3nMCbClpzAGWGoSI6i3p dOv38ao8TpEsfNaQc16mvWUrnqDBGb/H9kli+bXgrgwuJnYAxW8D2KoRyqrCz7pBKVRg 5Vj+COSKb8u8hUHIF13vJ5F09SRkGlUanu7cO39IwClq6URb9RuIH9stq+doj/Usnbyb t9r0GZ6KenGDLPQpM6HWm2HK+uYVpLA0d2yZZDupzmU3PMJihaVqn0O65vHjs+BFIcPd qwJGEslbQf8iqc4uP71/uPb0+RbbER+qdZPtM2FyeQRnVHA8GUa+cfU9/p8fBFtOhjaa MbUw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=kt41rhxUVzJdjXhRoaddGGhrVK4DlKelTW8/fQ+4x9o=; fh=tXslIEC/iII+0o9YvlUtRXapl6zSPusBr1yEidN1Q7w=; b=BtwDBcsDVn7NfaLPv/M7xrRD646HFhuru6omKelLXDWltW88tUPeIVHqqRNE6CB/R/ XBE6XlXhD8Az/GjcCTXUg7ZoHOQsBKXPLI0urMWjfDhVhk1veWSgkItwIVZqODx7nKa7 7HCqcy88s7aZZ3udZ3XVlItd/ZWDOpcfIKwIrtWl7q+nybPpC/atpf7gYK6xw05vz6JJ QchMXHeGdmQy/tI+O/b7J+5lMjUfAgKur/i4LTQCRwRwOagNcfhxKW8o7ZFvKwlVdOS7 AEYkrUgyO2dl6v1q/It+/bMfrnTwhmIqc3mUQd4VGglV4d8/IQv+PSR7ICKu8/1XZMaF F0Fg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=kcdP+Xvc; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-190000-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-190000-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id 6a1803df08f44-6ac11428460si72401286d6.362.2024.05.26.21.07.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 May 2024 21:07:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-190000-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=kcdP+Xvc; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-190000-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-190000-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id C594E1C210E7 for ; Mon, 27 May 2024 04:07:54 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 866688828; Mon, 27 May 2024 04:07:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="kcdP+Xvc" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4664D2E6 for ; Mon, 27 May 2024 04:07:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.21 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716782867; cv=none; b=T2S+t2HgeYgWAJIbJjUfAeAzaGrVDFlh04GuO6UvRIX+9d3nf8s5VIq0ej+pBYNc4dB8/0hmSZm4zu6nKPRnGFREh/kSdV/qY45DSKwqcLSklV/zNVQXNv3jsHwk5KygqbIMSOVuDBAb0+BFq1Mbq2azIySt0jp5SvLmIxCucl8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716782867; c=relaxed/simple; bh=XQ4MRPq1YoTtlAQuO9ub+oyrZ1uUfp5edKW2XiWOGCU=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=JOOh6vlqBmgzENXtLI7iL6bx9SBeOMQ2Y7W097B+1pf3rIl/hbLkKtxKmhVRUuH3Rg5xUEJHk4K2i4NFrJ7KUlfS8076i0MbqZpFdbWsKrvjZWIXJIydgqeo1uiKxeIWUGEtunuYJ/yWZfsa1GBWuJ8lRZ+fmfNgii5HDWmzKDw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=kcdP+Xvc; arc=none smtp.client-ip=198.175.65.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1716782866; x=1748318866; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=XQ4MRPq1YoTtlAQuO9ub+oyrZ1uUfp5edKW2XiWOGCU=; b=kcdP+Xvc0Xp+BbrN4myI7HZ0j07FSonM4HLUxBztI19G0q0icBnxQnC6 3gFHSCvkT4U9U2ijBU83zNO4MHvkTEJSrTByqGXVXilQG9tQLaIaY4ZIt Zn6DncXQNJUf7MvPLknx4v3hFrQZStG9RWRU4i8Zb9fZztygxs0Hyir4Q ZZLwV7HYFaff9rUnxMAlize16N9v4Ac7d2x3V7MAlRbtNfQE9vq31vgBo 0KZWNa7hXXbU0p3jak/uYI/tz5RnTjKWgDySwAK3L2mkH/XDQikGjDfac Tmhga9mtH2IkYUL6iCiy5dDfKFGtihQnzdY8RNXSCH7G3v83zXA1TBU6U w==; X-CSE-ConnectionGUID: vbIW4MsDTbOKzlI2tqwnaQ== X-CSE-MsgGUID: jULpbePwTsuKL6PJf3CBVQ== X-IronPort-AV: E=McAfee;i="6600,9927,11084"; a="13022636" X-IronPort-AV: E=Sophos;i="6.08,191,1712646000"; d="scan'208";a="13022636" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 May 2024 21:07:25 -0700 X-CSE-ConnectionGUID: 7+Q3sbmWSFaQyLuHuPhENQ== X-CSE-MsgGUID: peIcVCKOTzeklGwoT/6mbg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,191,1712646000"; d="scan'208";a="39399868" Received: from unknown (HELO allen-box.sh.intel.com) ([10.239.159.127]) by orviesa003.jf.intel.com with ESMTP; 26 May 2024 21:07:21 -0700 From: Lu Baolu To: Jason Gunthorpe , Kevin Tian , Joerg Roedel , Will Deacon , Robin Murphy , Jean-Philippe Brucker , Nicolin Chen , Yi Liu , Jacob Pan , Joel Granados Cc: iommu@lists.linux.dev, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Lu Baolu Subject: [PATCH v6 00/10] IOMMUFD: Deliver IO page faults to user space Date: Mon, 27 May 2024 12:05:07 +0800 Message-Id: <20240527040517.38561-1-baolu.lu@linux.intel.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series implements the functionality of delivering IO page faults to user space through the IOMMUFD framework. One feasible use case is the nested translation. Nested translation is a hardware feature that supports two-stage translation tables for IOMMU. The second-stage translation table is managed by the host VMM, while the first-stage translation table is owned by user space. This allows user space to control the IOMMU mappings for its devices. When an IO page fault occurs on the first-stage translation table, the IOMMU hardware can deliver the page fault to user space through the IOMMUFD framework. User space can then handle the page fault and respond to the device top-down through the IOMMUFD. This allows user space to implement its own IO page fault handling policies. User space application that is capable of handling IO page faults should allocate a fault object, and bind the fault object to any domain that it is willing to handle the fault generatd for them. On a successful return of fault object allocation, the user can retrieve and respond to page faults by reading or writing to the file descriptor (FD) returned. The iommu selftest framework has been updated to test the IO page fault delivery and response functionality. The series and related patches are available on GitHub: https://github.com/LuBaolu/intel-iommu/commits/iommufd-io-pgfault-delivery-v6 Change log: v6: - Refine the attach handle code by shifting the handle allocation to the caller. The caller will then provide the allocated handle to the domain attachment interfaces. - Add reference counter in iommufd_fault_iopf_enable/disable() helpers. - Fix the return values of fault FD's read/write fops. - Add IOMMU_CAP_USER_IOASID_TABLE capability and check it before roll back getting attach_handle to RID. - Move the iopf respond queue from iommufd device to iommufd fault. - Disallow PRI enablement on SR-IOV VF devices. - Miscellaneous cleanup. v5: https://lore.kernel.org/linux-iommu/20240430145710.68112-1-baolu.lu@linux.intel.com/ - Removed attach handle reference count from the core. Drivers will now synchronize their use of handles and domain attach/detach. - Automatically responds to all outstanding faults in hwpt detach or replace paths. - Supports getting a domain-type specific attach handle. - Reorganized the series by changing the patch order. - Miscellaneous cleanup. v4: https://lore.kernel.org/linux-iommu/20240403011519.78512-1-baolu.lu@linux.intel.com/ - Add the iommu domain attachment handle to replace the iopf-specific domain attachment interfaces introduced in the previous v3. - Replace the iommu_sva with iommu domain attachment handle. - Refine some fields in the fault and response message encoding according to feedback collected during v3 review period. - Refine and fix some problems in the fault FD implementation. - Miscellaneous cleanup. v3: https://lore.kernel.org/linux-iommu/20240122073903.24406-1-baolu.lu@linux.intel.com/ - Add iopf domain attach/detach/replace interfaces to manage the reference counters of hwpt and device, ensuring that both can only be destroyed after all outstanding IOPFs have been responded to. - Relocate the fault handling file descriptor from hwpt to a fault object to enable a single fault handling object to be utilized across multiple domains. - Miscellaneous cleanup and performance improvements. v2: https://lore.kernel.org/linux-iommu/20231026024930.382898-1-baolu.lu@linux.intel.com/ - Move all iommu refactoring patches into a sparated series and discuss it in a different thread. The latest patch series [v6] is available at https://lore.kernel.org/linux-iommu/20230928042734.16134-1-baolu.lu@linux.intel.com/ - We discussed the timeout of the pending page fault messages. We agreed that we shouldn't apply any timeout policy for the page fault handling in user space. https://lore.kernel.org/linux-iommu/20230616113232.GA84678@myrica/ - Jason suggested that we adopt a simple file descriptor interface for reading and responding to I/O page requests, so that user space applications can improve performance using io_uring. https://lore.kernel.org/linux-iommu/ZJWjD1ajeem6pK3I@ziepe.ca/ v1: https://lore.kernel.org/linux-iommu/20230530053724.232765-1-baolu.lu@linux.intel.com/ Lu Baolu (10): iommu: Introduce domain attachment handle iommu: Remove sva handle list iommu: Add attach handle to struct iopf_group iommu: Extend domain attach group with handle support iommufd: Add fault and response message definitions iommufd: Add iommufd fault object iommufd: Fault-capable hwpt attach/detach/replace iommufd: Associate fault object with iommufd_hw_pgtable iommufd/selftest: Add IOPF support for mock device iommufd/selftest: Add coverage for IOPF test include/linux/iommu.h | 42 +- drivers/iommu/iommu-priv.h | 11 + drivers/iommu/iommufd/iommufd_private.h | 51 ++ drivers/iommu/iommufd/iommufd_test.h | 8 + include/uapi/linux/iommufd.h | 122 +++++ tools/testing/selftests/iommu/iommufd_utils.h | 84 +++- drivers/dma/idxd/init.c | 2 +- drivers/iommu/io-pgfault.c | 61 +-- drivers/iommu/iommu-sva.c | 37 +- drivers/iommu/iommu.c | 178 +++++-- drivers/iommu/iommufd/device.c | 16 +- drivers/iommu/iommufd/fault.c | 435 ++++++++++++++++++ drivers/iommu/iommufd/hw_pagetable.c | 41 +- drivers/iommu/iommufd/main.c | 6 + drivers/iommu/iommufd/selftest.c | 64 +++ tools/testing/selftests/iommu/iommufd.c | 18 + .../selftests/iommu/iommufd_fail_nth.c | 2 +- drivers/iommu/iommufd/Makefile | 1 + 18 files changed, 1060 insertions(+), 119 deletions(-) create mode 100644 drivers/iommu/iommufd/fault.c -- 2.34.1