Received: by 2002:a89:d88:0:b0:1fa:5c73:8e2d with SMTP id eb8csp1904153lqb; Mon, 27 May 2024 01:01:26 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUrJ4a/E/uZZbNhH0tnU6G2IbXYlf266hZsLEjvRfqX4V3nynnibJ4/nXbtMzPA0oxD0LTKlUb5iV6PDZoBqC5n/M9H21qO1+qRTjaoKw== X-Google-Smtp-Source: AGHT+IGQ5efjkL280VuC8aNOb8nafSLrskH3e8s4QO0LTrUK/hwnfkOUO2RHdFtM7Hq9ys07nI2f X-Received: by 2002:a05:622a:199c:b0:43a:62d3:2cf5 with SMTP id d75a77b69052e-43fb0dc001dmr84924591cf.2.1716796886247; Mon, 27 May 2024 01:01:26 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716796886; cv=pass; d=google.com; s=arc-20160816; b=v9iMbYr+yuN3CZEyGbWIF6trgohEMyy266RXBAScuUHu24856zWI7ew1u4T5NCyb6Z dzaZsrXhPRqfzvkGlWDdSOqijQflGh8JxyWYV2Q0kgAXUInap0i3v1NmZgxfF5yt+N6L dK7+g9WKPNwysuItfleVVn/6Yo0jJK38l49mMxhSuGHPqjVp556eeirbwzOokJ9w9Wd3 VGbkHxmeyS9Uu7uu1S/aqTMCVICM0uRQyvAzl5TWFjN0pvuykZ4yrAT7SQI4k+QaBZw+ UcXfs4jhAZqv8oGHKAHlLuTFQx9nWUTsiN4cn2npZ3DQM+3Ysgh0bLS2NjOYoEw0ONCV ydeA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:dkim-signature; bh=JVF2aDiAwuR8zQRgdtvjMogqVM3XbukgpjZURs9F6bg=; fh=VcUStoVZA1kyZif722sPBzKK/Q6hJAqD8GnzepkLSfQ=; b=xYTWykBwrX2RazVwZr+59VIdOYA3XtFwnaDR8GLZ1DCBTCn0z5YzOquy+7BQ52CLDi qA/09PtRmJBS2Z7cdIEP7iyijg2sDUnLyP9KZUqp3PcmvT0QHtgdjQuBiqNbCRi+Eh4A 1xHH+rYRFXrMAMbZEx0G7xHhFz3tg+cPtddUWEpPvgfDYSvyJe06/MgHLRm7K9PD54IF m1Joo/23fnSIH/Z/6grtfT6FQpVJ+TF7moGynfsdpkEhBMoO5RAy5VCACEYzKZpqgBbs CsAKe7QF0zk74aZ8+vNc9xzokNYUdShfvpoj2cTI4Ni4UYSVQNoHrGTLf+WuTfuP/W8l PjKw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VZGFnL1n; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-190183-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-190183-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id d75a77b69052e-43fb18a69d3si74852591cf.363.2024.05.27.01.01.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 May 2024 01:01:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-190183-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VZGFnL1n; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-190183-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-190183-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id EC5EC1C210DE for ; Mon, 27 May 2024 08:01:25 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B85EE3A8D0; Mon, 27 May 2024 08:01:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VZGFnL1n" Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A2B5210E9 for ; Mon, 27 May 2024 08:01:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716796877; cv=none; b=DwOqgvAE2GS2vNQvvVZHkbnXVQSukfHfGcg2+IHiGa3xpq6kX7avLfROR3GeZCFwCqR+W8gXAA9RlLaIik3yzur6FAxwfMgHXt/PhopqJs3AmPLT+nrDPayuTUamtMltahGpa0e2bo+PKnTm4w7gMxvr9BdSDaMeJmVUJ0qEDhM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716796877; c=relaxed/simple; bh=KGYzo0d4ydTiDRoHwUaveUva4TGHCiqn07mQdn+93U8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mia0AYPrC9jYQsd5pGX1/qBCJmQqUkR3k1f4VvvRaTfoYTs1Km+yNVoBPyXUuBbXJXFsoHwAQKZ3bzm7JOhzY095dpDcpLtd7y+eoH7JKG5esJAWlxbci3GeJR716zCuZaasGrYhPHgKdOuiTZnuVQnJCPE3ZzNOt3Z/NQFyG64= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=VZGFnL1n; arc=none smtp.client-ip=209.85.208.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-578517cab9eso3369446a12.2 for ; Mon, 27 May 2024 01:01:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1716796874; x=1717401674; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=JVF2aDiAwuR8zQRgdtvjMogqVM3XbukgpjZURs9F6bg=; b=VZGFnL1nRoZOHkGqlMC5Cq295VlfVXIKQwieBkvr8Jrx/6OdVmn/sXBIyqOFQDElu2 t4LL1pXLg4Zc00coi0ct4iOolMU0xKEOGYqHDng7o/0M7iozNK32kDT1I58xYTdLFxfN UEBstTxBAPIoU9vkgLbvbItBIY1JQ4+ajqj95Vy3V5eYN6fkCUrGYhe8o0vGWN9dRjqw /gk6jrXeH2FZ+vYHj5fY09Hopcm+zxs95Qgxb2w7S2HXsqPZgPwkGbdCuLaMlK4jiqb9 ZMGn12lSJPT4/LJHBvQerCH+FLxLO0Z3VIpC7vuHbum0o6pudGhjtMvh0NRF7VA/uvNp jhcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716796874; x=1717401674; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JVF2aDiAwuR8zQRgdtvjMogqVM3XbukgpjZURs9F6bg=; b=qcOZXpwQzF1vpJVDWQmgMbEJSfsnUYTm4fna1ENSQv7bEL+4XOfwaNIEUrhHBr0SR1 doXKIH6Oxg0HhSXS8vwgfOGBVDGQwI6v7ouo8CYzXW+TofqR0yrx8o+xOg6WeernWcRv M3IV0Y5/TqCOLrPjO9QEzm+4BCLaT+ojzrEav77VGeWAe8Txf0Z+gvE81ECdGctE6Ygx 0K7Y2SRLaoM5gVYDZUkzU/Iqco5mL8tvvFj1chiT2wNgJhwfdG98Kn4m4CERWOnhso/b +XdNJrLzroqxAFBsVfAf3h9ITlrSpi23+jFOcDVEylJRnlL4Dw4PcdeeBMCXfBZZtH5W MskA== X-Forwarded-Encrypted: i=1; AJvYcCUP+ONCnbhO4sJzUUv0aoQmtjbx4294hdH8JOrGLbOF21Fy3kwGoG9EFVjBuwExxrOr1rRMLVsFiBLXCMZPFYeBOOKi9wEU1XVkAVw0 X-Gm-Message-State: AOJu0YydPUhGFqJJiuuXbT5bUCMEZmjV0Fd/Uq4nAc8jBkMYuveU8D4k mCXsMi9yy/RBaQKpmQt/MoKMr0B0wHfJ4CsPKDuWgrd2WvOIWFFBnkz2uc2m29s= X-Received: by 2002:a50:a417:0:b0:579:c442:3684 with SMTP id 4fb4d7f45d1cf-579c44238e4mr2204315a12.24.1716796873691; Mon, 27 May 2024 01:01:13 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-578523d2507sm5443603a12.40.2024.05.27.01.01.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 May 2024 01:01:13 -0700 (PDT) Date: Mon, 27 May 2024 11:01:09 +0300 From: Dan Carpenter To: Shengjiu Wang Cc: Frank Li , Shengjiu Wang , abelvesa@kernel.org, peng.fan@nxp.com, mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, marex@denx.de, linux-clk@vger.kernel.org, imx@lists.linux.dev, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, p.zabel@pengutronix.de Subject: Re: [PATCH v5 2/5] clk: imx: clk-audiomix: Add reset controller Message-ID: <7ee00c15-ed39-4092-be79-d4683d1c3ee2@moroto.mountain> References: <1716458390-20120-1-git-send-email-shengjiu.wang@nxp.com> <1716458390-20120-3-git-send-email-shengjiu.wang@nxp.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, May 24, 2024 at 09:49:08AM +0800, Shengjiu Wang wrote: > On Fri, May 24, 2024 at 4:36 AM Frank Li wrote: > > > +static int clk_imx8mp_audiomix_reset_controller_register(struct device *dev, > > > + struct clk_imx8mp_audiomix_priv *priv) > > > +{ > > > + struct auxiliary_device __free(kfree) * adev = NULL; > > > > nit: *adev = NULL; > > Actually, the checkpatch.pl told me need to have space after '*'... Someone should fix checkpatch so that it knows that __free() is an attribute, not a function call. (The cleanup.h stuff is quite new). regards, dan carpenter