Received-SPF: pass (google.com: domain of linux-kernel+bounces-190213-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Witold Sadowski <wsadowski@marvell.com>
To: Conor Dooley <conor@kernel.org>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "broonie@kernel.org" <broonie@kernel.org>,
        "robh@kernel.org"
	<robh@kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org"
	<krzysztof.kozlowski+dt@linaro.org>,
        "conor+dt@kernel.org"
	<conor+dt@kernel.org>,
        "pthombar@cadence.com" <pthombar@cadence.com>
Subject: RE: [EXTERNAL] Re: [PATCH v4 2/5] dt-bindings: spi: cadence: Add MRVL
 overlay bindings documentation for Cadence XSPI
Thread-Topic: [EXTERNAL] Re: [PATCH v4 2/5] dt-bindings: spi: cadence: Add
 MRVL overlay bindings documentation for Cadence XSPI
Thread-Index: AQHaoa0LF2icoBWcPku2cJNyboeMIrGPJ4WAgBuz59A=
Date: Mon, 27 May 2024 08:26:06 +0000
Message-ID: 
 <CO6PR18MB4098338A6C600E5A8E8AF1F0B0F02@CO6PR18MB4098.namprd18.prod.outlook.com>
References: <20240509010523.3152264-1-wsadowski@marvell.com>
 <20240509010523.3152264-3-wsadowski@marvell.com>
 <20240509-hurried-canned-3ceac439b93d@spud>
In-Reply-To: <20240509-hurried-canned-3ceac439b93d@spud>
Accept-Language: en-US, pl-PL
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?XY6PedVPtjhb0TSUJz19mq9TRuTBKrScSvA6czVuKjYRXIHtOpDOs4NWdjA8?=
 =?us-ascii?Q?xnQ8AtWx/n6MC4CSZ9Ah9VL+bK640xwXPzVL30S265esqLqGMmtfIOpaRORI?=
 =?us-ascii?Q?lbOFl6QEahMTMVXpBcS5kcpI64bVwMPmf3fxAk+dRSt9ej6C2Jsq3E2w6Tfi?=
 =?us-ascii?Q?kR4V3V8mvroFX+XqSjnO57xjt/4poDqXYJAJc1kaNEJK2Rthh0cFvLg7sLDR?=
 =?us-ascii?Q?zChSR2l6xhYz26tv8iHDowJWd2au82hYUUEa08sjn015DZf7tAX+Ld8f+v6/?=
 =?us-ascii?Q?CckM4CVLShj12LEhIq2brZSnm2OBeFlOOAGmXkQOdogi6kASw/PHIwGJtsih?=
 =?us-ascii?Q?OwJcyGJ2NqWqfRsaZ0NFiQJhH0b+5NFzmwUNg8rkzy00siTccLBWMmD1+DLg?=
 =?us-ascii?Q?p8gmweh48C6mljnfNngE81TsceAOA3Jy884w46r7NvrphULzMr5MXkWKHIgq?=
 =?us-ascii?Q?WKjDcwCzGJS1gQoXTpwHCXm1F0Ms03RkE12hZYR06sF6d0gpxoiRRnXZ24XV?=
 =?us-ascii?Q?IV9qtwqkrjxfWu5gkPiDBOk2swd2IuUXbpLsI3y2uIN1fZBL3ewKFmmsl6VO?=
 =?us-ascii?Q?2fdRjhSkqJ0lpVhmI1PtjxTRvedYVnAQhLXziuzV53T85sQVYTuDUlmaSPQ3?=
 =?us-ascii?Q?Ws/fn0+qbkhSwUXfmhG97+hKFl8KBJ4DCYz4Q4AEUQH3Nw8uC/CzkpeQLFQn?=
 =?us-ascii?Q?1llDs4Y8UKem03QW28bkcma0LC93pK1rwxu0oMq0jMucymjKFThBXI6/bLAA?=
 =?us-ascii?Q?FCS46Sqg6N4qrTnxLLYsT7zouEXSPT+uyoCACxzScBdCS2uesL+gwebZtSZY?=
 =?us-ascii?Q?DaTYuh7PVfFzZlhhS9L46EjwtToz7rrNvE7rZWKHkQ6h/BazEbVxjtp5nCWz?=
 =?us-ascii?Q?2W7TB8bhUBVvr7/F7OiOG35+ec565DveJfSpwM0skd0Ncz1/lMElJ3GseJly?=
 =?us-ascii?Q?u+RW/mF6mYpVJ6dBezNozdug63lx7I0Gk0aq7SAScIr6dmg8wMDOttwdmXXT?=
 =?us-ascii?Q?V0v3cT9fi3Bj37jbKb+RzBebUfW0xVFa5ElwWdiXLqhr2wzYTwenF8mxuhep?=
 =?us-ascii?Q?pIbrNvRlu6LCwhav+nRL2yQsWEfjXn/014vH4KFRs7Zdn7ksWRzgDs2SaEaV?=
 =?us-ascii?Q?zrKD8qxqr89MMu7FN8KZrp1bvPmb4zDF/3EwlpM1rnGjzIDJVZppjWl0+ElZ?=
 =?us-ascii?Q?6WCYH5a+HjokpZqHK1eDLPlvH53+cC8f5AQwq3jAyCH/JVq4N+e/7sI7r5LA?=
 =?us-ascii?Q?g5rXp98gDDaasRF2qw/2kuTbq1YXtkqRAWCK95CrJZAPivV40dmefqgzhT40?=
 =?us-ascii?Q?CHHMY2ZlcDAl/O+kEkmY5ACgXot81KiFRCSxHIX6azPSdNers3TP2rSwaGeJ?=
 =?us-ascii?Q?0gDTEoDDIGmXOrssE0n5nWHoqbwPBs7a3vft9yalIW94iAIYNm9KLIAEWA7P?=
 =?us-ascii?Q?qn4GTUpsAIkZkSipEFoFQVFLmRwD8IolY6nquRPlqI5/CZ/qn41xGP/zKFul?=
 =?us-ascii?Q?5zVOpHtyPE4QwQoI2ODA8+BdO/kHtuI9KaNbG4R4UwxfolNT9FUgbbrA9keG?=
 =?us-ascii?Q?aQoBDTuZt5wHzI/B4Ub+UQJAjWdJqQ5wHKL6IHm7?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4098.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e2006348-84c9-49ce-1f53-08dc7e26a784
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 May 2024 08:26:06.3455
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: gf98mCN5HZisPFwBIkHnCvW6gX0KIEJdYIeBv5L3QKXJtFK/U5U7eEhre8u7vAALvQ7kGelfcDNgSsCh3HsrYQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH4PR18MB6269
X-Proofpoint-GUID: dBf2BG9F9qGzxcRcbkNpoGQLdPQpacTN
X-Proofpoint-ORIG-GUID: dBf2BG9F9qGzxcRcbkNpoGQLdPQpacTN
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16
 definitions=2024-05-26_09,2024-05-24_01,2024-05-17_01

> ----------------------------------------------------------------------
> Hey Witold,
>=20
> On Wed, May 08, 2024 at 06:05:20PM -0700, Witold Sadowski wrote:
>=20
> >  allOf:
> >    - $ref: spi-controller.yaml#
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            const: marvell,cn10-xspi-nor
> > +    then:
> > +      properties:
> > +        reg-names:
> > +          items:
> > +            - const: io
> > +            - const: sdma
> > +            - const: aux
> > +            - const: xferbase
> > +        reg:
> > +          items:
> > +            - description: address and length of the controller
> register set
> > +            - description: address and length of the Slave DMA data
> port
> > +            - description: address and length of the auxiliary
> registers
> > +            - description: address and length of the xfer registers
> > +    else:
> > +      properties:
> > +        reg-names:
> > +          items:
> > +            - const: io
> > +            - const: sdma
> > +            - const: aux
> > +        reg:
> > +          items:
> > +            - description: address and length of the controller
> register set
> > +            - description: address and length of the Slave DMA data
> port
> > +            - description: address and length of the auxiliary
> > + registers
>=20
> The usual approach here is to define the loosest possible constraints at
> the top level, so unconditionally define the xfer register region, and
> then constrain things based on compatible. In this case, you can set
> minItems to 3 unconditionally and then do (in psuedocode):
> if:
>   marvell
> then:
>   reg:
>     minitems: 4
> else
>   reg:
>     maxItems: 3
>=20
> Additionally, when the allOf: is more then just references to other
> documents, it should be moved below the required list.

Thanks for hints.
Yaml file will be reworked to match guideliness

>=20
> Thanks,
> Conor.

Regards
Witek