Received: by 2002:a89:d88:0:b0:1fa:5c73:8e2d with SMTP id eb8csp1931728lqb; Mon, 27 May 2024 02:11:45 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV0OxT/RxyIdGwxcber94GaHRuE600eMOohncgua8dUSV/GWtqKCsSC1y1+TF181eb4o/oE1PdgPQzbsoWfEj49CsP3uWkR1McvVpo2Qw== X-Google-Smtp-Source: AGHT+IFqq1XNXGPzv4ZFaW5Njcy/3qn1kuuBAAdxl14vdOf+2Hv1E02Zf9jyy/NJktiY1FKavW4p X-Received: by 2002:a50:d64f:0:b0:56e:238e:372c with SMTP id 4fb4d7f45d1cf-57851a5cc47mr6002724a12.26.1716801105056; Mon, 27 May 2024 02:11:45 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716801105; cv=pass; d=google.com; s=arc-20160816; b=keEn1NO8ftkJakynoVsd9SblCGwTavFEQ3GVkmNYLUGm5ctX6iGirq3M//JtjY0/cf 2gXs5nJS2IRFq0eiRxuFeP4QMVhXUk3mYWVgx5PZlvbJycFEo4lwZCkKUMsl4hzWbxeb u6fVBQ0mMsKHkHiUQY7i4qeefMb6Wp6LMB9N/qLmtcFeiftbhuRWFK+gWHo247BQXrS9 uvzOH9Qk4wqzTgPi6OVTI0dZtm0NLFHtKwZ8yYXC8HvfB7Q1tEI5XAUMNQv5QtlNv5vM XxrPO5pruNOKrplN/eXA9fBwSIBZCrWpCZWJ5+yxux4jkRIhko+xvBj0Lx2obxzhgOSM yNIA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:content-transfer-encoding:autocrypt:references :in-reply-to:date:cc:to:from:subject:message-id:dkim-signature; bh=FX8CUXOjKuY0njjjxY7QGNcRoFXxTO7KWKilkbWSobE=; fh=XhP6FTAaXcUNRNjstPMrETNoaaKcZjAHaYcYgM4EtJM=; b=V9hiCIVWMsKdtelyDQGgPq7vm/JQEj3lkOkD6o6TlT6JT6Kl07SQGnE0h3lX1UhB7P xD6y3w5r1gjX1R9iTw52zsipo3g4CVp3sPBgu9DsApyaDaSdAxpynvKjWQQj/cMA0IRD NxR5907ymFJSNFy2NQneaK03OWa89NEwisjK8HTK8VmwhFg0ZVvz/TcdbU+ufQXoT3M5 YEUAk91hC8QDd8ErwklykmUVBwh0BppY7vXXN6nmmu1/uBVw5iYeJNK1Nw3eCtKgVamo gNLh7A0lZfSu/Oke7UtW7F4KPI+4zC7/CTOuBS2peB02opZJJJ7AjxqNiNRQK3mhfx+U iqbg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=BDFhN6g1; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-190295-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-190295-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-579d445bbe2si908182a12.358.2024.05.27.02.11.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 May 2024 02:11:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-190295-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=BDFhN6g1; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-190295-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-190295-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 97CF81F22A05 for ; Mon, 27 May 2024 09:11:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 801EE132494; Mon, 27 May 2024 09:11:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BDFhN6g1" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2AA943AB5 for ; Mon, 27 May 2024 09:11:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716801094; cv=none; b=XJ9gNQQv4iWcOalweLKpHaLzPpPg/x9GVYpO+qDSMn/5dS/JNioe8qLNNZNqsPE6ISIGx/Kp0IrwEi21eauJH+OZosD61xKkb19vPRs+wwA032A/AgeFSH7s7v/IeMEfUgab595/Rcg33aqdCz8tzXfhzPNqKIL0PUnlCUVU4Ho= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716801094; c=relaxed/simple; bh=FX8CUXOjKuY0njjjxY7QGNcRoFXxTO7KWKilkbWSobE=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=aLRgogIdld1PuMfRbaerTPRWw1yQtKpWEcO2LxN6hBdkYXfj0IlitgqXfMHvNn2ovqB+PAXHX7UY8WfGctViHp/LraYKprVlX8ltEwYN44Op94rZqwR1e9RsASCEBTxvPG9twsVMK4NHrcPF1sFTMFpKuQQedMptLyz4LsMBR3w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=BDFhN6g1; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1716801091; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=FX8CUXOjKuY0njjjxY7QGNcRoFXxTO7KWKilkbWSobE=; b=BDFhN6g1p7ud4bYJbaMoYICYSG48ffPH/zWWdm71pLXP6yAfAeDaYqR2IZm2e7dSGJVP4C w+CVA2Jnrueerm581jiUXYLN/FPcV6C+vI4fAw2ZHyrmAiwBfe2x/WEK12nIaQ+llunfmv hXV6zP2mTutmikL/cBPOE8OVwAAH+hA= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-649-B3alxq2XOxyv5rwWc__ZgQ-1; Mon, 27 May 2024 05:11:30 -0400 X-MC-Unique: B3alxq2XOxyv5rwWc__ZgQ-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-42111cf8bfbso1043085e9.2 for ; Mon, 27 May 2024 02:11:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716801089; x=1717405889; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FX8CUXOjKuY0njjjxY7QGNcRoFXxTO7KWKilkbWSobE=; b=LYtMhfK9sSmU90Vphtb6eC+awgTOtA4A+n0VQpGGGuAnOcbpEnyd+oJ2sCOBggRaYC lveShv4qX1ze2i5rHgv0+PBIyv7ZK1r8sZZM41AuX658LTh0EbTVGfmPSBmRl89XWspe KLVudJek9dNdihjEoPE9unsEbzjWpNeWrwGI7XKrZwpriNeQKT/5Rg+2oaECqH9LvedF nqBS0t5R2T0wKQUNmYBaF9KzHr+c6pNu8zXSpDzy7MnvEIZ/aMXBKZlda/GehsUDIumr 3fJ0cNhlDsUr8Z50sLPrl1u5asx/5JcRAk51NOYwOTk+/mVUwjQH1qRSK3U1xI2DXG4z VMTg== X-Forwarded-Encrypted: i=1; AJvYcCWXYS4Dn1ChIWewAFdh1TC9px+wMQ0KXsXX0z3uQWbRdUM073lbP6knaEBC1tn8ReYoMNHIXDPuPkOXQIiOPpqpIvpTx9pq9IZIIEHh X-Gm-Message-State: AOJu0YzKY5LanhMEafTvvYorf3FCVtiish4k5WfkJqqx29g2jG7fXpcm a7kY01TDtmi+iAnN7cb0erDbnlMaMO+tY+bF4nQBoZnPIhOB82rJE0a4qBWi0KRi9xAanz1tsdv 1qI58d3K3/RCVxBWZaVCHP/3+nsp6UpV8MuF0QTphPw7pn7w7r1pDtHIST0Whrw== X-Received: by 2002:a05:600c:3c8e:b0:41c:a98:b217 with SMTP id 5b1f17b1804b1-42108a18d32mr73657905e9.4.1716801089042; Mon, 27 May 2024 02:11:29 -0700 (PDT) X-Received: by 2002:a05:600c:3c8e:b0:41c:a98:b217 with SMTP id 5b1f17b1804b1-42108a18d32mr73657725e9.4.1716801088497; Mon, 27 May 2024 02:11:28 -0700 (PDT) Received: from gerbillo.redhat.com ([2a0d:3341:b094:ab10:29ae:cdc:4db4:a22a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42108966682sm102307015e9.2.2024.05.27.02.11.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 May 2024 02:11:28 -0700 (PDT) Message-ID: <9bb0e47adf20c5524b45712fc92a37f2dae568be.camel@redhat.com> Subject: Re: [PATCH v2] net/ncsi: Fix the multi thread manner of NCSI driver From: Paolo Abeni To: DelphineCCChiu , patrick@stwcx.xyz, Samuel Mendoza-Jonas , "David S. Miller" , Eric Dumazet , Jakub Kicinski Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 27 May 2024 11:11:25 +0200 In-Reply-To: <20240522012537.2485027-1-delphine_cc_chiu@wiwynn.com> References: <20240522012537.2485027-1-delphine_cc_chiu@wiwynn.com> Autocrypt: addr=pabeni@redhat.com; prefer-encrypt=mutual; keydata=mQINBGISiDUBEAC5uMdJicjm3ZlWQJG4u2EU1EhWUSx8IZLUTmEE8zmjPJFSYDcjtfGcbzLPb63BvX7FADmTOkO7gwtDgm501XnQaZgBUnCOUT8qv5MkKsFH20h1XJyqjPeGM55YFAXc+a4WD0YyO5M0+KhDeRLoildeRna1ey944VlZ6Inf67zMYw9vfE5XozBtytFIrRyGEWkQwkjaYhr1cGM8ia24QQVQid3P7SPkR78kJmrT32sGk+TdR4YnZzBvVaojX4AroZrrAQVdOLQWR+w4w1mONfJvahNdjq73tKv51nIpu4SAC1Zmnm3x4u9r22mbMDr0uWqDqwhsvkanYmn4umDKc1ZkBnDIbbumd40x9CKgG6ogVlLYeJa9WyfVMOHDF6f0wRjFjxVoPO6p/ZDkuEa67KCpJnXNYipLJ3MYhdKWBZw0xc3LKiKc+nMfQlo76T/qHMDfRMaMhk+L8gWc3ZlRQFG0/Pd1pdQEiRuvfM5DUXDo/YOZLV0NfRFU9SmtIPhbdm9cV8Hf8mUwubihiJB/9zPvVq8xfiVbdT0sPzBtxW0fXwrbFxYAOFvT0UC2MjlIsukjmXOUJtdZqBE3v3Jf7VnjNVj9P58+MOx9iYo8jl3fNd7biyQWdPDfYk9ncK8km4skfZQIoUVqrWqGDJjHO1W9CQLAxkfOeHrmG29PK9tHIwARAQABtB9QYW9sbyBBYmVuaSA8cGFiZW5pQHJlZGhhdC5jb20+iQJSBBMBCAA8FiEEg1AjqC77wbdLX2LbKSR5jcyPE6QFAmISiDUCGwMFCwkIBwIDIgIBBhUKCQgLAgQWAgMBAh4HAheAAAoJECkkeY3MjxOkJSYQAJcc6MTsuFxYdYZkeWjW//zbD3ApRHzpNlHLVSuJqHr9/aDS+tyszgS8jj9MiqALzgq4iZbg 7ZxN9ZsDL38qVIuFkSpgMZCiUHdxBC11J8nbBSLlpnc924UAyr5XrGA99 6Wl5I4Km3128GY6iAkH54pZpOmpoUyBjcxbJWHstzmvyiXrjA2sMzYjt3Xkqp0cJfIEekOi75wnNPofEEJg28XPcFrpkMUFFvB4Aqrdc2yyR8Y36rbw18sIX3dJdomIP3dL7LoJi9mfUKOnr86Z0xltgcLPGYoCiUZMlXyWgB2IPmmcMP2jLJrusICjZxLYJJLofEjznAJSUEwB/3rlvFrSYvkKkVmfnfro5XEr5nStVTECxfy7RTtltwih85LlZEHP8eJWMUDj3P4Q9CWNgz2pWr1t68QuPHWaA+PrXyasDlcRpRXHZCOcvsKhAaCOG8TzCrutOZ5NxdfXTe3f1jVIEab7lNgr+7HiNVS+UPRzmvBc73DAyToKQBn9kC4jh9HoWyYTepjdcxnio0crmara+/HEyRZDQeOzSexf85I4dwxcdPKXv0fmLtxrN57Ae82bHuRlfeTuDG3x3vl/Bjx4O7Lb+oN2BLTmgpYq7V1WJPUwikZg8M+nvDNcsOoWGbU417PbHHn3N7yS0lLGoCCWyrK1OY0QM4EVsL3TjOfUtCNQYW9sbyBBYmVuaSA8cGFvbG8uYWJlbmlAZ21haWwuY29tPokCUgQTAQgAPBYhBINQI6gu+8G3S19i2ykkeY3MjxOkBQJiEoitAhsDBQsJCAcCAyICAQYVCgkICwIEFgIDAQIeBwIXgAAKCRApJHmNzI8TpBzHD/45pUctaCnhee1vkQnmStAYvHmwrWwIEH1lzDMDCpJQHTUQOOJWDAZOFnE/67bxSS81Wie0OKW2jvg1ylmpBA0gPpnzIExQmfP72cQ1TBoeVColVT6Io35BINn+ymM7c0Bn8RvngSEpr3jBtqvvWXjvtnJ5/HbOVQCg62NC6ewosoKJPWpGXMJ9SKsVIOUHsmoWK60spzeiJoSmAwm3zTJQnM5kRh2q iWjoCy8L35zPqR5TV+f5WR5hTVCqmLHSgm1jxwKhPg9L+GfuE4d0SWd84y GeOB3sSxlhWsuTj1K6K3MO9srD9hr0puqjO9sAizd0BJP8ucf/AACfrgmzIqZXCfVS7jJ/M+0ic+j1Si3yY8wYPEi3dvbVC0zsoGj9n1R7B7L9c3g1pZ4L9ui428vnPiMnDN3jh9OsdaXeWLvSvTylYvw9q0DEXVQTv4/OkcoMrfEkfbXbtZ3PRlAiddSZA5BDEkkm6P9KA2YAuooi1OD9d4MW8LFAeEicvHG+TPO6jtKTacdXDRe611EfRwTjBs19HmabSUfFcumL6BlVyceIoSqXFe5jOfGpbBevTZtg4kTSHqymGb6ra6sKs+/9aJiONs5NXY7iacZ55qG3Ib1cpQTps9bQILnqpwL2VTaH9TPGWwMY3Nc2VEc08zsLrXnA/yZKqZ1YzSY9MGXWYLkCDQRiEog1ARAAyXMKL+x1lDvLZVQjSUIVlaWswc0nV5y2EzBdbdZZCP3ysGC+s+n7xtq0o1wOvSvaG9h5q7sYZs+AKbuUbeZPu0bPWKoO02i00yVoSgWnEqDbyNeiSW+vI+VdiXITV83lG6pS+pAoTZlRROkpb5xo0gQ5ZeYok8MrkEmJbsPjdoKUJDBFTwrRnaDOfb+Qx1D22PlAZpdKiNtwbNZWiwEQFm6mHkIVSTUe2zSemoqYX4QQRvbmuMyPIbwbdNWlItukjHsffuPivLF/XsI1gDV67S1cVnQbBgrpFDxN62USwewXkNl+ndwa+15wgJFyq4Sd+RSMTPDzDQPFovyDfA/jxN2SK1Lizam6o+LBmvhIxwZOfdYH8bdYCoSpqcKLJVG3qVcTwbhGJr3kpRcBRz39Ml6iZhJyI3pEoX3bJTlR5Pr1Kjpx13qGydSMos94CIYWAKhegI06aTdvvuiigBwjngo/Rk5S+iEGR5KmTqGyp27o6YxZy6D4NIc6PKUzhIUxfvuHNvfu sD2W1U7eyLdm/jCgticGDsRtweytsgCSYfbz0gdgUuL3EBYN3JLbAU+UZpy v/fyD4cHDWaizNy/KmOI6FFjvVh4LRCpGTGDVPHsQXaqvzUybaMb7HSfmBBzZqqfVbq9n5FqPjAgD2lJ0rkzb9XnVXHgr6bmMRlaTlBMAEQEAAYkCNgQYAQgAIBYhBINQI6gu+8G3S19i2ykkeY3MjxOkBQJiEog1AhsMAAoJECkkeY3MjxOkY1YQAKdGjHyIdOWSjM8DPLdGJaPgJdugHZowaoyCxffilMGXqc8axBtmYjUIoXurpl+f+a7S0tQhXjGUt09zKlNXxGcebL5TEPFqgJTHN/77ayLslMTtZVYHE2FiIxkvW48yDjZUlefmphGpfpoXe4nRBNto1mMB9Pb9vR47EjNBZCtWWbwJTIEUwHP2Z5fV9nMx9Zw2BhwrfnODnzI8xRWVqk7/5R+FJvl7s3nY4F+svKGD9QHYmxfd8Gx42PZc/qkeCjUORaOf1fsYyChTtJI4iNm6iWbD9HK5LTMzwl0n0lL7CEsBsCJ97i2swm1DQiY1ZJ95G2Nz5PjNRSiymIw9/neTvUT8VJJhzRl3Nb/EmO/qeahfiG7zTpqSn2dEl+AwbcwQrbAhTPzuHIcoLZYV0xDWzAibUnn7pSrQKja+b8kHD9WF+m7dPlRVY7soqEYXylyCOXr5516upH8vVBmqweCIxXSWqPAhQq8d3hB/Ww2A0H0PBTN1REVw8pRLNApEA7C2nX6RW0XmA53PIQvAP0EAakWsqHoKZ5WdpeOcH9iVlUQhRgemQSkhfNaP9LqR1XKujlTuUTpoyT3xwAzkmSxN1nABoutHEO/N87fpIbpbZaIdinF7b9srwUvDOKsywfs5HMiUZhLKoZzCcU/AEFjQsPTATACGsWf3JYPnWxL9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi, On Wed, 2024-05-22 at 09:25 +0800, DelphineCCChiu wrote: > Currently NCSI driver will send several NCSI commands back to back withou= t > waiting the response of previous NCSI command or timeout in some state > when NIC have multi channel. This operation against the single thread > manner defined by NCSI SPEC(section 6.3.2.3 in DSP0222_1.1.1) >=20 > According to NCSI SPEC(section 6.2.13.1 in DSP0222_1.1.1), we should prob= e > one channel at a time by sending NCSI commands (Clear initial state, Get > version ID, Get capabilities...), than repeat this steps until the max > number of channels which we got from NCSI command (Get capabilities) has > been probed. >=20 > Signed-off-by: DelphineCCChiu As noted by Jakub, this looks like a fix. Please include a suitable Fixes tag in the tag area and the target tree 'net' inside the subject prefix. Thanks! Paolo